jackmidi: api cleanup

Hi!

I think it is still time to cleanup API a bit.
Here's the patches to remove nframes argument from all
jack_midi_ calls.
Hope you'll like it.


Dmitry.

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el

On Tue, 2007-04-03 at 02:12 +0400, Dmitry Baikov wrote:
> Hi!
> 
> I think it is still time to cleanup API a bit.
> Here's the patches to remove nframes argument from all
jack_midi_ calls.
> Hope you'll like it.

i do, i do!


------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el

Le 3 avr. 07 à 02:00, Paul Davis a écrit :

> On Tue, 2007-04-03 at 02:12 +0400, Dmitry Baikov
wrote:
>> Hi!
>>
>> I think it is still time to cleanup API a bit.
>> Here's the patches to remove nframes argument from
all jack_midi_  
>> calls.
>> Hope you'll like it.
>
> i do, i do!
>


I do also (-:

Do we change the API right now... or let also the old way
with a BIG  
OBSOLETE WARNING somewhere?

Stephane

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el

On Tue, 2007-04-03 at 08:43 +0200, Stéphane Letz wrote:
> Le 3 avr. 07 à 02:00, Paul Davis a écrit :
> 
> > On Tue, 2007-04-03 at 02:12 +0400, Dmitry Baikov
wrote:
> >> Hi!
> >>
> >> I think it is still time to cleanup API a bit.
> >> Here's the patches to remove nframes argument
from all jack_midi_  
> >> calls.
> >> Hope you'll like it.
> >
> > i do, i do!
> >
> 
> 
> I do also (-:
> 
> Do we change the API right now... or let also the old
way with a BIG  
> OBSOLETE WARNING somewhere?

we should drop it now. the MIDI API is still unofficial.

which of course reminds me of changes to the audio API that
i really
believe must happen before we can call JACK "1.0":

   * change port naming conventions for standard backends
   * remove jack_port_{lock,unlock} from the API (i know of
only
       one developer who has even considered using it, and i
warned
       them away)
   * fix the issues raised by Fons recently

   



------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el

Le 3 avr. 07 à 15:37, Paul Davis a écrit :

> On Tue, 2007-04-03 at 08:43 +0200, Stéphane Letz
wrote:
>> Le 3 avr. 07 à 02:00, Paul Davis a écrit :
>>
>>> On Tue, 2007-04-03 at 02:12 +0400, Dmitry
Baikov wrote:
>>>> Hi!
>>>>
>>>> I think it is still time to cleanup API a
bit.
>>>> Here's the patches to remove nframes
argument from all jack_midi_
>>>> calls.
>>>> Hope you'll like it.
>>>
>>> i do, i do!
>>>
>>
>>
>> I do also (-:
>>
>> Do we change the API right now... or let also the
old way with a BIG
>> OBSOLETE WARNING somewhere?
>
> we should drop it now. the MIDI API is still
unofficial.
>

OK, so Dmitry  "remove-nframes patch" applied on
jackdmp SVN.

> which of course reminds me of changes to the audio API
that i really
> believe must happen before we can call JACK
"1.0":
>
>    * change port naming conventions for standard
backends

what do you suggest? capture/playback  (hum... probably not
so happy  
with that...)

>    * remove jack_port_{lock,unlock} from the API (i
know of only
>        one developer who has even considered using it,
and i warned
>        them away)
>    * fix the issues raised by Fons recently
>
>

i'll do that in jackdmp as soon as it is done in jack.

Stephane 
------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el

On Tue, Apr 03, 2007 at 09:37:44AM -0400, Paul Davis wrote:

> which of course reminds me of changes to the audio API
that i really
> believe must happen before we can call JACK
"1.0":
> 
>    * change port naming conventions for standard
backends
>
>    * remove jack_port_{lock,unlock} from the API (i
know of only
>        one developer who has even considered using it,
and i warned
>        them away)

Mmm, why remove it ? It's smple and _can_ be useful. Unless
it bites
in I way that I can't see ATM.

>    * fix the issues raised by Fons recently

Regarding the port-registration and graph-reorder callbacks,
I don't
think there is a bug as was suggested in that thread. But a
connection
/ disconnection callback providing the ports affected would
be great.

For 1.0 I'd also consider rewriting the DLL code a bit
(nothing
fundamental) so it can provide some useful information more
easily,
and also allow reading that information via libjack. The
latter may
require an engine <-> libjack interface change.

Another area that could be cleanup up a bit is the DSP load

code. Currently it keeps an array of measurements and scans
this
periodically to find the maximum. A much simpler solution is
to
update a maximum that is kept for some time and then
decays.
There is then no need to keep an array of measurements.
Another improvement would be to have both a maximum and and
average, if these are different this indicates some client
is behaving strangely.

-- 
FA

Follie! Follie! Delirio vano è questo !



------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el

On Tue, Apr 03, 2007 at 09:37:44AM -0400, Paul Davis wrote:


> which of course reminds me of changes to the audio API
that i really
> believe must happen before we can call JACK
"1.0":

One more thing for 1.0 which I forgot: the wait() interface
that 
SL recently implemented in jackdmp. It can't be used unless
there
is exactly the same in jackd.

-- 
FA

Follie! Follie! Delirio vano è questo !



------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el

On 4/3/07, Fons Adriaensen <fonskokkinizita.net> wrote:
> For 1.0 I'd also consider rewriting the DLL code a bit
(nothing
> fundamental) so it can provide some useful information
more easily,
> and also allow reading that information via libjack.
The latter may
> require an engine <-> libjack interface change.

For my early midi drivers I added 3 new functions to libjack
to work with DLL:

jack_time_t jack_get_time(); // i.e.
jack_get_microseconds()

jack_nframes_t jack_time_to_frames(jack_client_t*,
jack_time_t);
jack_time_t jack_time_to_frames(jack_client_t*,
jack_nframes_t);

They are useful for interfacing with external things.

Later I managed to get rid of them (using
jack_get_sample_rate),
but AFAIR video jack patch adds similar functions, so they
may be useful.


Dmitry.

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el

On 4/3/07, Dmitry Baikov <dsbaikovgmail.com> wrote:
> For my early midi drivers I added 3 new functions to
libjack to work with DLL:
It was called jack-time.patch
It should be in archive, but I can repost it if needed.

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el

On Tuesday 03 Apr 2007 14:37, Paul Davis wrote:
>    * remove jack_port_{lock,unlock} from the API (i
know of only
>        one developer who has even considered using it,
and i warned
>        them away)

The JACK backend for PortAudio v19 calls these functions.  I
haven't 
read the code closely enough to know whether it really means
to and 
what it expects would happen if it didn't.


Chris

------------------------------------------------------------
-------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the
chance to share your
opinions on IT & business topics through brief
surveys-and earn cash
http://www.techsay.com/default.
php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el