what's remaining now?

On 1/25/06, Paul Davis <paullinuxaudiosystems.com>
wrote:
> On Wed, 2006-01-25 at 23:40 +0000, Rui Nuno Capela
wrote:
> > Jack O'Quin wrote:
> > > On 1/24/06, Jack O'Quin <jack.oquingmail.com> wrote:
> > >> On 1/24/06, Rui Nuno Capela <rncbcrncbc.org> wrote:
> > >>> Don't know about you guys, but I
still find very annoying this
> > >>> jack_watchdog behavior of shutting
down the whole process-group, taking X
> > >>> down with it, or at best just leaving
KDE crippled in the way.
> > >>>
> > >>> This has been raised before, just one
year ago:
> > >>>   http://sourceforge.net/mailarchive/message.php?msg
_id=10508275
> > >> I thought this had been fixed already,
but I see it has not.
> > >
> > > Here is the patch I posted quite a while
back.  I believe I was waiting
> > > for feedback that it does in fact solve the
problem that people are
> > > seeing.  Please give it a try and let me
know.  It's just one line; easy
> > > to commit if it works.
> > >
------------------------------------------------------------
------------
> > >
> > > Index: jackd/engine.c
> > >
============================================================
=======
> > > RCS file:
/cvsroot/jackit/jack/jackd/engine.c,v
> > > retrieving revision 1.126
> > > diff -u -r1.126 engine.c
> > > --- jackd/engine.c  15 Jun 2005 09:18:40
-0000      1.126
> > > +++ jackd/engine.c  25 Jan 2006 15:21:38
-0000
> > >  -909,7 +909,7 
> > >                     /* Kill the current
client (guilt by association). */
> > >                     if
(engine->current_client) {
> > >                                     kill
(engine->current_client->
> > > -                                        
control->pgrp, SIGKILL);
> > > +                                        
control->pid, SIGKILL);
> > >                     }
> > >
> > >                     /* kill our process
group, try to get a dump */
> >
> > OK. It works for me! Better yet, X/KDE doesn't go
zombie anymore when
> > e.g. stopping jackd via QjackCtl while some other
clients are still
> > active (a very common situation around here ;).
> >
> > First impressions is that this issue is fixed for
good with this
> > oneliner. If no one stands against it, I'm ready
to commit.
>
> I stand firmly against it.

Would you be willing to reconsider this, Paul?

> It is unacceptable to me that KDE runs applications
started from icons
> in the same process group as the X server. This is
completely
> ridiculous.

> I would accept a cmdline flag that KDE could set to
make this behaviour
> accessible on their platform, but it should not be the
default.

Before I add yet another jackd command argument I'd like to
understand
why killing the process group is *better* than just killing
the client process.
That seems like the right fix to me: it is minimal and it
works in all the cases
I know about.

Various applications use process groups in strange and
unpredictable ways,
depending on their internal needs.  Why put JACK in the
uncomfortable
position of trying to second-guess those decisions?

If it's all right with you, Paul, I'd realy like to commit
this one-line fix.
--
 joq


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web
services, security?
Get stuff done quickly with pre-integrated technology to
make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on
Apache Geronimo
http:
//sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&
amp;3057&dat1642
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el

Jack O'Quin wrote:

>On 1/25/06, Paul Davis <paullinuxaudiosystems.com>
wrote:
>  
>
>>On Wed, 2006-01-25 at 23:40 +0000, Rui Nuno Capela
wrote:
>>    
>>
>>>Jack O'Quin wrote:
>>>      
>>>
>>>>On 1/24/06, Jack O'Quin <jack.oquingmail.com> wrote:
>>>>        
>>>>
>>>>>On 1/24/06, Rui Nuno Capela
<rncbcrncbc.org> wrote:
>>>>>          
>>>>>
>>>>>>Don't know about you guys, but I
still find very annoying this
>>>>>>jack_watchdog behavior of shutting
down the whole process-group, taking X
>>>>>>down with it, or at best just
leaving KDE crippled in the way.
>>>>>>
>>>>>>This has been raised before, just
one year ago:
>>>>>>  http://sourceforge.net/mailarchive/message.php?msg
_id=10508275
>>>>>>            
>>>>>>
>>>>>I thought this had been fixed already,
but I see it has not.
>>>>>          
>>>>>
>>>>Here is the patch I posted quite a while
back.  I believe I was waiting
>>>>for feedback that it does in fact solve the
problem that people are
>>>>seeing.  Please give it a try and let me
know.  It's just one line; easy
>>>>to commit if it works.
>>>>--------------------------------------------
----------------------------
>>>>
>>>>Index: jackd/engine.c
>>>>============================================
=======================
>>>>RCS file:
/cvsroot/jackit/jack/jackd/engine.c,v
>>>>retrieving revision 1.126
>>>>diff -u -r1.126 engine.c
>>>>--- jackd/engine.c  15 Jun 2005 09:18:40
-0000      1.126
>>>>+++ jackd/engine.c  25 Jan 2006 15:21:38
-0000
>>>> -909,7 +909,7 
>>>>                    /* Kill the current
client (guilt by association). */
>>>>                    if
(engine->current_client) {
>>>>                                    kill
(engine->current_client->
>>>>-                                        
control->pgrp, SIGKILL);
>>>>+                                        
control->pid, SIGKILL);
>>>>                    }
>>>>
>>>>                    /* kill our process
group, try to get a dump */
>>>>        
>>>>
>>>OK. It works for me! Better yet, X/KDE doesn't
go zombie anymore when
>>>e.g. stopping jackd via QjackCtl while some
other clients are still
>>>active (a very common situation around here ;).
>>>
>>>First impressions is that this issue is fixed
for good with this
>>>oneliner. If no one stands against it, I'm
ready to commit.
>>>      
>>>
>>I stand firmly against it.
>>    
>>
>
>Would you be willing to reconsider this, Paul?
>
>  
>
>>It is unacceptable to me that KDE runs applications
started from icons
>>in the same process group as the X server. This is
completely
>>ridiculous.
>>    
>>
>
>  
>
Unfortunately I have experienced the exact same problem in
LiVES. The 
only workaround I have found is to use a LiVES.desktop file
with the 
following entries:

Terminal=true
Geometry=0x0

This causes the application to start up inside an xterm,
which is not 
visible to the user (due to geometry of 0x0). The extra
application 
layer of the xterm prevents the kill signal travelling back
up to the X 
server.


Hope this helps,
Gabriel.
http://lives.sourceforge
.net



-------------------------------------------------------
Using Tomcat but need to do more? Need to support web
services, security?
Get stuff done quickly with pre-integrated technology to
make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on
Apache Geronimo
http://sel.as-us.falkag.net/
sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el

Jack O'Quin wrote:
> On 1/25/06, Paul Davis <paullinuxaudiosystems.com>
wrote:
>> On Wed, 2006-01-25 at 23:40 +0000, Rui Nuno Capela
wrote:
>>> Jack O'Quin wrote:
>>>> On 1/24/06, Jack O'Quin <jack.oquingmail.com> wrote:
>>>>> On 1/24/06, Rui Nuno Capela
<rncbcrncbc.org> wrote:
>>>>>> Don't know about you guys, but I
still find very annoying this
>>>>>> jack_watchdog behavior of shutting
down the whole process-group, taking X
>>>>>> down with it, or at best just
leaving KDE crippled in the way.
>>>>>>
>>>>>> This has been raised before, just
one year ago:
>>>>>>   http://sourceforge.net/mailarchive/message.php?msg
_id=10508275
>>>>> I thought this had been fixed already,
but I see it has not.
>>>> Here is the patch I posted quite a while
back.  I believe I was waiting
>>>> for feedback that it does in fact solve the
problem that people are
>>>> seeing.  Please give it a try and let me
know.  It's just one line; easy
>>>> to commit if it works.
>>>>
------------------------------------------------------------
------------
>>>>
>>>> Index: jackd/engine.c
>>>>
============================================================
=======
>>>> RCS file:
/cvsroot/jackit/jack/jackd/engine.c,v
>>>> retrieving revision 1.126
>>>> diff -u -r1.126 engine.c
>>>> --- jackd/engine.c  15 Jun 2005 09:18:40
-0000      1.126
>>>> +++ jackd/engine.c  25 Jan 2006 15:21:38
-0000
>>>>  -909,7 +909,7 
>>>>                     /* Kill the current
client (guilt by association). */
>>>>                     if
(engine->current_client) {
>>>>                                     kill
(engine->current_client->
>>>> -                                        
control->pgrp, SIGKILL);
>>>> +                                        
control->pid, SIGKILL);
>>>>                     }
>>>>
>>>>                     /* kill our process
group, try to get a dump */
>>> OK. It works for me! Better yet, X/KDE doesn't
go zombie anymore when
>>> e.g. stopping jackd via QjackCtl while some
other clients are still
>>> active (a very common situation around here ;).
>>>
>>> First impressions is that this issue is fixed
for good with this
>>> oneliner. If no one stands against it, I'm
ready to commit.
>> I stand firmly against it.
> 
> Would you be willing to reconsider this, Paul?
> 
>> It is unacceptable to me that KDE runs applications
started from icons
>> in the same process group as the X server. This is
completely
>> ridiculous.
> 
>> I would accept a cmdline flag that KDE could set to
make this behaviour
>> accessible on their platform, but it should not be
the default.
> 
> Before I add yet another jackd command argument I'd
like to understand
> why killing the process group is *better* than just
killing the client process.
> That seems like the right fix to me: it is minimal and
it works in all the cases
> I know about.
> 
> Various applications use process groups in strange and
unpredictable ways,
> depending on their internal needs.  Why put JACK in the
uncomfortable
> position of trying to second-guess those decisions?
> 
> If it's all right with you, Paul, I'd realy like to
commit this one-line fix.
> --
>  joq
> 
++vote.

Anyway, I do use this oneliner patch on all of my JACK
boxes, and I'm 
much happier ever since ;) I would/must recommend it,
specially to who 
stands on KDE as his/her preferred desktop environment, like
meself ;)

Cheers.
-- 
rncbc aka Rui Nuno Capela
rncbcrncbc.org


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web
services, security?
Get stuff done quickly with pre-integrated technology to
make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on
Apache Geronimo
http://sel.as-us.falkag.net/
sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Jackit-devel mailing list
Jackit-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jackit-dev
el