Patch for JBAS-5471

Hi Scott/Carlo,

Re: http://ji
ra.jboss.com/jira/browse/JBAS-5471

I've fixed this applying the changes in the attached patch.
Explanation 
of the resolution can be found in the comments I made in the
JIRA. As I 
hardly know this area, could you please review it?

Cheers,
-- 
Galder Zamarreņo
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat

_______________________________________________
jboss-development mailing list
jboss-developmentlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-develop
ment

I'll have to pull down the beta4 branch source to see what
we were doing 
with kernel abstraction in that version.

Galder Zamarreno wrote:
> Hi Scott/Carlo,
>
> Re: http://ji
ra.jboss.com/jira/browse/JBAS-5471
>
> I've fixed this applying the changes in the attached
patch. 
> Explanation of the resolution can be found in the
comments I made in 
> the JIRA. As I hardly know this area, could you please
review it?
>
> Cheers,

_______________________________________________
jboss-development mailing list
jboss-developmentlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-develop
ment

Actually, a question on this: Where are the EJB3 integration
tests 
living now? IOW, tests that ensure deployment of EJB3
artifacts, such as 
this EJB3 service in AS? Are they disabled by any chance?

Galder Zamarreno wrote:
> Hi Scott/Carlo,
> 
> Re: http://ji
ra.jboss.com/jira/browse/JBAS-5471
> 
> I've fixed this applying the changes in the attached
patch. Explanation 
> of the resolution can be found in the comments I made
in the JIRA. As I 
> hardly know this area, could you please review it?
> 
> Cheers,
> 
> 
>
------------------------------------------------------------
------------
> 
> _______________________________________________
> jboss-development mailing list
> jboss-developmentlists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-develop
ment

-- 
Galder Zamarreņo
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
_______________________________________________
jboss-development mailing list
jboss-developmentlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-develop
ment

Integration specific tests are in jbossas/testsuite. The
ejb3-core tests 
still have a lot of integration tests:

ht
tp://wiki.jboss.org/wiki/DevEJB3RunningUnitTests


Galder Zamarreno wrote:
> Actually, a question on this: Where are the EJB3
integration tests 
> living now? IOW, tests that ensure deployment of EJB3
artifacts, such 
> as this EJB3 service in AS? Are they disabled by any
chance?
>
> Galder Zamarreno wrote:
>> Hi Scott/Carlo,
>>
>> Re: http://ji
ra.jboss.com/jira/browse/JBAS-5471
>>
>> I've fixed this applying the changes in the
attached patch. 
>> Explanation of the resolution can be found in the
comments I made in 
>> the JIRA. As I hardly know this area, could you
please review it?
>>
>> Cheers,
>>
>>
>>
------------------------------------------------------------
------------
>>
>> _______________________________________________
>> jboss-development mailing list
>> jboss-developmentlists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-develop
ment
>

_______________________________________________
jboss-development mailing list
jboss-developmentlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-develop
ment

Scott Stark wrote:
> Integration specific tests are in jbossas/testsuite.
The ejb3-core tests 
> still have a lot of integration tests:
> 
> ht
tp://wiki.jboss.org/wiki/DevEJB3RunningUnitTests

In this particular case, assuming that the code I wanna be
fixing lives 
  in AS within the ejb3 integration layer, any test case I
create for 
this should live in AS, correct?

I don't see any org.jboss.test.ejb3 package to test the ejb3
integration 
layer in jbossas/testsuite unless these tests are located
somewhere else.

Or do you expect a test case to fix JBAS-5471, assuming the
fix only 
involved fixing the ejb3 integration layer in AS, to live in
the ejb3 
project? I'm sure there's such test there but probably those
tests 
haven't run yet as the EJB3 team are currently trying to
untangle the 
dependency issues.

> 
> 
> Galder Zamarreno wrote:
>> Actually, a question on this: Where are the EJB3
integration tests 
>> living now? IOW, tests that ensure deployment of
EJB3 artifacts, such 
>> as this EJB3 service in AS? Are they disabled by
any chance?
>>
>> Galder Zamarreno wrote:
>>> Hi Scott/Carlo,
>>>
>>> Re: http://ji
ra.jboss.com/jira/browse/JBAS-5471
>>>
>>> I've fixed this applying the changes in the
attached patch. 
>>> Explanation of the resolution can be found in
the comments I made in 
>>> the JIRA. As I hardly know this area, could you
please review it?
>>>
>>> Cheers,
>>>
>>>
>>>
------------------------------------------------------------
------------
>>>
>>>
_______________________________________________
>>> jboss-development mailing list
>>> jboss-developmentlists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jboss-develop
ment
>>
> 

-- 
Galder Zamarreņo
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
_______________________________________________
jboss-development mailing list
jboss-developmentlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-develop
ment

There is no specific org.jboss.test.ejb3 package as the
tests are 
packaged more along the lines of the function. Create an 
org.jboss.test.ejb3.service package under the testsuite
module and add 
your testcase.

The code in question is part of the jbossas/ejb3 deployers
integration code.

Galder Zamarreno wrote:
>
>
> Scott Stark wrote:
>> Integration specific tests are in
jbossas/testsuite. The ejb3-core 
>> tests still have a lot of integration tests:
>>
>> ht
tp://wiki.jboss.org/wiki/DevEJB3RunningUnitTests
>
> In this particular case, assuming that the code I wanna
be fixing 
> lives  in AS within the ejb3 integration layer, any
test case I create 
> for this should live in AS, correct?
>
> I don't see any org.jboss.test.ejb3 package to test the
ejb3 
> integration layer in jbossas/testsuite unless these
tests are located 
> somewhere else.
>
> Or do you expect a test case to fix JBAS-5471, assuming
the fix only 
> involved fixing the ejb3 integration layer in AS, to
live in the ejb3 
> project? I'm sure there's such test there but probably
those tests 
> haven't run yet as the EJB3 team are currently trying
to untangle the 
> dependency issues.

_______________________________________________
jboss-development mailing list
jboss-developmentlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-develop
ment

I've been thinking through this a bit further, so please
bear with me 

To be mote precise, my test case is just a simple EJB3
service I'm 
trying to deploy. Right now, this is just an example I have
and haven't 
integrated into any testsuite or anything.

(Side note: I'm doing all this cos I was trying to verify
whether 
http:
//jira.jboss.com/jira/browse/EJBTHREE-1015 fails in
trunk as well.)

So, unless EJB3 team are planning to move such tests into AS
testsuite 
(They have AS deployment tests in EJB3 project), I have the
feeling it 
might be pointless for me to add another deployment, in-AS,
test to 
org.jboss.test.ejb3.service in jbossas/testsuite. Am I
right? Judging 
from the link you passed me, they already have such type of
tests there.

What probably makes more sense is for
org.jboss.test.ejb3.service 
package (or if diving by lines of function, which I'm happy
with, 
org.jboss.test.deployers.ejb3, bearing in mind that I'm
trying to test 
code in org.jboss.ejb3.deployers.*) within jbossas/testsuite
to contain 
standalone unit test that mocks other parts and tests the
integration 
code itself.

I can see adding more value with the latter rather than
repeating a EJB3 
service deployment test within jbossas/testsuite and I'm
more than happy 
to do such thing.

Does this make any sense?

Scott Stark wrote:
> There is no specific org.jboss.test.ejb3 package as the
tests are 
> packaged more along the lines of the function. Create
an 
> org.jboss.test.ejb3.service package under the testsuite
module and add 
> your testcase.
> 
> The code in question is part of the jbossas/ejb3
deployers integration 
> code.
> 
> Galder Zamarreno wrote:
>>
>>
>> Scott Stark wrote:
>>> Integration specific tests are in
jbossas/testsuite. The ejb3-core 
>>> tests still have a lot of integration tests:
>>>
>>> ht
tp://wiki.jboss.org/wiki/DevEJB3RunningUnitTests
>>
>> In this particular case, assuming that the code I
wanna be fixing 
>> lives  in AS within the ejb3 integration layer, any
test case I create 
>> for this should live in AS, correct?
>>
>> I don't see any org.jboss.test.ejb3 package to test
the ejb3 
>> integration layer in jbossas/testsuite unless these
tests are located 
>> somewhere else.
>>
>> Or do you expect a test case to fix JBAS-5471,
assuming the fix only 
>> involved fixing the ejb3 integration layer in AS,
to live in the ejb3 
>> project? I'm sure there's such test there but
probably those tests 
>> haven't run yet as the EJB3 team are currently
trying to untangle the 
>> dependency issues.
> 

-- 
Galder Zamarreņo
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
_______________________________________________
jboss-development mailing list
jboss-developmentlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-develop
ment

I've been thinking through this a bit further, so please
bear with me 

To be mote precise, my test case is just a simple EJB3
service I'm 
trying to deploy. Right now, this is just an example I have
and haven't 
integrated into any testsuite or anything.

(Side note: I'm doing all this cos I was trying to verify
whether 
http:
//jira.jboss.com/jira/browse/EJBTHREE-1015 fails in
trunk as well.)

So, unless EJB3 team are planning to move such tests into AS
testsuite 
(They have AS deployment tests in EJB3 project), I have the
feeling it 
might be pointless for me to add another deployment, in-AS,
test to 
org.jboss.test.ejb3.service in jbossas/testsuite. Am I
right? Judging 
from the link you passed me, they already have such type of
tests there.

What probably makes more sense is for
org.jboss.test.ejb3.service 
package (or if diving by lines of function, which I'm happy
with, 
org.jboss.test.deployers.ejb3, bearing in mind that I'm
trying to test 
code in org.jboss.ejb3.deployers.*) within jbossas/testsuite
to contain 
standalone unit test that mocks other parts and tests the
integration 
code itself.

I can see adding more value with the latter rather than
repeating a EJB3 
service deployment test within jbossas/testsuite and I'm
more than happy 
to do such thing.

Does this make any sense? Carlo?

Scott Stark wrote:
> There is no specific org.jboss.test.ejb3 package as the
tests are 
> packaged more along the lines of the function. Create
an 
> org.jboss.test.ejb3.service package under the testsuite
module and add 
> your testcase.
> 
> The code in question is part of the jbossas/ejb3
deployers integration 
> code.
> 
> Galder Zamarreno wrote:
>>
>>
>> Scott Stark wrote:
>>> Integration specific tests are in
jbossas/testsuite. The ejb3-core 
>>> tests still have a lot of integration tests:
>>>
>>> ht
tp://wiki.jboss.org/wiki/DevEJB3RunningUnitTests
>>
>> In this particular case, assuming that the code I
wanna be fixing 
>> lives  in AS within the ejb3 integration layer, any
test case I create 
>> for this should live in AS, correct?
>>
>> I don't see any org.jboss.test.ejb3 package to test
the ejb3 
>> integration layer in jbossas/testsuite unless these
tests are located 
>> somewhere else.
>>
>> Or do you expect a test case to fix JBAS-5471,
assuming the fix only 
>> involved fixing the ejb3 integration layer in AS,
to live in the ejb3 
>> project? I'm sure there's such test there but
probably those tests 
>> haven't run yet as the EJB3 team are currently
trying to untangle the 
>> dependency issues.
> 

-- 
Galder Zamarreņo
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
_______________________________________________
jboss-development mailing list
jboss-developmentlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-develop
ment