JDBCCacheLoader drop table - true by default??

 From AdjListJDBCCacheLoaderConfig.setProperties():

    prop =
props.getProperty("cache.jdbc.table.drop");
    this.dropTable = (prop == null ||
Boolean.valueOf(prop));

Surely this isn't intended?  The impact of this is that if
someone  
using a JDBCCacheLoader doesn't specify
cache.jdbc.table.drop =  
false, the table is dropped every time the cache is
stopped!!  So  
much for persistent state!  

Thoughts?
--
Manik Surtani

Lead, JBoss Cache
JBoss, a division of Red Hat



_______________________________________________
jbosscache-dev mailing list
jbosscache-devlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosscache-dev

Manik Surtani wrote:
>  From AdjListJDBCCacheLoaderConfig.setProperties():
> 
>    prop =
props.getProperty("cache.jdbc.table.drop");
>    this.dropTable = (prop == null ||
Boolean.valueOf(prop));
> 
> Surely this isn't intended?  The impact of this is that
if someone using 
> a JDBCCacheLoader doesn't specify cache.jdbc.table.drop
= false, the 
> table is dropped every time the cache is stopped!!  So
much for 
> persistent state!  
> 
> Thoughts?

That's not good, it should definitely be switched in the
next release.
_______________________________________________
jbosscache-dev mailing list
jbosscache-devlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosscache-dev

Manik Surtani wrote:
>  From AdjListJDBCCacheLoaderConfig.setProperties():
> 
>    prop =
props.getProperty("cache.jdbc.table.drop");
>    this.dropTable = (prop == null ||
Boolean.valueOf(prop));
> 
> Surely this isn't intended?  The impact of this is that
if someone using 
> a JDBCCacheLoader doesn't specify cache.jdbc.table.drop
= false, the 
> table is dropped every time the cache is stopped!!  So
much for 
> persistent state!  

faq: http://wiki.jboss.org/wiki/Wiki.jsp?page=JBoss
CacheTroubleshooting

hehehehe, i once had a support case on this, hence me adding
this to a 
wiki 

> 
> Thoughts?
> -- 
> Manik Surtani
> 
> Lead, JBoss Cache
> JBoss, a division of Red Hat
> 
> 
> 
> _______________________________________________
> jbosscache-dev mailing list
> jbosscache-devlists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosscache-dev

-- 
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
_______________________________________________
jbosscache-dev mailing list
jbosscache-devlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosscache-dev

Might be worth adding an attention note in the Release Notes
of JBC 2.1 
to indicate the change of default behavior too, thoughts?

Mircea Markus wrote:
> This changed in cache 2.1 - I've updated the wiki
accordingly.
> Galder Zamarreno wrote:
>>
>>
>> Manik Surtani wrote:
>>>  From
AdjListJDBCCacheLoaderConfig.setProperties():
>>>
>>>    prop =
props.getProperty("cache.jdbc.table.drop");
>>>    this.dropTable = (prop == null ||
Boolean.valueOf(prop));
>>>
>>> Surely this isn't intended?  The impact of this
is that if someone 
>>> using a JDBCCacheLoader doesn't specify
cache.jdbc.table.drop = 
>>> false, the table is dropped every time the
cache is stopped!!  So 
>>> much for persistent state!  
>>
>> faq: http://wiki.jboss.org/wiki/Wiki.jsp?page=JBoss
CacheTroubleshooting
>>
>> hehehehe, i once had a support case on this, hence
me adding this to a 
>> wiki 
>>
>>>
>>> Thoughts?
>>> -- 
>>> Manik Surtani
>>>
>>> Lead, JBoss Cache
>>> JBoss, a division of Red Hat
>>>
>>>
>>>
>>>
_______________________________________________
>>> jbosscache-dev mailing list
>>> jbosscache-devlists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jbosscache-dev
>>
> 

-- 
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
_______________________________________________
jbosscache-dev mailing list
jbosscache-devlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosscache-dev