Hibernate testsuite bound to internals of JBoss Cache 2.X

I just spotted this, trying to run the Hibernate test suite
against a  
snapshot of 2.2.0:

org 
.hibernate 
.test.cache.jbc2.functional.util.CustomClassLoaderCacheFacto
ry uses an  
internal class, CacheImpl.java, that no longer exists in
2.2.0.

Brian, I vaguely remember you mentioning this to me in the
past,  
should have provided a proper extension point at the time. 
Do you  
know if it is just this test class that extends
DefaultCacheFactory,  
or do you know if this is extended in this manner in
production code  
as well - in any of the AS clustering projects?

Cheers,
--
Manik Surtani
Lead, JBoss Cache
manikjboss.org






_______________________________________________
jbosscache-dev mailing list
jbosscache-devlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosscache-dev

Manik Surtani wrote:
> I just spotted this, trying to run the Hibernate test
suite against a 
> snapshot of 2.2.0:
> 
>
org.hibernate.test.cache.jbc2.functional.util.CustomClassLoa
derCacheFactory 
> uses an internal class, CacheImpl.java, that no longer
exists in 2.2.0.
> 

Good catch.

> Brian, I vaguely remember you mentioning this to me in
the past, should 
> have provided a proper extension point at the time.  

You did, via DefaultCacheFactory.setDefaultCacheLoader().
This class was 
just a leftover from my workaround before you did that.
Wasn't used 
anymore, is now gone from svn, won't be in Hibernate
3.3.0.GA.

> Do you know if it 
> is just this test class that extends
DefaultCacheFactory, or do you know 
> if this is extended in this manner in production code
as well - in any 
> of the AS clustering projects?
> 

99% sure not; for sure not anywhere outside of a test suite.
I'll check 
any test fixtures; if there I'll get rid of it as it's not
needed.

> Cheers,
> -- 
> Manik Surtani
> Lead, JBoss Cache
> manikjboss.org
> 
> 
> 
> 
> 
> 
> _______________________________________________
> jbosscache-dev mailing list
> jbosscache-devlists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosscache-dev

-- 
Brian Stansberry
Lead, AS Clustering
JBoss, a division of Red Hat
brian.stansberryredhat.com
_______________________________________________
jbosscache-dev mailing list
jbosscache-devlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosscache-dev

On 1 May 2008, at 13:59, Brian Stansberry wrote:

>
>
> Manik Surtani wrote:
>> I just spotted this, trying to run the Hibernate
test suite against  
>> a snapshot of 2.2.0:
>> org 
>> .hibernate 
>>
.test.cache.jbc2.functional.util.CustomClassLoaderCacheFacto
ry uses  
>> an internal class, CacheImpl.java, that no longer
exists in 2.2.0.
>
> Good catch.
>
>> Brian, I vaguely remember you mentioning this to me
in the past,  
>> should have provided a proper extension point at
the time.
>
> You did, via
DefaultCacheFactory.setDefaultCacheLoader(). This class  
> was just a leftover from my workaround before you did
that. Wasn't  
> used anymore, is now gone from svn, won't be in
Hibernate 3.3.0.GA.

Cool, thanks.  Without that, Hibernate's jbosscache2
integration tests  
pass 100% with my latest snapshot of 2.2.0.  Time to cut
that beta  
already.  

Cheers,
--
Manik Surtani
Lead, JBoss Cache
manikjboss.org






_______________________________________________
jbosscache-dev mailing list
jbosscache-devlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosscache-dev

Manik Surtani wrote:

<snip/>
> 
> Cool, thanks.  Without that, Hibernate's jbosscache2
integration tests 
> pass 100% with my latest snapshot of 2.2.0.  Time to
cut that beta 
> already.  
> 

Nice. 

EJB3 SFSB is also moving toward an independently testable
module that 
doesn't require a lot of complex integration (this summer).
Will 
probably be a while before that's the case for the web
session stuff though.

-- 
Brian Stansberry
Lead, AS Clustering
JBoss, a division of Red Hat
brian.stansberryredhat.com
_______________________________________________
jbosscache-dev mailing list
jbosscache-devlists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosscache-dev