Created: (JBSEAM-2153) ConversationEntry.redirect applies page param

ConversationEntry.redirect applies page parameters
--------------------------------------------------

                 Key: JBSEAM-2153
                 URL: http://
jira.jboss.com/jira/browse/JBSEAM-2153
             Project: JBoss Seam
          Issue Type: Bug
          Components: Core
    Affects Versions: 2.0.0.CR2
            Reporter: Pete Muir
             Fix For: 2.0.1.GA


ConversationEntry.redirect applies page parameters to the
redirect.  Thus state in the redirected-to conversation is
overwritten by state in the redirected-from conversation
when:

1) The page parameter's value exists in the redirected-from
conversation
2) The redirected-to conversation's view applies a page
parameter with the same name

If (2) doesn't happen it doesn't cause the state to be
overwritten but we still end up with an incorrect url.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        
_______________________________________________
jbossseam-issues mailing list
jbossseam-issueslists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbossseam-issu
es

    [ http://jira.jboss.com/jira/browse/JBS
EAM-2153?page=comments#action_12384176 ] 
            
Pete Muir commented on JBSEAM-2153:
-----------------------------------

Christian and I both feel that it makes no sense for
redirected-to conversations to have page parameter's applied
to.  My proposed fix is to not apply page parameters.

I've tentatively scheduled this for 2.0.1 as Christian isn't
in a hurry for a fix, however we should consider whether
this should go into 2.0.0

Review needed.

> ConversationEntry.redirect applies page parameters
> --------------------------------------------------
>
>                 Key: JBSEAM-2153
>                 URL: http://
jira.jboss.com/jira/browse/JBSEAM-2153
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.CR2
>            Reporter: Pete Muir
>             Fix For: 2.0.1.GA
>
>
> ConversationEntry.redirect applies page parameters to
the redirect.  Thus state in the redirected-to conversation
is overwritten by state in the redirected-from conversation
when:
> 1) The page parameter's value exists in the
redirected-from conversation
> 2) The redirected-to conversation's view applies a page
parameter with the same name
> If (2) doesn't happen it doesn't cause the state to be
overwritten but we still end up with an incorrect url.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        
_______________________________________________
jbossseam-issues mailing list
jbossseam-issueslists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbossseam-issu
es

    [ http://jira.jboss.com/jira/browse/JBS
EAM-2153?page=comments#action_12384726 ] 
            
Dan Allen commented on JBSEAM-2153:
-----------------------------------

Actually, I had observed this issue as well and can explain
the root cause:

The Seam redirect filter interferes with conversation
switching because it allows page parameters to be added to
the URL even though FacesManager works hard to keep them out
of the redirect. The problem is not with ConversationEntry
but rather the extra step added by
<web:redirect-filter>.

What is interesting is that the redirect filter is not
needed if you are using the Seam pages descriptor for
navigation. It is only needed if you are still using
faces-config.xml for navigation. The workaround is to
disable the redirect filter when using Seam page
navigation.

<web:redirect-filter url-pattern="NOPATTERN"
/>

A proper fix would be to pass along a token that tells the
redirect filter not to apply page parameters in certain
cases.

> ConversationEntry.redirect applies page parameters
> --------------------------------------------------
>
>                 Key: JBSEAM-2153
>                 URL: http://
jira.jboss.com/jira/browse/JBSEAM-2153
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.CR2
>            Reporter: Pete Muir
>             Fix For: 2.0.1.GA
>
>
> ConversationEntry.redirect applies page parameters to
the redirect.  Thus state in the redirected-to conversation
is overwritten by state in the redirected-from conversation
when:
> 1) The page parameter's value exists in the
redirected-from conversation
> 2) The redirected-to conversation's view applies a page
parameter with the same name
> If (2) doesn't happen it doesn't cause the state to be
overwritten but we still end up with an incorrect url.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        
_______________________________________________
jbossseam-issues mailing list
jbossseam-issueslists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbossseam-issu
es

    [ http://jira.jboss.com/jira/browse/JBS
EAM-2153?page=comments#action_12384727 ] 
            
Dan Allen commented on JBSEAM-2153:
-----------------------------------

Now that the disabled flag has been added to the filters,
the workaround simplifies to

<web:redirect-filter disabled="true" />

> ConversationEntry.redirect applies page parameters
> --------------------------------------------------
>
>                 Key: JBSEAM-2153
>                 URL: http://
jira.jboss.com/jira/browse/JBSEAM-2153
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.CR2
>            Reporter: Pete Muir
>             Fix For: 2.0.1.GA
>
>
> ConversationEntry.redirect applies page parameters to
the redirect.  Thus state in the redirected-to conversation
is overwritten by state in the redirected-from conversation
when:
> 1) The page parameter's value exists in the
redirected-from conversation
> 2) The redirected-to conversation's view applies a page
parameter with the same name
> If (2) doesn't happen it doesn't cause the state to be
overwritten but we still end up with an incorrect url.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        
_______________________________________________
jbossseam-issues mailing list
jbossseam-issueslists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbossseam-issu
es

    [ http://jira.jboss.com/jira/browse/JBS
EAM-2153?page=comments#action_12386099 ] 
            
Gavin King commented on JBSEAM-2153:
------------------------------------

This should definitely be fixed in 2.0.1. Its a bug.

> ConversationEntry.redirect applies page parameters
> --------------------------------------------------
>
>                 Key: JBSEAM-2153
>                 URL: http://
jira.jboss.com/jira/browse/JBSEAM-2153
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.CR2
>            Reporter: Pete Muir
>             Fix For: 2.0.1.GA
>
>
> ConversationEntry.redirect applies page parameters to
the redirect.  Thus state in the redirected-to conversation
is overwritten by state in the redirected-from conversation
when:
> 1) The page parameter's value exists in the
redirected-from conversation
> 2) The redirected-to conversation's view applies a page
parameter with the same name
> If (2) doesn't happen it doesn't cause the state to be
overwritten but we still end up with an incorrect url.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        
_______________________________________________
jbossseam-issues mailing list
jbossseam-issueslists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbossseam-issu
es

     [ http://jira.jboss.com/jira/browse/JBSEAM-2153?page=all
]

Pete Muir updated JBSEAM-2153:
------------------------------

    Priority: Critical  (was: Major)

> ConversationEntry.redirect applies page parameters
> --------------------------------------------------
>
>                 Key: JBSEAM-2153
>                 URL: http://
jira.jboss.com/jira/browse/JBSEAM-2153
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.CR2
>            Reporter: Pete Muir
>            Priority: Critical
>             Fix For: 2.0.1.GA
>
>
> ConversationEntry.redirect applies page parameters to
the redirect.  Thus state in the redirected-to conversation
is overwritten by state in the redirected-from conversation
when:
> 1) The page parameter's value exists in the
redirected-from conversation
> 2) The redirected-to conversation's view applies a page
parameter with the same name
> If (2) doesn't happen it doesn't cause the state to be
overwritten but we still end up with an incorrect url.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        
_______________________________________________
jbossseam-issues mailing list
jbossseam-issueslists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbossseam-issu
es