Created: (JBSEAM-2226) Need Customer actionOutcome and actionMethod

Need Customer actionOutcome and actionMethod
--------------------------------------------

                 Key: JBSEAM-2226
                 URL: http://
jira.jboss.com/jira/browse/JBSEAM-2226
             Project: JBoss Seam
          Issue Type: Feature Request
          Components: Core
    Affects Versions: 2.0.0.GA
            Reporter: Danny Chen


For conversion id, JBoss Seam provide customize method, for
example:
<core:manager 
    	conversation-timeout="300000" 
		conversation-id-parameter="cid"
/>

But for <s:link>, <s:button>'s actionOutcome and
actionMethod, there isn't a way to change these id. I find
it is hardcode in:

UIAction:
   public String getName()
   {
      return isMethodBinding() ? "actionMethod" :
"actionOutcome";
   }

Pages:
private static boolean callAction(FacesContext
facesContext)
   {
      //TODO: refactor with Pages.instance().callAction()!!
      
      boolean result = false;
      
      String outcome = facesContext.getExternalContext()
           
.getRequestParameterMap().get("actionOutcome");
      String fromAction = outcome;
      
      if (outcome==null)
      {
         String actionId =
facesContext.getExternalContext()
              
.getRequestParameterMap().get("actionMethod");
         if (actionId!=null)
         {
            if (
!SafeActions.instance().isActionSafe(actionId) ) return
result;
            String expression =
SafeActions.toAction(actionId);
            result = true;
            MethodExpression actionExpression =
Expressions.instance().createMethodExpression(expression);
            outcome = toString( actionExpression.invoke()
);
            fromAction = expression;
            handleOutcome(facesContext, outcome,
fromAction);
         }
      }
      else
      {
         handleOutcome(facesContext, outcome, fromAction);
      }
      
      return result;
   }

Can let us change them just like conversion id? Thanks

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        
_______________________________________________
jbossseam-issues mailing list
jbossseam-issueslists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbossseam-issu
es

     [ http://jira.jboss.com/jira/browse/JBSEAM-2226?page=all
]

Pete Muir updated JBSEAM-2226:
------------------------------

    Summary: Customise actionOutcome and actionMethod
parameter names on s:link  (was: Need Customer actionOutcome
and actionMethod)

> Customise actionOutcome and actionMethod parameter
names on s:link
>
------------------------------------------------------------
------
>
>                 Key: JBSEAM-2226
>                 URL: http://
jira.jboss.com/jira/browse/JBSEAM-2226
>             Project: JBoss Seam
>          Issue Type: Feature Request
>          Components: Core
>    Affects Versions: 2.0.0.GA
>            Reporter: Danny Chen
>
> For conversion id, JBoss Seam provide customize method,
for example:
> <core:manager 
>     	conversation-timeout="300000" 
> 		conversation-id-parameter="cid"
> />
> But for <s:link>, <s:button>'s
actionOutcome and actionMethod, there isn't a way to change
these id. I find it is hardcode in:
> UIAction:
>    public String getName()
>    {
>       return isMethodBinding() ?
"actionMethod" : "actionOutcome";
>    }
> Pages:
> private static boolean callAction(FacesContext
facesContext)
>    {
>       //TODO: refactor with
Pages.instance().callAction()!!
>       
>       boolean result = false;
>       
>       String outcome =
facesContext.getExternalContext()
>            
.getRequestParameterMap().get("actionOutcome");
>       String fromAction = outcome;
>       
>       if (outcome==null)
>       {
>          String actionId =
facesContext.getExternalContext()
>               
.getRequestParameterMap().get("actionMethod");
>          if (actionId!=null)
>          {
>             if (
!SafeActions.instance().isActionSafe(actionId) ) return
result;
>             String expression =
SafeActions.toAction(actionId);
>             result = true;
>             MethodExpression actionExpression =
Expressions.instance().createMethodExpression(expression);
>             outcome = toString(
actionExpression.invoke() );
>             fromAction = expression;
>             handleOutcome(facesContext, outcome,
fromAction);
>          }
>       }
>       else
>       {
>          handleOutcome(facesContext, outcome,
fromAction);
>       }
>       
>       return result;
>    }
> Can let us change them just like conversion id? Thanks

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        
_______________________________________________
jbossseam-issues mailing list
jbossseam-issueslists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbossseam-issu
es

     [ http://jira.jboss.com/jira/browse/JBSEAM-2226?page=all
]

Norman Richards updated JBSEAM-2226:
------------------------------------

    Fix Version/s: 2.0.x

> Customise actionOutcome and actionMethod parameter
names on s:link
>
------------------------------------------------------------
------
>
>                 Key: JBSEAM-2226
>                 URL: http://
jira.jboss.com/jira/browse/JBSEAM-2226
>             Project: JBoss Seam
>          Issue Type: Feature Request
>          Components: Core
>    Affects Versions: 2.0.0.GA
>            Reporter: Danny Chen
>             Fix For: 2.0.x
>
>
> For conversion id, JBoss Seam provide customize method,
for example:
> <core:manager 
>     	conversation-timeout="300000" 
> 		conversation-id-parameter="cid"
> />
> But for <s:link>, <s:button>'s
actionOutcome and actionMethod, there isn't a way to change
these id. I find it is hardcode in:
> UIAction:
>    public String getName()
>    {
>       return isMethodBinding() ?
"actionMethod" : "actionOutcome";
>    }
> Pages:
> private static boolean callAction(FacesContext
facesContext)
>    {
>       //TODO: refactor with
Pages.instance().callAction()!!
>       
>       boolean result = false;
>       
>       String outcome =
facesContext.getExternalContext()
>            
.getRequestParameterMap().get("actionOutcome");
>       String fromAction = outcome;
>       
>       if (outcome==null)
>       {
>          String actionId =
facesContext.getExternalContext()
>               
.getRequestParameterMap().get("actionMethod");
>          if (actionId!=null)
>          {
>             if (
!SafeActions.instance().isActionSafe(actionId) ) return
result;
>             String expression =
SafeActions.toAction(actionId);
>             result = true;
>             MethodExpression actionExpression =
Expressions.instance().createMethodExpression(expression);
>             outcome = toString(
actionExpression.invoke() );
>             fromAction = expression;
>             handleOutcome(facesContext, outcome,
fromAction);
>          }
>       }
>       else
>       {
>          handleOutcome(facesContext, outcome,
fromAction);
>       }
>       
>       return result;
>    }
> Can let us change them just like conversion id? Thanks

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        
_______________________________________________
jbossseam-issues mailing list
jbossseam-issueslists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbossseam-issu
es

     [ http://jira.jboss.com/jira/browse/JBSEAM-2226?page=all
]

Norman Richards updated JBSEAM-2226:
------------------------------------

    Fix Version/s: 2.1.0.GA
                       (was: 2.1.0.A1)

> Customise actionOutcome and actionMethod parameter
names on s:link
>
------------------------------------------------------------
------
>
>                 Key: JBSEAM-2226
>                 URL: http://
jira.jboss.com/jira/browse/JBSEAM-2226
>             Project: JBoss Seam
>          Issue Type: Feature Request
>          Components: Core
>    Affects Versions: 2.0.0.GA
>            Reporter: Danny Chen
>             Fix For: 2.1.0.GA
>
>
> For conversion id, JBoss Seam provide customize method,
for example:
> <core:manager 
>     	conversation-timeout="300000" 
> 		conversation-id-parameter="cid"
> />
> But for <s:link>, <s:button>'s
actionOutcome and actionMethod, there isn't a way to change
these id. I find it is hardcode in:
> UIAction:
>    public String getName()
>    {
>       return isMethodBinding() ?
"actionMethod" : "actionOutcome";
>    }
> Pages:
> private static boolean callAction(FacesContext
facesContext)
>    {
>       //TODO: refactor with
Pages.instance().callAction()!!
>       
>       boolean result = false;
>       
>       String outcome =
facesContext.getExternalContext()
>            
.getRequestParameterMap().get("actionOutcome");
>       String fromAction = outcome;
>       
>       if (outcome==null)
>       {
>          String actionId =
facesContext.getExternalContext()
>               
.getRequestParameterMap().get("actionMethod");
>          if (actionId!=null)
>          {
>             if (
!SafeActions.instance().isActionSafe(actionId) ) return
result;
>             String expression =
SafeActions.toAction(actionId);
>             result = true;
>             MethodExpression actionExpression =
Expressions.instance().createMethodExpression(expression);
>             outcome = toString(
actionExpression.invoke() );
>             fromAction = expression;
>             handleOutcome(facesContext, outcome,
fromAction);
>          }
>       }
>       else
>       {
>          handleOutcome(facesContext, outcome,
fromAction);
>       }
>       
>       return result;
>    }
> Can let us change them just like conversion id? Thanks

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        
_______________________________________________
jbossseam-issues mailing list
jbossseam-issueslists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbossseam-issu
es