Patch: UserPreferences.jsp messing with profile.mail even when viewing only

Hi!

See below for a quick fix that prevents overwriting the
current user's 
mail address (profile.mail) when viewing (not POSTing) 
UserPreferences.jsp. This is needed for the LDAP auth plugin
as it uses 
only one profile object per user which gets overwritten all
the time 
otherwise.

This applies to 2.4.13 but probably the issue remains with
current CVS, too.

Regards

Index: src/webdocs/UserPreferences.jsp
============================================================
=======
--- src/webdocs/UserPreferences.jsp (revision 289)
+++ src/webdocs/UserPreferences.jsp (revision 365)
 -27,5
+27,4 
      // Extract the user profile and action attributes
      UserManager userMgr = wiki.getUserManager();
-    UserProfile profile = userMgr.parseProfile( wikiContext
);
      WikiSession wikiSession =
wikiContext.getWikiSession();

 -33,4
+32,5 
      if(
"saveProfile".equals(request.getParameter("
;action")) )
      {
+        UserProfile profile = userMgr.parseProfile(
wikiContext );
          // Validate the profile
          userMgr.validateProfile( wikiContext, profile );

_______________________________________________
Jspwiki-users mailing list
Jspwiki-usersecyrd.com
http://ecyrd.com/cgi-bin/mailman/listinfo/jspwiki-users

> See below for a quick fix that prevents overwriting the
current  
> user's mail address (profile.mail) when viewing (not
POSTing)  
> UserPreferences.jsp. This is needed for the LDAP auth
plugin as it  
> uses only one profile object per user which gets
overwritten all  
> the time otherwise.
>
> This applies to 2.4.13 but probably the issue remains
with current  
> CVS, too.

Yup, you're right. But it won't be in the next CVS 

Thanks!

/Janne
_______________________________________________
Jspwiki-users mailing list
Jspwiki-usersecyrd.com
http://ecyrd.com/cgi-bin/mailman/listinfo/jspwiki-users