typo in kipi_plugin_metaedit.po

Hi,

i just found

%1 (%2/%3) - Edit EXIF Metadata%4


I believe that there ha to a space between Metadata and %4

Oliver
_______________________________________________
Kde-imaging mailing list
Kde-imagingkde.org
htt
ps://mail.kde.org/mailman/listinfo/kde-imaging

Same for

%1 (%2/%3) - Edit IPTC Metadata%4

Oliver

Oliver Dörr wrote:
> Hi,
>
> i just found
>
> %1 (%2/%3) - Edit EXIF Metadata%4
>
>
> I believe that there ha to a space between Metadata and
%4
>
> Oliver
> _______________________________________________
> Kde-imaging mailing list
> Kde-imagingkde.org
> htt
ps://mail.kde.org/mailman/listinfo/kde-imaging
>
>   
_______________________________________________
Kde-imaging mailing list
Kde-imagingkde.org
htt
ps://mail.kde.org/mailman/listinfo/kde-imaging

Hi Oliver,

In both case, no, because the code is :

    setCaption(i18n("%1 (%2/%3) - Edit IPTC
Metadata%4")
               .arg((*d->currItem).filename())
              
.arg(d->urls.findIndex(*(d->currItem))+1)
               .arg(d->urls.count())
               .arg(d->isReadOnly ? i18n(" - (read
only)") : QString::null));

...and the string %4 have a space included or is null. Same
for Exif stuff.

note: are you seen my recent post in my blog about Exiv2
i18n :

http://www.digikam
.org/?q=node/168

A good WE

gilles


Le vendredi 10 novembre 2006 23:28, Oliver Dörr a écrit :
> Same for
>
> %1 (%2/%3) - Edit IPTC Metadata%4
>
> Oliver
>
> Oliver Dörr wrote:
> > Hi,
> >
> > i just found
> >
> > %1 (%2/%3) - Edit EXIF Metadata%4
> >
> >
> > I believe that there ha to a space between
Metadata and %4
> >
> > Oliver
> > _______________________________________________
> > Kde-imaging mailing list
> > Kde-imagingkde.org
> > htt
ps://mail.kde.org/mailman/listinfo/kde-imaging
>
> _______________________________________________
> Kde-imaging mailing list
> Kde-imagingkde.org
> htt
ps://mail.kde.org/mailman/listinfo/kde-imaging
_______________________________________________
Kde-imaging mailing list
Kde-imagingkde.org
htt
ps://mail.kde.org/mailman/listinfo/kde-imaging

Hi Gilles,


> note: are you seen my recent post in my blog about
Exiv2 i18n :
>
> http://www.digikam
.org/?q=node/168
>   
To be honest i've missed your message. But just tell me
there to find 
the po-file and the process to check it in. I will translate
the german 
version 

Oliver
_______________________________________________
Kde-imaging mailing list
Kde-imagingkde.org
htt
ps://mail.kde.org/mailman/listinfo/kde-imaging

Op za 11 nov 2006 08:39 schreef u:
> Hi Oliver,
> 
> In both case, no, because the code is :
> 
>     setCaption(i18n("%1 (%2/%3) - Edit IPTC
Metadata%4")
>                .arg((*d->currItem).filename())
>               
.arg(d->urls.findIndex(*(d->currItem))+1)
>                .arg(d->urls.count())
>                .arg(d->isReadOnly ? i18n(" -
(read only)") : QString::null));
> 
> ...and the string %4 have a space included or is null.
Same for Exif stuff.

Hi Gilles,

Above call to i18n is not allowed. A translator only sees
"%1 (%2/%3) - Edit IPTC Metadata%4" which makes it
untranslatable, as they would not know where the
placeholders stand for. Next to that it is not advisable to
use a space at the beginning of a 18n, translators often
don't see that.

You can better use someting like this:

if (d->isReadOnly)
 setCaption(i18n("1 is the filename, 2 the current
number, 3 the total amount", 
                            "%1 (%2/%3) - Edit IPTC
Metadata - (read only)")
               .arg((*d->currItem).filename())
              
.arg(d->urls.findIndex(*(d->currItem))+1)
               .arg(d->urls.count()));
else
 setCaption(i18n("1 is the filename, 2 the current
number, 3 the total amount", 
                            "%1 (%2/%3) - Edit IPTC
Metadata")
               .arg((*d->currItem).filename())
              
.arg(d->urls.findIndex(*(d->currItem))+1)
               .arg(d->urls.count()));

It is longer, but at least clear for the translator.

Toma


_______________________________________________
Kde-imaging mailing list
Kde-imagingkde.org
htt
ps://mail.kde.org/mailman/listinfo/kde-imaging

Le Samedi 11 Novembre 2006 09:15, Oliver Dörr a écrit :
> Hi Gilles,
>
> > note: are you seen my recent post in my blog about
Exiv2 i18n :
> >
> > http://www.digikam
.org/?q=node/168
>
> To be honest i've missed your message. But just tell me
there to find
> the po-file and the process to check it in. I will
translate the german
> version 
>
> Oliver

The file is here :

http://dev.robotbattle
.com/~cvsuser/cgi-bin/ns_viewcvs.cgi/exiv2/branches/gettext/
po/de.po

It come from a svn development branch dedicaced to NLS named
"gettext".

Warning : 20% of Exiv2 source code is not yet i18n. It's
especially Nikon and 
Canon Makernote tags title and description. But these
missing strings will be 
redondant with the already i18n strings from others source
code parts. This 
is want mean than your future translations update will be
limited.

If you want to test your translations with digiKam, you need
to checkout all 
Exiv2 source code from this branch and compile/install it
instead the trunk 
svn branch. Try this command line to get it :

$ svn checkout
svn://dev.robotbattle.com/exiv2/branches/gettext .

Note than the 'gettext' branch will be merged into trunk
when all source code  
i18n will be done.

Gilles
_______________________________________________
Kde-imaging mailing list
Kde-imagingkde.org
htt
ps://mail.kde.org/mailman/listinfo/kde-imaging

Le Samedi 11 Novembre 2006 13:39, Tom Albers a écrit :
> Op za 11 nov 2006 08:39 schreef u:
> > Hi Oliver,
> >
> > In both case, no, because the code is :
> >
> >     setCaption(i18n("%1 (%2/%3) - Edit IPTC
Metadata%4")
> >                .arg((*d->currItem).filename())
> >               
.arg(d->urls.findIndex(*(d->currItem))+1)
> >                .arg(d->urls.count())
> >                .arg(d->isReadOnly ? i18n("
- (read only)") :
> > QString::null));
> >
> > ...and the string %4 have a space included or is
null. Same for Exif
> > stuff.
>
> Hi Gilles,
>
> Above call to i18n is not allowed. A translator only
sees "%1 (%2/%3) -
> Edit IPTC Metadata%4" which makes it
untranslatable, as they would not know
> where the placeholders stand for. Next to that it is
not advisable to use a
> space at the beginning of a 18n, translators often
don't see that.
>
> You can better use someting like this:
>
> if (d->isReadOnly)
>  setCaption(i18n("1 is the filename, 2 the current
number, 3 the total
> amount", "%1 (%2/%3) - Edit IPTC Metadata -
(read only)")
> .arg((*d->currItem).filename())
>               
.arg(d->urls.findIndex(*(d->currItem))+1)
>                .arg(d->urls.count()));
> else
>  setCaption(i18n("1 is the filename, 2 the current
number, 3 the total
> amount", "%1 (%2/%3) - Edit IPTC
Metadata")
>                .arg((*d->currItem).filename())
>               
.arg(d->urls.findIndex(*(d->currItem))+1)
>                .arg(d->urls.count()));
>
> It is longer, but at least clear for the translator.
>
> Toma

Hum, there is more simple :

    setCaption(QString("%1 (%2/%3) - %4")
               .arg((*d->currItem).filename())
              
.arg(d->urls.findIndex(*(d->currItem))+1)
               .arg(d->urls.count())
               .arg(i18n("Edit EXIF Metadata")) + 
               (d->isReadOnly ? QString(" - ")
+ i18n("(read only)") : 
QString::null));

Fixed in svn

Gilles
_______________________________________________
Kde-imaging mailing list
Kde-imagingkde.org
htt
ps://mail.kde.org/mailman/listinfo/kde-imaging

Op za 11 nov 2006 18:52 schreef u:
> Hum, there is more simple :
> 
>     setCaption(QString("%1 (%2/%3) - %4")
>                .arg((*d->currItem).filename())
>               
.arg(d->urls.findIndex(*(d->currItem))+1)
>                .arg(d->urls.count())
>                .arg(i18n("Edit EXIF
Metadata")) + 
>                (d->isReadOnly ? QString(" -
") + i18n("(read only)") : 
> QString::null));

No! right to left language will want to swap %2 and %3 (and
%4 and %1)

Toma


_______________________________________________
Kde-imaging mailing list
Kde-imagingkde.org
htt
ps://mail.kde.org/mailman/listinfo/kde-imaging