|
List Info
Thread: Re: extragear/libs
|
|
| Re: extragear/libs |
|
2007-01-26 11:20:05 |
|
Op vr 26 jan 2007 18:09 schreef u:
> On Friday, 26. January 2007 15:06, Angelo Naselli wrote:
> > Alle 13:55, venerdì 26 gennaio 2007, Gilles Caulier ha scritto:
> > > SVN commit 627390 by cgilles:
> > >
> > > New common library witch will be used by digiKam and kipi-plugins to handle
> Pictures metadata (Exif/Iptc).
> > >
> > > This shared library is a wrapper around Exiv2 library. It give a Qt like
> interface to control
> > > Exiv2 actions on pictures. Using this library will remove all duplicate
> code on kipi-plugins::exiv2iface and
> > > digikam::dmetadata.
> > >
> > > The current implementation is the same than kipi-plugins/exiv2iface. This
> library is not yet used in digiKam/kipi-plugins.
> > > We will added a new depency to this library in kipi-plugins in first and
> later to digiKam.
> > >
> > > CCMAIL: digikam-devel kde.org, kde-imagingkde.org, marcel.wiesweggmx.de
> > >
> > >
> > >
> > > A libkexiv2 (directory)
> > > A libkexiv2/AUTHORS
> > > A libkexiv2/COPYING
> > > A libkexiv2/ChangeLog
> > > A libkexiv2/INSTALL
> > > A libkexiv2/Makefile.am
> > > A libkexiv2/NEWS
> > > A libkexiv2/README
> > > A libkexiv2/configure.in.in
> > > A libkexiv2/exiv2iface.cpp
> kipi-plugins/common/exiv2iface/exiv2iface.cpp#627389
> > > A libkexiv2/exiv2iface.h
> kipi-plugins/common/exiv2iface/exiv2iface.h#627389
> > > A libkexiv2/libkexiv2.lsm
> > > A libkexiv2/libkexiv2.pc.in
> > > A libkexiv2/libkexiv2_export.h [License: LGPL (v2+) (wrong
> address)]
> > Are you sure that is the right way to? In such a way we removed libkexif to
> have libkexiv.
> > That means another package to maintain and another dependency. I'd expexted
> > an internal kipi-plugins lib instead...
> > Just a thought of course.
>
> As digikam and kipi-plugins will use it (and maybe later other kipi apps
> or other image apps) it makes sense to do as standalone deb, like
> libkipi is not in kipi-plugins.
>
> In general IMHO we need more libs than more apps 
What i find weird in the sources is this comment:
---------------
* NOTE: This class is a simplified version of Digikam: Metadata
* class from digiKam core. Please contact digiKam team
* before to change/fix/improve this implementation.
---------------
Sounds like we are duplicating code and making it a maintainance nightmare.
Nobody is waiting to maintain this package, so my question is simple: who is going to generate packages for this library??
Toma
|
| Re: extragear/libs |
|
2007-01-26 11:29:13 |
|
| LE VENDREDI 26 JANVIER 2007 18:20, TOM ALBERS A éCRIT :
> OP VR 26 JAN 2007 18:09 SCHREEF U:
> > ON FRIDAY, 26. JANUARY 2007 15:06, ANGELO NASELLI WROTE:
> > > ALLE 13:55, VENERD?26 GENNAIO 2007, GILLES CAULIER HA SCRITTO:
> > > > SVN COMMIT 627390 BY CGILLES:
> > > >
> > > > NEW COMMON LIBRARY WITCH WILL BE USED BY DIGIKAM AND KIPI-PLUGINS TO
> > > > HANDLE
> >
> > PICTURES METADATA (EXIF/IPTC).
> >
> > > > THIS SHARED LIBRARY IS A WRAPPER AROUND EXIV2 LIBRARY. IT GIVE A QT
> > > > LIKE
> >
> > INTERFACE TO CONTROL
> >
> > > > EXIV2 ACTIONS ON PICTURES. USING THIS LIBRARY WILL REMOVE ALL
> > > > DUPLICATE
> >
> > CODE ON KIPI-PLUGINS::EXIV2IFACE AND
> >
> > > > DIGIKAM:METADATA.
> > > >
> > > > THE CURRENT IMPLEMENTATION IS THE SAME THAN KIPI-PLUGINS/EXIV2IFACE.
> > > > THIS
> >
> > LIBRARY IS NOT YET USED IN DIGIKAM/KIPI-PLUGINS.
> >
> > > > WE WILL ADDED A NEW DEPENCY TO THIS LIBRARY IN KIPI-PLUGINS IN FIRST
> > > > AND
> >
> > LATER TO DIGIKAM.
> >
> > > > CCMAIL: DIGIKAM-DEVELKDE.ORG, KDE-IMAGINGKDE.ORG,
> > > > MARCEL.WIESWEGGMX.DE
> > > >
> > > >
> > > >
> > > > A LIBKEXIV2 (DIRECTORY)
> > > > A LIBKEXIV2/AUTHORS
> > > > A LIBKEXIV2/COPYING
> > > > A LIBKEXIV2/CHANGELOG
> > > > A LIBKEXIV2/INSTALL
> > > > A LIBKEXIV2/MAKEFILE.AM
> > > > A LIBKEXIV2/NEWS
> > > > A LIBKEXIV2/README
> > > > A LIBKEXIV2/CONFIGURE.IN.IN
> > > > A LIBKEXIV2/EXIV2IFACE.CPP
> >
> > KIPI-PLUGINS/COMMON/EXIV2IFACE/EXIV2IFACE.CPP#627389
> >
> > > > A LIBKEXIV2/EXIV2IFACE.H
> >
> > KIPI-PLUGINS/COMMON/EXIV2IFACE/EXIV2IFACE.H#627389
> >
> > > > A LIBKEXIV2/LIBKEXIV2.LSM
> > > > A LIBKEXIV2/LIBKEXIV2.PC.IN
> > > > A LIBKEXIV2/LIBKEXIV2_EXPORT.H [LICENSE: LGPL (V2+)
> > > > (WRONG
> >
> > ADDRESS)]
> >
> > > ARE YOU SURE THAT IS THE RIGHT WAY TO? IN SUCH A WAY WE REMOVED
> > > LIBKEXIF TO
> >
> > HAVE LIBKEXIV.
> >
> > > THAT MEANS ANOTHER PACKAGE TO MAINTAIN AND ANOTHER DEPENDENCY. I'D
> > > EXPEXTED AN INTERNAL KIPI-PLUGINS LIB INSTEAD...
> > > JUST A THOUGHT OF COURSE.
> >
> > AS DIGIKAM AND KIPI-PLUGINS WILL USE IT (AND MAYBE LATER OTHER KIPI APPS
> > OR OTHER IMAGE APPS) IT MAKES SENSE TO DO AS STANDALONE DEB, LIKE
> > LIBKIPI IS NOT IN KIPI-PLUGINS.
> >
> > IN GENERAL IMHO WE NEED MORE LIBS THAN MORE APPS
>
> WHAT I FIND WEIRD IN THE SOURCES IS THIS COMMENT:
> ---------------
> * NOTE: THIS CLASS IS A SIMPLIFIED VERSION OF DIGIKAM:METADATA
> * CLASS FROM DIGIKAM CORE. PLEASE CONTACT DIGIKAM TEAM
> * BEFORE TO CHANGE/FIX/IMPROVE THIS IMPLEMENTATION.
> ---------------
>
> SOUNDS LIKE WE ARE DUPLICATING CODE AND MAKING IT A MAINTAINANCE NIGHTMARE.
NO... LOOK MY COMMIT COMMENTS BEFORE. THE COMMON SOURCE CODE IN KIPI-PLUGINS
AND DIGIKAM WILL BE REMOVED...
ALSO THE COMMENTS LIBKEXIV2 HEADER IS OBSOLETE. IT COMME FROM
KIPI-PLUGINS::EXIV2IFACE CLASS ! THIS IS THE REASON THE DO A SHARED LIB. IT'S
A NIGHTMARE TO MAINTAIN KIPI-PLUGINS::EXIV2IFACE AND DIGIKAM:METADATA
CLASS...
I WILL PERSONALLY FIX KIPI-PLUGINS AND DIGIKAM IN THIS WAY.
GILLES
|
| Re: extragear/libs |
|
2007-01-26 12:14:04 |
|
| LE VENDREDI 26 JANVIER 2007 18:20, TOM ALBERS A éCRIT :
> OP VR 26 JAN 2007 18:09 SCHREEF U:
> > ON FRIDAY, 26. JANUARY 2007 15:06, ANGELO NASELLI WROTE:
> > > ALLE 13:55, VENERD?26 GENNAIO 2007, GILLES CAULIER HA SCRITTO:
> > > > SVN COMMIT 627390 BY CGILLES:
> > > >
> > > > NEW COMMON LIBRARY WITCH WILL BE USED BY DIGIKAM AND KIPI-PLUGINS TO
> > > > HANDLE
> >
> > PICTURES METADATA (EXIF/IPTC).
> >
> > > > THIS SHARED LIBRARY IS A WRAPPER AROUND EXIV2 LIBRARY. IT GIVE A QT
> > > > LIKE
> >
> > INTERFACE TO CONTROL
> >
> > > > EXIV2 ACTIONS ON PICTURES. USING THIS LIBRARY WILL REMOVE ALL
> > > > DUPLICATE
> >
> > CODE ON KIPI-PLUGINS::EXIV2IFACE AND
> >
> > > > DIGIKAM:METADATA.
> > > >
> > > > THE CURRENT IMPLEMENTATION IS THE SAME THAN KIPI-PLUGINS/EXIV2IFACE.
> > > > THIS
> >
> > LIBRARY IS NOT YET USED IN DIGIKAM/KIPI-PLUGINS.
> >
> > > > WE WILL ADDED A NEW DEPENCY TO THIS LIBRARY IN KIPI-PLUGINS IN FIRST
> > > > AND
> >
> > LATER TO DIGIKAM.
> >
> > > > CCMAIL: DIGIKAM-DEVELKDE.ORG, KDE-IMAGINGKDE.ORG,
> > > > MARCEL.WIESWEGGMX.DE
> > > >
> > > >
> > > >
> > > > A LIBKEXIV2 (DIRECTORY)
> > > > A LIBKEXIV2/AUTHORS
> > > > A LIBKEXIV2/COPYING
> > > > A LIBKEXIV2/CHANGELOG
> > > > A LIBKEXIV2/INSTALL
> > > > A LIBKEXIV2/MAKEFILE.AM
> > > > A LIBKEXIV2/NEWS
> > > > A LIBKEXIV2/README
> > > > A LIBKEXIV2/CONFIGURE.IN.IN
> > > > A LIBKEXIV2/EXIV2IFACE.CPP
> >
> > KIPI-PLUGINS/COMMON/EXIV2IFACE/EXIV2IFACE.CPP#627389
> >
> > > > A LIBKEXIV2/EXIV2IFACE.H
> >
> > KIPI-PLUGINS/COMMON/EXIV2IFACE/EXIV2IFACE.H#627389
> >
> > > > A LIBKEXIV2/LIBKEXIV2.LSM
> > > > A LIBKEXIV2/LIBKEXIV2.PC.IN
> > > > A LIBKEXIV2/LIBKEXIV2_EXPORT.H [LICENSE: LGPL (V2+)
> > > > (WRONG
> >
> > ADDRESS)]
> >
> > > ARE YOU SURE THAT IS THE RIGHT WAY TO? IN SUCH A WAY WE REMOVED
> > > LIBKEXIF TO
> >
> > HAVE LIBKEXIV.
> >
> > > THAT MEANS ANOTHER PACKAGE TO MAINTAIN AND ANOTHER DEPENDENCY. I'D
> > > EXPEXTED AN INTERNAL KIPI-PLUGINS LIB INSTEAD...
> > > JUST A THOUGHT OF COURSE.
> >
> > AS DIGIKAM AND KIPI-PLUGINS WILL USE IT (AND MAYBE LATER OTHER KIPI APPS
> > OR OTHER IMAGE APPS) IT MAKES SENSE TO DO AS STANDALONE DEB, LIKE
> > LIBKIPI IS NOT IN KIPI-PLUGINS.
> >
> > IN GENERAL IMHO WE NEED MORE LIBS THAN MORE APPS
>
> WHAT I FIND WEIRD IN THE SOURCES IS THIS COMMENT:
> ---------------
> * NOTE: THIS CLASS IS A SIMPLIFIED VERSION OF DIGIKAM:METADATA
> * CLASS FROM DIGIKAM CORE. PLEASE CONTACT DIGIKAM TEAM
> * BEFORE TO CHANGE/FIX/IMPROVE THIS IMPLEMENTATION.
> ---------------
>
> SOUNDS LIKE WE ARE DUPLICATING CODE AND MAKING IT A MAINTAINANCE NIGHTMARE.
>
> NOBODY IS WAITING TO MAINTAIN THIS PACKAGE, SO MY QUESTION IS SIMPLE: WHO
> IS GOING TO GENERATE PACKAGES FOR THIS LIBRARY??
>
> TOMA
AND LOOK LIKE SHOWIMG USE A COPY OF THE DIGIKAM CORE EXIV2 INTERFACE
(DMETADATA CLASS) :
HTTP://WEBSVN.KDE.ORG/TRUNK/EXTRAGEAR/GRAPHICS/SHOWIMG/SHOWIMG/METADATA/DMETADATA.CPP?REV=595799&VIEW=AUTO
WITCH IS THE SAME THAN :
HTTP://WEBSVN.KDE.ORG/TRUNK/EXTRAGEAR/GRAPHICS/DIGIKAM/LIBS/DMETADATA/DMETADATA.CPP?REV=627043&VIEW=AUTO
AND WHERE THE KIPI-PLUGINS EXIV2IFACE CLASS IS A SIMPLIFIED ONE :
HTTP://WEBSVN.KDE.ORG/TRUNK/EXTRAGEAR/LIBS/KIPI-PLUGINS/COMMON/EXIV2IFACE/EXIV2IFACE.CPP?REV=627061&VIEW=AUTO
...IT TIME TO _UNIFIED_ ALL THIS WORLD WITH A SHARED LIBRARY...
GILLES
|
| Re: extragear/libs |
|
2007-01-27 05:01:21 |
Le Vendredi 26 Janvier 2007 19:14, Caulier Gilles(UNTRUSTED,
sender is
<kde-imaging-bounces-+caulier.gilles=kdemail.netkde.org>) a écrit :
> And look like ShowImg use a copy of the digiKam core
Exiv2 interface
> (DMetadata class) :
>
> http://websvn.kde.org/trunk/extragear
/graphics/showimg/showimg/metadata/dme
>tadata.cpp?rev=595799&view=auto
Richard Groult, the ShowImg author, have reported to me than
i will use this
library for the next Showimg version instead the duplicate
DMetadata class
copied in core...
Gilles
_______________________________________________
Kde-imaging mailing list
Kde-imagingkde.org
htt
ps://mail.kde.org/mailman/listinfo/kde-imaging
|
|
| Re: extragear/libs |
|
2007-01-27 05:33:21 |
Alle 12:01, sabato 27 gennaio 2007, Caulier Gilles ha
scritto:
> Le Vendredi 26 Janvier 2007 19:14, Caulier
Gilles(UNTRUSTED, sender is
> <kde-imaging-bounces-+caulier.gilles=kdemail.netkde.org>) a écrit :
> > And look like ShowImg use a copy of the digiKam
core Exiv2 interface
> > (DMetadata class) :
> >
> > http://websvn.kde.org/trunk/extragear
/graphics/showimg/showimg/metadata/dme
> >tadata.cpp?rev=595799&view=auto
>
> Richard Groult, the ShowImg author, have reported to me
than i will use this
> library for the next Showimg version instead the
duplicate DMetadata class
> copied in core...
>
> Gilles
Ok in the next few days I will provide prepare/release
scripts for it.
Angelo
_______________________________________________
Kde-imaging mailing list
Kde-imagingkde.org
htt
ps://mail.kde.org/mailman/listinfo/kde-imaging
|
|
[1-5]
|
|
|
about | contact Other archives ( Real Estate discussion Medical topics )
|