List Info

Thread: my first patch! (kdelibs)




my first patch! (kdelibs)
user name
2006-04-25 11:11:59
On Tuesday 25 April 2006 13:08, Frans Englich wrote:
> On Monday 24 April 2006 22:48, Will Entriken wrote:
> > Here's another go at it. With more content.
>
> Ok, more comments:

Frans is right in his comments, though usually patches
don't get this level of 
scrutiny.

> * The "\ref" in dictionary() isn't
needed, actually. Doxygen automatically
> does the linking for you. (Also, I would have used
\command or command
> throughout, in order to be consistent).

Use command in preference over \command unless the file
is already 
consistently all \command-form. Never* use ref, nor
#foo. 

* Unless you have a mainpage with a section and want to refer
to the section. 
I can count the instances of that in KDE SVN on two hands,
which justifies 
"never".

-- 
Adriaan de Groot
  KDE Quality Team
 
>> Visit 
http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
unsubscribe <<
[1]

about | contact  Other archives ( Real Estate discussion Medical topics )