Configuration options for QMake project

Hi,

before making to many changes on my own, I'd like to know
about a couple
of things:

1. The current configuration dialog supports the setting of
"console"
for the CONFIG variable, however this has only an effect on
win32 so I
think this should be removed

2. The "Build as DLL" and the
"Shared" option are duplicates, i.e. If
choosing "shared library" this adds the
"dll" keyword to CONFIG, and
"Build as DLL" does the same, so I think the
"Build as DLL" option
should be removed.

3. I'd like to make "plugin" a checkbox option,
which is only available
when "shared library" is activated. 

4. There are obviously many indentation styles used in the
projectconfigurationdlg.cpp file and with your permission
I'd like to
change that to 1 style (especially since some if's are not
indented at
all, which makes the code really hard to read).

Andreas

-- 
You will be misunderstood by everyone.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/
kdevelop-devel

On Friday 28 July 2006 18:39, Andreas Pakulat wrote:
> Hi,
>
> before making to many changes on my own, I'd like to
know about a couple
> of things:
>
> 1. The current configuration dialog supports the
setting of "console"
> for the CONFIG variable, however this has only an
effect on win32 so I
> think this should be removed
>

Remember that Qt is cross platform. You can develop on Linux
for windows. 
We'll need to keep this option IMHO.

> 2. The "Build as DLL" and the
"Shared" option are duplicates, i.e. If
> choosing "shared library" this adds the
"dll" keyword to CONFIG, and
> "Build as DLL" does the same, so I think
the "Build as DLL" option
> should be removed.
>

I think it should be renamed to 'Build as Shared Library'.

> 3. I'd like to make "plugin" a checkbox
option, which is only available
> when "shared library" is activated.
>

Agreed

> 4. There are obviously many indentation styles used in
the
> projectconfigurationdlg.cpp file and with your
permission I'd like to
> change that to 1 style (especially since some if's are
not indented at
> all, which makes the code really hard to read).
>

I don't oppose reindentation, but I would prefer if you did
as you go rather 
than a mass reindent of the code. We'll be more likely to
not lose annotate 
functionality then
--
Matt


_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/
kdevelop-devel

On 29.07.06 08:14:55, Matt Rogers wrote:
> On Friday 28 July 2006 18:39, Andreas Pakulat wrote:
> > Hi,
> >
> > before making to many changes on my own, I'd like
to know about a couple
> > of things:
> >
> > 1. The current configuration dialog supports the
setting of "console"
> > for the CONFIG variable, however this has only an
effect on win32 so I
> > think this should be removed
> >
> 
> Remember that Qt is cross platform. You can develop on
Linux for windows. 
> We'll need to keep this option IMHO.

Ok, that does make sense. What about the windows option?
Should I add
it?

> > 2. The "Build as DLL" and the
"Shared" option are duplicates, i.e. If
> > choosing "shared library" this adds
the "dll" keyword to CONFIG, and
> > "Build as DLL" does the same, so I
think the "Build as DLL" option
> > should be removed.
> >
> 
> I think it should be renamed to 'Build as Shared
Library'.

Huh? Why do you want to keep the duplicate option? As I
said, they both
activate the same option for the CONFIG variable, so I
don't really see
a reason for keeping both.

Andreas

-- 
Your business will assume vast proportions.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/
kdevelop-devel

On Saturday 29 July 2006 08:46, Andreas Pakulat wrote:
> On 29.07.06 08:14:55, Matt Rogers wrote:
> > On Friday 28 July 2006 18:39, Andreas Pakulat
wrote:
> > > Hi,
> > >
> > > before making to many changes on my own, I'd
like to know about a
> > > couple of things:
> > >
> > > 1. The current configuration dialog supports
the setting of "console"
> > > for the CONFIG variable, however this has
only an effect on win32 so I
> > > think this should be removed
> >
> > Remember that Qt is cross platform. You can
develop on Linux for windows.
> > We'll need to keep this option IMHO.
>
> Ok, that does make sense. What about the windows
option? Should I add
> it?
>
> > > 2. The "Build as DLL" and the
"Shared" option are duplicates, i.e. If
> > > choosing "shared library" this
adds the "dll" keyword to CONFIG, and
> > > "Build as DLL" does the same, so
I think the "Build as DLL" option
> > > should be removed.
> >
> > I think it should be renamed to 'Build as Shared
Library'.
>
> Huh? Why do you want to keep the duplicate option? As I
said, they both
> activate the same option for the CONFIG variable, so I
don't really see
> a reason for keeping both.
>

Sorry, that was unclear. Remove one, and rename the other
one to 'Build as 
Shared Library' or something similar.
--
Matt

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/
kdevelop-devel

On Saturday 29 July 2006 09:46, Andreas Pakulat wrote:
> On 29.07.06 08:14:55, Matt Rogers wrote:
> > On Friday 28 July 2006 18:39, Andreas Pakulat
wrote:
> > > Hi,
> > >
> > > before making to many changes on my own, I'd
like to know about a
> > > couple of things:
> > >
> > > 1. The current configuration dialog supports
the setting of "console"
> > > for the CONFIG variable, however this has
only an effect on win32 so I
> > > think this should be removed
> >
> > Remember that Qt is cross platform. You can
develop on Linux for windows.
> > We'll need to keep this option IMHO.
>
> Ok, that does make sense. What about the windows
option? Should I add
> it?
>
> > > 2. The "Build as DLL" and the
"Shared" option are duplicates, i.e. If
> > > choosing "shared library" this
adds the "dll" keyword to CONFIG, and
> > > "Build as DLL" does the same, so
I think the "Build as DLL" option
> > > should be removed.
> >
> > I think it should be renamed to 'Build as Shared
Library'.
>
> Huh? Why do you want to keep the duplicate option? As I
said, they both
> activate the same option for the CONFIG variable, so I
don't really see
> a reason for keeping both.
Remember that you can use mingw32 to build Windows
applications from KDevelop.  
Even then at least at my company we do our development on
Linux and 
Integration on OSX, Win32. 

Cheers
	-ian reinhart geiser

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/
kdevelop-devel

On 30.07.06 10:19:39, Ian Reinhart Geiser wrote:
> On Saturday 29 July 2006 09:46, Andreas Pakulat wrote:
> > On 29.07.06 08:14:55, Matt Rogers wrote:
> > > On Friday 28 July 2006 18:39, Andreas Pakulat
wrote:
> > > > Hi,
> > > >
> > > > before making to many changes on my own,
I'd like to know about a
> > > > couple of things:
> > > >
> > > > 1. The current configuration dialog
supports the setting of "console"
> > > > for the CONFIG variable, however this
has only an effect on win32 so I
> > > > think this should be removed
> > >
> > > Remember that Qt is cross platform. You can
develop on Linux for windows.
> > > We'll need to keep this option IMHO.
> >
> > Ok, that does make sense. What about the windows
option? Should I add
> > it?
> >
> > > > 2. The "Build as DLL" and
the "Shared" option are duplicates, i.e. If
> > > > choosing "shared library"
this adds the "dll" keyword to CONFIG, and
> > > > "Build as DLL" does the
same, so I think the "Build as DLL" option
> > > > should be removed.
> > >
> > > I think it should be renamed to 'Build as
Shared Library'.
> >
> > Huh? Why do you want to keep the duplicate option?
As I said, they both
> > activate the same option for the CONFIG variable,
so I don't really see
> > a reason for keeping both.
> Remember that you can use mingw32 to build Windows
applications from KDevelop.  
> Even then at least at my company we do our development
on Linux and 
> Integration on OSX, Win32. 

Do you reference the console-Option or the
build-as-shared/dll Option?
For the first one: I added console again.

For the second one: As I already tried to explain, both
ui-options are
"translated" to the same CONFIG variable and
thus they are duplicates of
each other. That's why I removed one.

Andreas

-- 
You will feel hungry again in another hour.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/
kdevelop-devel

On Sunday 30 July 2006 14:12, Andreas Pakulat wrote:
> On 30.07.06 10:19:39, Ian Reinhart Geiser wrote:
> > On Saturday 29 July 2006 09:46, Andreas Pakulat
wrote:
> > > On 29.07.06 08:14:55, Matt Rogers wrote:
> > > > On Friday 28 July 2006 18:39, Andreas
Pakulat wrote:
> > > > > Hi,
> > > > >
> > > > > before making to many changes on my
own, I'd like to know about a
> > > > > couple of things:
> > > > >
> > > > > 1. The current configuration dialog
supports the setting of
> > > > > "console" for the
CONFIG variable, however this has only an effect
> > > > > on win32 so I think this should be
removed
> > > >
> > > > Remember that Qt is cross platform. You
can develop on Linux for
> > > > windows. We'll need to keep this option
IMHO.
> > >
> > > Ok, that does make sense. What about the
windows option? Should I add
> > > it?
> > >
> > > > > 2. The "Build as DLL"
and the "Shared" option are duplicates, i.e.
> > > > > If choosing "shared
library" this adds the "dll" keyword to
CONFIG,
> > > > > and "Build as DLL" does
the same, so I think the "Build as DLL"
> > > > > option should be removed.
> > > >
> > > > I think it should be renamed to 'Build
as Shared Library'.
> > >
> > > Huh? Why do you want to keep the duplicate
option? As I said, they both
> > > activate the same option for the CONFIG
variable, so I don't really see
> > > a reason for keeping both.
> >
> > Remember that you can use mingw32 to build Windows
applications from
> > KDevelop. Even then at least at my company we do
our development on Linux
> > and Integration on OSX, Win32.
>
> Do you reference the console-Option or the
build-as-shared/dll Option?
> For the first one: I added console again.
Yes I use the console. Thanks /me grumbles about unittest
console output on 
win32....
> For the second one: As I already tried to explain, both
ui-options are
> "translated" to the same CONFIG variable
and thus they are duplicates of
> each other. That's why I removed one.
Yeah that one doesn't make sense so it can go.  

I just wanted to pipe in my 2c here, because I use KDevelop
for Qt3 win32 
development still.  I'm hopeful for Qt4, but I have not
gotten the configure 
script for mingw32 ported over yet.

Cheers
	-ian reinhart geiser

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/
kdevelop-devel