branches/kdevelop/3.4/src

SVN commit 581925 by amantia:

Fix the famous XIM crash when during loading of a project
the user switches to another application (the backtrace with
the KateViewInternal::updateMicroFocusHint). 

CCMAIL: kdevelop-develkdevelop.org

 M  +4 -2      editorproxy.cpp  


--- branches/kdevelop/3.4/src/editorproxy.cpp #581924:581925
 -72,10
+72,12 
     return;
 
   KURL url = dynamic_cast<KParts::ReadOnlyPart*>(
part )->url();
-
   ViewCursorInterface *iface =
dynamic_cast<ViewCursorInterface*>(part->widget());
   if (iface)
-    iface->setCursorPositionReal(lineNum, col == -1 ? 0
: col);
+  {
+    if (part->widget()->hasFocus())
+        iface->setCursorPositionReal(lineNum, col == -1
? 0 : col);
+  }
   else {
     // Save the position for a rainy day (or when the view
gets activated and wants its position)
     for (QValueList<MultiBuffer*>::ConstIterator it =
m_editorParts.begin(); it != m_editorParts.end(); ++it)

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

Am Freitag, 8. September 2006 00:45 schrieb Andras Mantia:
> SVN commit 581925 by amantia:
>
> Fix the famous XIM crash when during loading of a
project the user switches
> to another application (the backtrace with the
> KateViewInternal::updateMicroFocusHint).
>
> CCMAIL: kdevelop-develkdevelop.org
>
>  M  +4 -2      editorproxy.cpp
>

Hi! Thanks for fixing this annoying crash, but theres a
problem with the 
patch. It makes all the quickopen-menus not work(they only
open the file, but 
because the focus is not set to the editor, the line is not
changed.).

Has anyone an Idea how to fix this? I've already fiddled
around with closing 
the quickopen-windows earlier and using setFocus() on the
editor, but that 
didn't help.

greetings, David

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Thursday 14 September 2006 03:47, David Nolden wrote:
> Am Freitag, 8. September 2006 00:45 schrieb Andras
Mantia:
> > SVN commit 581925 by amantia:
> >
> > Fix the famous XIM crash when during loading of a
project the user
> > switches to another application (the backtrace
with the
> > KateViewInternal::updateMicroFocusHint).
> >
> > CCMAIL: kdevelop-develkdevelop.org
> >
> >  M  +4 -2      editorproxy.cpp
>
> Hi! Thanks for fixing this annoying crash, but theres a
problem with
> the patch. It makes all the quickopen-menus not
work(they only open
> the file, but because the focus is not set to the
editor, the line is
> not changed.).
>
> Has anyone an Idea how to fix this? I've already
fiddled around with
> closing the quickopen-windows earlier and using
setFocus() on the
> editor, but that didn't help.

You might remove the check here as I committed the
workaround to the 
katepart itself. 
Of course it will mean that the crash will happen with KDe
<= 3.5.4!

Andras

-- 
Quanta Plus developer - http://quanta.kdewebdev.o
rg
K Desktop Environment - http://www.kde.org
_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Thursday 14 September 2006 01:03, Andras Mantia wrote:
> On Thursday 14 September 2006 03:47, David Nolden
wrote:
> > Am Freitag, 8. September 2006 00:45 schrieb Andras
Mantia:
> > > SVN commit 581925 by amantia:
> > >
> > > Fix the famous XIM crash when during loading
of a project the user
> > > switches to another application (the
backtrace with the
> > > KateViewInternal::updateMicroFocusHint).
> > >
> > > CCMAIL: kdevelop-develkdevelop.org
> > >
> > >  M  +4 -2      editorproxy.cpp
> >
> > Hi! Thanks for fixing this annoying crash, but
theres a problem with
> > the patch. It makes all the quickopen-menus not
work(they only open
> > the file, but because the focus is not set to the
editor, the line is
> > not changed.).
> >
> > Has anyone an Idea how to fix this? I've already
fiddled around with
> > closing the quickopen-windows earlier and using
setFocus() on the
> > editor, but that didn't help.
>
> You might remove the check here as I committed the
workaround to the
> katepart itself.
> Of course it will mean that the crash will happen with
KDe <= 3.5.4!
>
> Andras

And since we support more than that, we still need the
check. 

-- 
Matt

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

Am Donnerstag, 14. September 2006 14:25 schrieben Sie:
> On Thursday 14 September 2006 01:03, Andras Mantia
wrote:
> > On Thursday 14 September 2006 03:47, David Nolden
wrote:
> > > Am Freitag, 8. September 2006 00:45 schrieb
Andras Mantia:
> > > > SVN commit 581925 by amantia:
> > > >
> > > > Fix the famous XIM crash when during
loading of a project the user
> > > > switches to another application (the
backtrace with the
> > > > KateViewInternal::updateMicroFocusHint).
> > > >
> > > > CCMAIL: kdevelop-develkdevelop.org
> > > >
> > > >  M  +4 -2      editorproxy.cpp
> > >
> > > Hi! Thanks for fixing this annoying crash,
but theres a problem with
> > > the patch. It makes all the quickopen-menus
not work(they only open
> > > the file, but because the focus is not set to
the editor, the line is
> > > not changed.).
> > >
> > > Has anyone an Idea how to fix this? I've
already fiddled around with
> > > closing the quickopen-windows earlier and
using setFocus() on the
> > > editor, but that didn't help.
> >
> > You might remove the check here as I committed the
workaround to the
> > katepart itself.
> > Of course it will mean that the crash will happen
with KDe <= 3.5.4!
> >
> > Andras
>
> And since we support more than that, we still need the
check. 

Then we need a workaround, or at least the check should be
only done for KDE 
<= 3.5.4. After all the patch significantly affects
usability for people who 
often use quickopen(like for example me, and I'm sure I'm
not the only 
one  )

greetings, David


_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 9/14/06, Matt Rogers <mattrkde.org> wrote:
> On Thursday 14 September 2006 01:03, Andras Mantia
wrote:
> > On Thursday 14 September 2006 03:47, David Nolden
wrote:
> > > Am Freitag, 8. September 2006 00:45 schrieb
Andras Mantia:
> > > > SVN commit 581925 by amantia:
> > > >
> > > > Fix the famous XIM crash when during
loading of a project the user
> > > > switches to another application (the
backtrace with the
> > > > KateViewInternal::updateMicroFocusHint).
> > > >
> > > > CCMAIL: kdevelop-develkdevelop.org
> > > >
> > > >  M  +4 -2      editorproxy.cpp
> > >
> > > Hi! Thanks for fixing this annoying crash,
but theres a problem with
> > > the patch. It makes all the quickopen-menus
not work(they only open
> > > the file, but because the focus is not set to
the editor, the line is
> > > not changed.).
> > >
> > > Has anyone an Idea how to fix this? I've
already fiddled around with
> > > closing the quickopen-windows earlier and
using setFocus() on the
> > > editor, but that didn't help.
> >
> > You might remove the check here as I committed the
workaround to the
> > katepart itself.
> > Of course it will mean that the crash will happen
with KDe <= 3.5.4!
> >
> > Andras
>
> And since we support more than that, we still need the
check. 
>

Hang on.. If the editor is not in focus, we do not set the
line number !?
I haven't tested it yet and I might be reading it wrong,
but won't
this break pretty much all navigation?

Including:
Quick Open (as David noticed)
Grep
Bookmarks
Replace
ClassView
Make output
Breakpoints
...

It doesn't look like a very nice solution, does it? In
fact, it seems
pretty close to making KDevelop useless...

// jens

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Thursday 14 September 2006 01:03, Andras Mantia wrote:
> On Thursday 14 September 2006 03:47, David Nolden
wrote:
> > Am Freitag, 8. September 2006 00:45 schrieb Andras
Mantia:
> > > SVN commit 581925 by amantia:
> > >
> > > Fix the famous XIM crash when during loading
of a project the user
> > > switches to another application (the
backtrace with the
> > > KateViewInternal::updateMicroFocusHint).
> > >
> > > CCMAIL: kdevelop-develkdevelop.org
> > >
> > >  M  +4 -2      editorproxy.cpp
> >
> > Hi! Thanks for fixing this annoying crash, but
theres a problem with
> > the patch. It makes all the quickopen-menus not
work(they only open
> > the file, but because the focus is not set to the
editor, the line is
> > not changed.).
> >
> > Has anyone an Idea how to fix this? I've already
fiddled around with
> > closing the quickopen-windows earlier and using
setFocus() on the
> > editor, but that didn't help.
>
> You might remove the check here as I committed the
workaround to the
> katepart itself.
> Of course it will mean that the crash will happen with
KDe <= 3.5.4!
>
> Andras

And since we support more than that, we still need the
check. 

-- 
Matt

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

Am Donnerstag, 14. September 2006 14:25 schrieben Sie:
> On Thursday 14 September 2006 01:03, Andras Mantia
wrote:
> > On Thursday 14 September 2006 03:47, David Nolden
wrote:
> > > Am Freitag, 8. September 2006 00:45 schrieb
Andras Mantia:
> > > > SVN commit 581925 by amantia:
> > > >
> > > > Fix the famous XIM crash when during
loading of a project the user
> > > > switches to another application (the
backtrace with the
> > > > KateViewInternal::updateMicroFocusHint).
> > > >
> > > > CCMAIL: kdevelop-develkdevelop.org
> > > >
> > > >  M  +4 -2      editorproxy.cpp
> > >
> > > Hi! Thanks for fixing this annoying crash,
but theres a problem with
> > > the patch. It makes all the quickopen-menus
not work(they only open
> > > the file, but because the focus is not set to
the editor, the line is
> > > not changed.).
> > >
> > > Has anyone an Idea how to fix this? I've
already fiddled around with
> > > closing the quickopen-windows earlier and
using setFocus() on the
> > > editor, but that didn't help.
> >
> > You might remove the check here as I committed the
workaround to the
> > katepart itself.
> > Of course it will mean that the crash will happen
with KDe <= 3.5.4!
> >
> > Andras
>
> And since we support more than that, we still need the
check. 

Then we need a workaround, or at least the check should be
only done for KDE 
<= 3.5.4. After all the patch significantly affects
usability for people who 
often use quickopen(like for example me, and I'm sure I'm
not the only 
one  )

greetings, David


_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 9/14/06, Matt Rogers <mattrkde.org> wrote:
> On Thursday 14 September 2006 01:03, Andras Mantia
wrote:
> > On Thursday 14 September 2006 03:47, David Nolden
wrote:
> > > Am Freitag, 8. September 2006 00:45 schrieb
Andras Mantia:
> > > > SVN commit 581925 by amantia:
> > > >
> > > > Fix the famous XIM crash when during
loading of a project the user
> > > > switches to another application (the
backtrace with the
> > > > KateViewInternal::updateMicroFocusHint).
> > > >
> > > > CCMAIL: kdevelop-develkdevelop.org
> > > >
> > > >  M  +4 -2      editorproxy.cpp
> > >
> > > Hi! Thanks for fixing this annoying crash,
but theres a problem with
> > > the patch. It makes all the quickopen-menus
not work(they only open
> > > the file, but because the focus is not set to
the editor, the line is
> > > not changed.).
> > >
> > > Has anyone an Idea how to fix this? I've
already fiddled around with
> > > closing the quickopen-windows earlier and
using setFocus() on the
> > > editor, but that didn't help.
> >
> > You might remove the check here as I committed the
workaround to the
> > katepart itself.
> > Of course it will mean that the crash will happen
with KDe <= 3.5.4!
> >
> > Andras
>
> And since we support more than that, we still need the
check. 
>

Hang on.. If the editor is not in focus, we do not set the
line number !?
I haven't tested it yet and I might be reading it wrong,
but won't
this break pretty much all navigation?

Including:
Quick Open (as David noticed)
Grep
Bookmarks
Replace
ClassView
Make output
Breakpoints
...

It doesn't look like a very nice solution, does it? In
fact, it seems
pretty close to making KDevelop useless...

// jens

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Thursday 14 September 2006 15:25, Matt Rogers wrote:
> On Thursday 14 September 2006 01:03, Andras Mantia
wrote:
> > On Thursday 14 September 2006 03:47, David Nolden
wrote:
> > > Am Freitag, 8. September 2006 00:45 schrieb
Andras Mantia:
> > > > SVN commit 581925 by amantia:
> > > >
> > > > Fix the famous XIM crash when during
loading of a project the
> > > > user switches to another application
(the backtrace with the
> > > > KateViewInternal::updateMicroFocusHint).
> > > >
> > > > CCMAIL: kdevelop-develkdevelop.org
> > > >
> > > >  M  +4 -2      editorproxy.cpp
> > >
> > > Hi! Thanks for fixing this annoying crash,
but theres a problem
> > > with the patch. It makes all the
quickopen-menus not work(they
> > > only open the file, but because the focus is
not set to the
> > > editor, the line is not changed.).
> > >
> > > Has anyone an Idea how to fix this? I've
already fiddled around
> > > with closing the quickopen-windows earlier
and using setFocus()
> > > on the editor, but that didn't help.
> >
> > You might remove the check here as I committed the
workaround to
> > the katepart itself.
> > Of course it will mean that the crash will happen
with KDe <=
> > 3.5.4!
> >
> > Andras
>
> And since we support more than that, we still need the
check. 

This is why I just added a comment and not removed after the
katepart 
fix was committed. 

Andras

-- 
Quanta Plus developer - http://quanta.kdewebdev.o
rg
K Desktop Environment - http://www.kde.org
_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel