List Info

Thread: uninitialized pointer in QMake::AssignmentAST




uninitialized pointer in QMake::AssignmentAST
user name
2006-10-31 00:54:33
On Monday 30 October 2006 12:25, Stephan Diederich wrote:
> Hi,
>
> patch below solves (at least for me) a bug with
qmake-manager.
> Changing something on a qmake-project file crashed
kdevelop and left
> an empty .pro-file.
> Initializing the QMake::AST* commentnode pointer to
zero solved that.
>
> apaku: Maybe delete it in the destructor...?
>
> HTH,
> Stephan
>
> Index: buildtools/lib/parsers/qmake/qmakeast.h
>
============================================================
=======
> --- buildtools/lib/parsers/qmake/qmakeast.h    
(Revision 600437)
> +++ buildtools/lib/parsers/qmake/qmakeast.h    
(Arbeitskopie)
>  -163,7 +163,7 
>  */
>  class AssignmentAST: public AST {
>  public:
> -    AssignmentAST(): AST(AST::AssignmentAST) {}
> +    AssignmentAST(): AST(AST::AssignmentAST),
commentnode(0){}
>
>      virtual void writeBack(QString &buffer);

Patch committed. Thanks!

Andreas: Perhaps this isn't totally correct. Your review
when you have time 
would be appreciated. 

Thanks
-- 
Matt

_______________________________________________
KDevelop-devel mailing list
KDevelop-develbarney.cs.uni-potsdam.de
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel
[1]

about | contact  Other archives ( Real Estate discussion Medical topics )