kdevelop subversion part patch

Hi KDevelop folks,

I fixed the subversion-commit bug, and added new commit
dialog box.
Also, I added subversion-log feature, which was not
implemented before.

I do not have a SVN account. So it would be nice if
somebody with KDE SVN account reviews and commits this one.
Any questions and feedbacks are welcome. I am willing to
receive these
feedback and improve the quality of my work.

ScreenShots:
http://adjj.ca
fe24.com/kdev-svn-ci.png
http://adjj.c
afe24.com/kdev-svn-log.png

These patches are against KDE-3.5 and KDevelop-3.4
branches.
Although KDE/KDevelop is moving to 4.0, our users will use
only
3.X  stable branches  for a considerable period. (at least
october 07)

So, HOW TO APPLY THESE PATCHES?

0. Checkout kdesdk-3.5 module. We need only
kdesdk-3.5/kioslave subdirectory.

1. There are two files in tar.gz file.
kdev-svn.patch       will go to KDevelop-3.4 branch and
ioslave-svn.patch   will go to kdesdk-3.5 branch.

2. Install libsvn-devel packages. Name may vary for each
linux distribution.

3. After building kdevelop & kdesdk-3.5/kioslave,
install it into KDEDIR

4. Issue any shell and invoke 'kdeinit'. At the SAME shell
you invoked kdeinit,
run kdevelop. If you use different shell or you run kdevelop
using
other methods (ex, menu), kdevelop cannot detect newly
installed kioslave.


Thanks for reading this long mail. I want someone to commit
this patch.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 25.02.07 11:07:12, dukju ahn wrote:
> These patches are against KDE-3.5 and KDevelop-3.4
branches.
> Although KDE/KDevelop is moving to 4.0, our users will
use only
> 3.X  stable branches  for a considerable period. (at
least october 07)
> 
> So, HOW TO APPLY THESE PATCHES?
> 
> 0. Checkout kdesdk-3.5 module. We need only
kdesdk-3.5/kioslave subdirectory.
> 
> 1. There are two files in tar.gz file.
> kdev-svn.patch       will go to KDevelop-3.4 branch
and
> ioslave-svn.patch   will go to kdesdk-3.5 branch.

Ok, I just looked through the ioslave patch quickly and I
don't think we
will get this one into kdesdk. Its too large and its not in
/trunk
already. Do you see a way of transferring some of that stuff
into
kdevelop? Eventually by extending the existing methods
instead of
writing new ones? 

Another problem is that the kdesdk-ioslave is not the
only ioslave for kde-svn support, there's another one which
currently
also works (and the Ui that delivers it is much more usable
than
konqueror+kdesdk-ioslave) - except for importing new
projects, for which
there's an upstream bugreport already. I suggest that if you
absolutely
need to change the ioslave-api talk to the author of kdesvn
and try to
convince him to change his ioslave too.

Also you messed up indentation in kdevelop and kdesdk patch,
that should
be fixed too. IIRC both use space-indentation, not tabs.

The logviewer is awesome.

Last but not least: It would be good if you could separate
at least the
bugfix out of the patch so we can apply it separately.
Getting the whole
patch into kdevelop might take some time and we should fix
the
multi-commit ASAP.

Despite all that: Thanks for your work on that.

Andreas

-- 
You are only young once, but you can stay immature
indefinitely.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Sunday 25 February 2007 22.32.08 Andreas Pakulat wrote:
> Also you messed up indentation in kdevelop and kdesdk
patch, that should
> be fixed too. IIRC both use space-indentation, not
tabs.

Memory is often a poor substitute for actually looking.. ;) 
At least the 
KDevelop code uses tabs. 

About getting the code into kdesdk, I agree.. it seems
unlikely. But I guess 
it is up to the maintainer of that code to decide.


// jens



_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

2007/2/26, Andreas Pakulat <apakugmx.de>:
> On 25.02.07 11:07:12, dukju ahn wrote:
> > These patches are against KDE-3.5 and KDevelop-3.4
branches.
> > Although KDE/KDevelop is moving to 4.0, our users
will use only
> > 3.X  stable branches  for a considerable period.
(at least october 07)
> >
> > So, HOW TO APPLY THESE PATCHES?
> >
> > 0. Checkout kdesdk-3.5 module. We need only
kdesdk-3.5/kioslave subdirectory.
> >
> > 1. There are two files in tar.gz file.
> > kdev-svn.patch       will go to KDevelop-3.4
branch and
> > ioslave-svn.patch   will go to kdesdk-3.5 branch.
>
> Ok, I just looked through the ioslave patch quickly and
I don't think we
> will get this one into kdesdk. Its too large and its
not in /trunk
> already. Do you see a way of transferring some of that
stuff into
> kdevelop?

Yes, It is very easy to transfer some of ioslave's stuff
into kdevelop.
Actually, KDevelop needs 3 files -- just svn.cpp / svn.h and
svn.protocol files.
We don't need the whole kioslave-svn plugin.
If we choose this option, we can act independently from the
restriction of
other's old api. This is a big merit.

However, kioslave-svn plugin is directly linked to
subversion library. If
kdevelop contains these 3 files, then kdevelop will require
libsvn-devel packages
to be compiled.

> Another problem is that the kdesdk-ioslave is not the
> only ioslave for kde-svn support, there's another one
which currently
> also works (and the Ui that delivers it is much more
usable than
> konqueror+kdesdk-ioslave) - except for importing new
projects, for which
> there's an upstream bugreport already. I suggest that
if you absolutely
> need to change the ioslave-api talk to the author of
kdesvn and try to
> convince him to change his ioslave too.

Should the ioslave from kdesdk be compatible with ioslave
from kdesvn?
If so, It would be a big problem. If we stick to the old
api, I cannot add
many new features planned.

These APIs are based on the early version of subversion.
And they even do not support full API of such old version.
( such as setprop, getprop, listprop, ... )

> Also you messed up indentation in kdevelop and kdesdk
patch, that should
> be fixed too. IIRC both use space-indentation, not
tabs.

I see, I will fix it later.

> It would be good if you could separate at least the
> bugfix out of the patch so we can apply it separately.

Yes, I will send it by tomorrow.

Now, which action should I take now? Before the stable
release of KDE
or KDevelop are closed, I want to stabilize and add
subversion part
frequently.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

2007/2/26, Andreas Pakulat <apakugmx.de>:
> On 25.02.07 11:07:12, dukju ahn wrote:
> > These patches are against KDE-3.5 and KDevelop-3.4
branches.
> > Although KDE/KDevelop is moving to 4.0, our users
will use only
> > 3.X  stable branches  for a considerable period.
(at least october 07)
> >
> > So, HOW TO APPLY THESE PATCHES?
> >
> > 0. Checkout kdesdk-3.5 module. We need only
kdesdk-3.5/kioslave subdirectory.
> >
> > 1. There are two files in tar.gz file.
> > kdev-svn.patch       will go to KDevelop-3.4
branch and
> > ioslave-svn.patch   will go to kdesdk-3.5 branch.
>
> Ok, I just looked through the ioslave patch quickly and
I don't think we
> will get this one into kdesdk. Its too large and its
not in /trunk
> already. Do you see a way of transferring some of that
stuff into
> kdevelop?

Yes, It is very easy to transfer some of ioslave's stuff
into kdevelop.
Actually, KDevelop needs 3 files -- just svn.cpp / svn.h and
svn.protocol files.
We don't need the whole kioslave-svn plugin.
If we choose this option, we can act independently from the
restriction of
other's old api. This is a big merit.

However, kioslave-svn plugin is directly linked to
subversion library. If
kdevelop contains these 3 files, then kdevelop will require
libsvn-devel packages
to be compiled.

> Another problem is that the kdesdk-ioslave is not the
> only ioslave for kde-svn support, there's another one
which currently
> also works (and the Ui that delivers it is much more
usable than
> konqueror+kdesdk-ioslave) - except for importing new
projects, for which
> there's an upstream bugreport already. I suggest that
if you absolutely
> need to change the ioslave-api talk to the author of
kdesvn and try to
> convince him to change his ioslave too.

Should the ioslave from kdesdk be compatible with ioslave
from kdesvn?
If so, It would be a big problem. If we stick to the old
api, I cannot add
many new features planned.

These APIs are based on the early version of subversion.
And they even do not support full API of such old version.
( such as setprop, getprop, listprop, ... )

> Also you messed up indentation in kdevelop and kdesdk
patch, that should
> be fixed too. IIRC both use space-indentation, not
tabs.

I see, I will fix it later.

> It would be good if you could separate at least the
> bugfix out of the patch so we can apply it separately.

Yes, I will send it by tomorrow.

Now, which action should I take now? Before the stable
release of KDE
or KDevelop are closed, I want to stabilize and add
subversion part
frequently.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

2007/2/26, Andreas Pakulat <apakugmx.de>:
> I suggest that if you absolutely
> need to change the ioslave-api talk to the author of
kdesvn and try to
> convince him to change his ioslave too.
>

I missed something. I did not changed the previous APIs.
To guarantee backward compatibility, I kept the old api
same.
I just ADDED new API over the existing one.
Although my patches are applied, applications using
previous
APIs will not be affected.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

2007/2/26, Andreas Pakulat <apakugmx.de>:
> I suggest that if you absolutely
> need to change the ioslave-api talk to the author of
kdesvn and try to
> convince him to change his ioslave too.
>

I missed something. I did not changed the previous APIs.
To guarantee backward compatibility, I kept the old api
same.
I just ADDED new API over the existing one.
Although my patches are applied, applications using
previous
APIs will not be affected.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 26.02.07 17:39:41, dukju ahn wrote:
> 2007/2/26, Andreas Pakulat <apakugmx.de>:
> > On 25.02.07 11:07:12, dukju ahn wrote:
> > > These patches are against KDE-3.5 and
KDevelop-3.4 branches.
> > > Although KDE/KDevelop is moving to 4.0, our
users will use only
> > > 3.X  stable branches  for a considerable
period. (at least october 07)
> > >
> > > So, HOW TO APPLY THESE PATCHES?
> > >
> > > 0. Checkout kdesdk-3.5 module. We need only
kdesdk-3.5/kioslave subdirectory.
> > >
> > > 1. There are two files in tar.gz file.
> > > kdev-svn.patch       will go to KDevelop-3.4
branch and
> > > ioslave-svn.patch   will go to kdesdk-3.5
branch.
> >
> > Ok, I just looked through the ioslave patch
quickly and I don't think we
> > will get this one into kdesdk. Its too large and
its not in /trunk
> > already. Do you see a way of transferring some of
that stuff into
> > kdevelop?
> 
> Yes, It is very easy to transfer some of ioslave's
stuff into kdevelop.
> Actually, KDevelop needs 3 files -- just svn.cpp /
svn.h and svn.protocol files.
> We don't need the whole kioslave-svn plugin.
> If we choose this option, we can act independently from
the restriction of
> other's old api. This is a big merit.
> 
> However, kioslave-svn plugin is directly linked to
subversion library. If
> kdevelop contains these 3 files, then kdevelop will
require
> libsvn-devel packages
> to be compiled.

Thats not what I meant in the first place. I mean to still
use kdesdk
ioslave without patching it, but haing the new features in
kdevelop.
Wether we should duplicate the kdesdk-ioslave code or not I
can't
decide, we should put that up in a separate thread when we
discover that
we can't modify the ioslave as much as we need...

> > Another problem is that the kdesdk-ioslave is not
the
> > only ioslave for kde-svn support, there's another
one which currently
> > also works (and the Ui that delivers it is much
more usable than
> > konqueror+kdesdk-ioslave) - except for importing
new projects, for which
> > there's an upstream bugreport already. I suggest
that if you absolutely
> > need to change the ioslave-api talk to the author
of kdesvn and try to
> > convince him to change his ioslave too.
> 
> Should the ioslave from kdesdk be compatible with
ioslave from kdesvn?

Its the other way around, the kdesvn-ioslave tries to be
compatible with
the on from kdesdk (although it already lacks
import-support)

> If so, It would be a big problem. If we stick to the
old api, I cannot add
> many new features planned.
> 
> These APIs are based on the early version of
subversion.
> And they even do not support full API of such old
version.
> ( such as setprop, getprop, listprop, ... )

Ok, then I suggest to talk to the maintainer of the kdesdk
ioslave
wether he agree's to add all these new API's.
 
> Now, which action should I take now? Before the stable
release of KDE
> or KDevelop are closed, I want to stabilize and add
subversion part
> frequently.

Don't worry, neither the KDevelop nor the KDE stable
branches will be
closed anytime soon (I was obviously wrong on that), so you
still have
plenty of time.

Andreas

-- 
There will be big changes for you but you will be happy.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

Please keep in mind that KDevelop 3.4.x should compile with
KDE 3.4.0 and 
KDESDK 3.4.0

-- 
Amilcar Lucas
Webmaster
The KDevelop project

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 26.02.07 13:33:59, Amilcar do Carmo Lucas wrote:
> Please keep in mind that KDevelop 3.4.x should compile
with KDE 3.4.0 and 
> KDESDK 3.4.0

ioslave's are not a compile-time dependecy, but a runtime
dependecy.
However the changes to kdesdk's ioslave will make some
actions of the
KDevelop svn support unusable with older kdesdk versions.

So maybe the code-duplication is something to consider
anyway...

Andreas

-- 
You are scrupulously honest, frank, and straightforward. 
Therefore you
have few friends.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel