Re: REMINDER: Final review of VCS interfaces

On Fri, 01 Jun 2007 14:11:11 Matthew Woehlke wrote:
> Robert Gruber wrote:
> > Index: interfaces/vcshelpers.h
> >
============================================================
=======
> > --- interfaces/vcshelpers.h	(Revision 670496)
> > +++ interfaces/vcshelpers.h	(Arbeitskopie)
> >  -22,6 +22,9 
> >  #ifndef VCSHELPERS_H
> >  #define VCSHELPERS_H
> >  
> > +#include <QVariant>
> > +#include <KUrl>
> > +
> >  #include "vcsexport.h"
> 
> Hmm, non-self-contained header... we bad .


I've added some other missing things like namespaces and
interface declaration. See attached patch.
Any objections? Or can I commit...

Robert





-- 
Psssst! Schon vom neuen GMX MultiMessenger gehört?
Der kanns mit allen: http://www.gm
x.net/de/go/multimessenger

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Jun 4, 2007, at 1:26 PM, Robert Gruber wrote:

>
> On Fri, 01 Jun 2007 14:11:11 Matthew Woehlke wrote:
>> Robert Gruber wrote:
>>> Index: interfaces/vcshelpers.h
>>>
============================================================
=======
>>> --- interfaces/vcshelpers.h	(Revision 670496)
>>> +++ interfaces/vcshelpers.h	(Arbeitskopie)
>>>  -22,6 +22,9 
>>>  #ifndef VCSHELPERS_H
>>>  #define VCSHELPERS_H
>>>
>>> +#include <QVariant>
>>> +#include <KUrl>
>>> +
>>>  #include "vcsexport.h"
>>
>> Hmm, non-self-contained header... we bad .
>
>
> I've added some other missing things like namespaces
and interface  
> declaration. See attached patch.
> Any objections? Or can I commit...
>
> Robert

No objections. Please commit.

Matt



_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel