KDE/kdevelop/languages/cpp/expressionparser

SVN commit 677550 by apaku:

Make dashboard happy.

I think we should compile kdevelop and kdevplatform using
-pedantic (thats what
dashboard uses), just add -DCMAKE_CXX_FLAGS=-pedantic to the
cmake call.

David: I understand why you put a ; after macros, but
whats the purpose of ; after a namespace-closing-brace??

CCMAIL:kdevelop-develkdevelop.org


 M  +2 -2      overloadresolution.h  
 M  +1 -1      typeutils.cpp  


---
trunk/KDE/kdevelop/languages/cpp/expressionparser/overloadre
solution.h #677549:677550
 -26,7
+26,7 
 
 namespace KDevelop {
   class DUContext;
-};
+}
 
 namespace Cpp {
 using namespace KDevelop;
 -68,6
+68,6 
     ConversionRank m_worstConversionRank;
 };
 
-};
+}
 
 #endif
---
trunk/KDE/kdevelop/languages/cpp/expressionparser/typeutils.
cpp #677549:677550
 -186,4
+186,4 
       }
     }
   }
-};
+}

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Jun 19, 2007, at 6:06 AM, Andreas Pakulat wrote:

> SVN commit 677550 by apaku:
>
> Make dashboard happy.
>
> I think we should compile kdevelop and kdevplatform
using -pedantic  
> (thats what
> dashboard uses), just add -DCMAKE_CXX_FLAGS=-pedantic
to the cmake  
> call.
>
> David: I understand why you put a ; after macros, but
whats the  
> purpose of ; after a namespace-closing-brace??
>
> CCMAIL:kdevelop-develkdevelop.org
>

I think we should better learn C++ as that will tell us
where we can  
use semicolons and where we should avoid them. ;) But using
-pedantic  
doesn't hurt either. ;)
--
Matt



_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 19.06.07 19:56:33, Matt Rogers wrote:
> On Jun 19, 2007, at 6:06 AM, Andreas Pakulat wrote:
> > SVN commit 677550 by apaku:
> >
> > Make dashboard happy.
> >
> > I think we should compile kdevelop and
kdevplatform using -pedantic  
> > (thats what
> > dashboard uses), just add
-DCMAKE_CXX_FLAGS=-pedantic to the cmake  
> > call.
> >
> > David: I understand why you put a ; after macros, but
whats the  
> > purpose of ; after a namespace-closing-brace??
> >
> > CCMAIL:kdevelop-develkdevelop.org
> >
> 
> I think we should better learn C++ as that will tell us
where we can  
> use semicolons and where we should avoid them. ;) But
using -pedantic  
> doesn't hurt either. ;)
 
The thing is, dashboard is using -pedantic, so everytime we
check in
something that works without, but not with dashboard (like
extra ; after
a namespace or macro) we break the build on dashboard and
somebody has
to sit down, go to the source and fix it. IMHO its easier to
compile
with -pedantic and then change those things bevfore
comitting.

Andreas

-- 
Your reasoning is excellent -- it's only your basic
assumptions that are wrong.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Wednesday 20 June 2007 02:56:33 Matt Rogers wrote:
> I think we should better learn C++ as that will tell us
where we can
> use semicolons and where we should avoid them. ;) But
using -pedantic
> doesn't hurt either. ;)
> --
> Matt
>

Where does c++ tell me to avoid semicolons after
namespaces?

However I'll try to avoid breaking dashboard in the
future..

greetings, David


_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 20.06.07 13:50:36, David Nolden wrote:
> On Wednesday 20 June 2007 02:56:33 Matt Rogers wrote:
> > I think we should better learn C++ as that will
tell us where we can
> > use semicolons and where we should avoid them. ;)
But using -pedantic
> > doesn't hurt either. ;)
> > --
> > Matt
> >
> 
> Where does c++ tell me to avoid semicolons after
namespaces?

I don't know the c++ standard, but according to gcc's
manpage thats what
-pedantic activates. Strict checking according to the
standard. Where
c++ standard == c++98

Andreas

-- 
Don't go surfing in South Dakota for a while.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 20.06.07 14:18:56, Andreas Pakulat wrote:
> On 20.06.07 13:50:36, David Nolden wrote:
> > On Wednesday 20 June 2007 02:56:33 Matt Rogers
wrote:
> > > I think we should better learn C++ as that
will tell us where we can
> > > use semicolons and where we should avoid
them. ;) But using -pedantic
> > > doesn't hurt either. ;)
> > > --
> > > Matt
> > >
> > 
> > Where does c++ tell me to avoid semicolons after
namespaces?
> 
> I don't know the c++ standard, but according to gcc's
manpage thats what
> -pedantic activates. Strict checking according to the
standard. Where
> c++ standard == c++98

Well, I did check the standard quickly and in fact nowhere
does it have
an "empty statemtent", so I suspect ";"
is not allowed according to the
C++ standard. And of course the grammar for namespace
doesn't include a
; at the end ;)

Andreas

-- 
You will reach the highest possible point in your business
or profession.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Wednesday 20 June 2007, Andreas Pakulat wrote:
> Well, I did check the standard quickly and in fact
nowhere does it
> have an "empty statemtent", so I suspect
";" is not allowed according
> to the C++ standard. And of course the grammar for
namespace doesn't
> include a ; at the end ;)

BTW, it would be better if KDevelop 3.4 would show the
missing ";" in 
some cases as an error, as now I am tempted to put there
just to 
silence it.

-- 
Quanta Plus developer - http://quanta.kdewebdev.o
rg
K Desktop Environment - http://www.kde.org

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 20.06.07 17:10:58, Andras Mantia wrote:
> On Wednesday 20 June 2007, Andreas Pakulat wrote:
> > Well, I did check the standard quickly and in fact
nowhere does it
> > have an "empty statemtent", so I suspect
";" is not allowed according
> > to the C++ standard. And of course the grammar for
namespace doesn't
> > include a ; at the end ;)
> 
> BTW, it would be better if KDevelop 3.4 would show the
missing ";" in 
> some cases as an error, as now I am tempted to put
there just to 
> silence it.

IIRC the problem is with macro's that are not in the same
source only.
Add the macro definitions to Kdevelop Settings->C++
Parsing. That works
for me.

Andreas

-- 
You too can wear a nose mitten.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Jun 20, 2007, at 3:47 AM, Andreas Pakulat wrote:

> On 19.06.07 19:56:33, Matt Rogers wrote:
>> On Jun 19, 2007, at 6:06 AM, Andreas Pakulat
wrote:
>>> SVN commit 677550 by apaku:
>>>
>>> Make dashboard happy.
>>>
>>> I think we should compile kdevelop and
kdevplatform using -pedantic
>>> (thats what
>>> dashboard uses), just add
-DCMAKE_CXX_FLAGS=-pedantic to the cmake
>>> call.
>>>
>>> David: I understand why you put a ; after
macros, but whats the
>>> purpose of ; after a namespace-closing-brace??
>>>
>>> CCMAIL:kdevelop-develkdevelop.org
>>>
>>
>> I think we should better learn C++ as that will
tell us where we can
>> use semicolons and where we should avoid them. ;)
But using -pedantic
>> doesn't hurt either. ;)
>
> The thing is, dashboard is using -pedantic, so
everytime we check in
> something that works without, but not with dashboard
(like extra ;  
> after
> a namespace or macro) we break the build on dashboard
and somebody has
> to sit down, go to the source and fix it. IMHO its
easier to compile
> with -pedantic and then change those things bevfore
comitting.
>
> Andreas
>
> -- 

Even so, that's no substitute for correctly learning and
using C++.
--
Matt



_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Jun 20, 2007, at 6:50 AM, David Nolden wrote:

> On Wednesday 20 June 2007 02:56:33 Matt Rogers wrote:
>> I think we should better learn C++ as that will
tell us where we can
>> use semicolons and where we should avoid them. ;)
But using -pedantic
>> doesn't hurt either. ;)
>> --
>> Matt
>>
>
> Where does c++ tell me to avoid semicolons after
namespaces?
>
> However I'll try to avoid breaking dashboard in the
future..
>
> greetings, David

You never need semi-colons after the curly braces except for
the  
closing curly brace when defining a class. the newer gcc
versions  
(especially 4.2) are incredibly strict about this
--
Matt



_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel