KDevPlatform code review and documentation

Hi,

 at aKademy there was a decision to do a code review there
and document 
the interfaces. I see no commits realted to this issue, so I
am asking 
if this was really done there or should be done now/later?

Andras

-- 
Quanta Plus developer - http://quanta.kdewebdev.o
rg
K Desktop Environment - http://www.kde.org

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Friday 13 July 2007 10:34, Andras Mantia wrote:
> Hi,
>
>  at aKademy there was a decision to do a code review
there and document
> the interfaces. I see no commits realted to this issue,
so I am asking
> if this was really done there or should be done
now/later?
>
> Andras

It should be done as time and motivation permits.
-- 
Matt

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Friday 13 July 2007 21:58, Matt Rogers wrote:
> On Friday 13 July 2007 10:34, Andras Mantia wrote:
> > Hi,
> >
> >  at aKademy there was a decision to do a code
review there and document
> > the interfaces. I see no commits realted to this
issue, so I am asking
> > if this was really done there or should be done
now/later?
> >
> > Andras
>
> It should be done as time and motivation permits.

And to expand a bit (sorry, I'm quite tired):

We don't necessarily need to have an organized code review.
We can all review 
code as time and motivation permits. Smaller reviews
(perhaps a class or two, 
or a set of interrelated interfaces) are more preferred than
wide sweeping 
reviews.

Thanks 
-- 
Matt

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Saturday 14 July 2007, Matt Rogers wrote:
> We don't necessarily need to have an organized code
review. We can
> all review code as time and motivation permits. Smaller
reviews
> (perhaps a class or two, or a set of interrelated
interfaces) are
> more preferred than wide sweeping reviews.

Matt, the decision there was to do such a review during the
hacking 
session by all those present at aKademy. As I left earlier,
I couldn't 
attend this review and was asking if it was really done or
not.

Andras

-- 
Quanta Plus developer - http://quanta.kdewebdev.o
rg
K Desktop Environment - http://www.kde.org

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Saturday 14 July 2007 01:26, Andras Mantia wrote:
> On Saturday 14 July 2007, Matt Rogers wrote:
> > We don't necessarily need to have an organized
code review. We can
> > all review code as time and motivation permits.
Smaller reviews
> > (perhaps a class or two, or a set of interrelated
interfaces) are
> > more preferred than wide sweeping reviews.
>
> Matt, the decision there was to do such a review during
the hacking
> session by all those present at aKademy. As I left
earlier, I couldn't
> attend this review and was asking if it was really done
or not.
>
> Andras

Right, I understood that. Obviously it wasn't done or there
would have been 
commits related to it. 

But rather than wait around for somebody else to review and
document, I was 
trying to encourage everybody to take it upon themselves to
do it. We don't 
need to wait to have an organized review (although those are
quite nice). All 
of us are responsible for the quality of the code and
documentation after 
all. 
-- 
Matt

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

Hi Andras and List,

>  at aKademy there was a decision to do a code review
there and document
> the interfaces. I see no commits realted to this issue,
so I am asking
> if this was really done there or should be done
now/later?

yes in deed Alexander and I made this review and we found
quite some issues. 
Alexander made a list and had the plan to make the fixes. I
guess he just had 
not yet the time to do so.

Jens


_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 7/14/07, Jens Herden <jenskdewebdev.org> wrote:
> yes in deed Alexander and I made this review and we
found quite some issues.
> Alexander made a list and had the plan to make the
fixes. I guess he just had
> not yet the time to do so.

Yep, I've just arrived yesterday, so no fixes has been made
but the
list of issues is already in the wiki:
http://www.kdevelop.org/mediawiki/in
dex.php/Interfaces_Review_Results:_Part1
http://www.kdevelop.org/mediawiki/in
dex.php/Interfaces_Review_Results:_Part2

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

> -----Original Message-----
> From: kdevelop-devel-bouncesbarney.cs.uni-potsdam.de 
> [mailto:kdevelop-devel-bouncesbarney.cs.uni-potsdam.de]
On 
> Behalf Of Alexander Dymo
> Sent: Saturday, July 14, 2007 2:37 PM
> To: KDevelop Developer Mailinglist
> Subject: Re: KDevPlatform code review and
documentation
> 
> On 7/14/07, Jens Herden <jenskdewebdev.org> wrote:
> > yes in deed Alexander and I made this review and
we found 
> quite some issues.
> > Alexander made a list and had the plan to make the
fixes. I 
> guess he just had
> > not yet the time to do so.
> 
> Yep, I've just arrived yesterday, so no fixes has been
made but the
> list of issues is already in the wiki:
> http://www.kdevelop.org/mediawiki/index.php/Interf
aces_Review_
> Results:_Part1
> http://www.kdevelop.org/mediawiki/index.php/Interf
aces_Review_
> Results:_Part2
> 
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-develkdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel
> 

My last commit happened to address issues 18 & 20.

Kris Wong

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel