KDE/kdevelop/buildtools/builders/qmakebuilder

SVN commit 691596 by apaku:

Allow to easily retrieve the exact binary used in a project.
This will be used by the QMake Manager.

CC'ing kdevelop-devel to get some input on a question wrt.
to this change:
Would it be better to offer something like
QString queryQMake(const QString& var,
KDevelop::IProject*)
which would basically run qmake -query var and return the
result?

I need a way in the qmake manager to run qmake -query var
but am not 100%
sure which of the two API's is "better" and I'd
like to not hardcode the qmake group
config-key in two places..

CCMAIL:kdevelop-develkdevelop.org

 M  +1 -1      iqmakebuilder.h  
 M  +8 -0      qmakebuilder.cpp  
 M  +2 -0      qmakebuilder.h  


---
trunk/KDE/kdevelop/buildtools/builders/qmakebuilder/iqmakebu
ilder.h #691595:691596
 -32,7
+32,7 
 class IQMakeBuilder : public KDevelop::IProjectBuilder
 {
 public:
-
+    virtual QString qmakeBinary(  KDevelop::IProject*
project  ) = 0;
     virtual ~IQMakeBuilder() {}
 
 };
---
trunk/KDE/kdevelop/buildtools/builders/qmakebuilder/qmakebui
lder.cpp #691595:691596
 -195,6
+195,14 
         emit failed(m_items[id]);
 }
 
+QString QMakeBuilder::qmakeBinary( KDevelop::IProject*
project )
+{
+    KSharedConfig::Ptr cfg =
project->projectConfiguration();
+    KConfigGroup group(cfg.data(), "QMake
Builder");
+    KUrl v = group.readEntry("QMake Binary",
KUrl( "file:///usr/bin/qmake" ) );
+    return v.toLocalFile();
+}
+
 #include "qmakebuilder.moc"
 
 //kate: space-indent on; indent-width 4; replace-tabs on;
auto-insert-doxygen on; indent-mode cstyle;
---
trunk/KDE/kdevelop/buildtools/builders/qmakebuilder/qmakebui
lder.h #691595:691596
 -51,6
+51,8 
     virtual bool build(KDevelop::ProjectBaseItem *dom);
     virtual bool clean(KDevelop::ProjectBaseItem *dom);
 
+    QString qmakeBinary( KDevelop::IProject* project );
+
 Q_SIGNALS:
     void built(KDevelop::ProjectBaseItem*);
     void failed(KDevelop::ProjectBaseItem*);

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Jul 23, 2007, at 6:51 PM, Andreas Pakulat wrote:

> SVN commit 691596 by apaku:
>
> Allow to easily retrieve the exact binary used in a
project. This  
> will be used by the QMake Manager.
>
> CC'ing kdevelop-devel to get some input on a question
wrt. to this  
> change:
> Would it be better to offer something like
> QString queryQMake(const QString& var,
KDevelop::IProject*)
> which would basically run qmake -query var and return
the result?
>
> I need a way in the qmake manager to run qmake -query
var but am  
> not 100%
> sure which of the two API's is "better" and
I'd like to not  
> hardcode the qmake group
> config-key in two places..
>
> CCMAIL:kdevelop-develkdevelop.org

how often are you going to be doing this qmake querying do
you think?  
The queryQMake function sounds like a nice solution to me.
- --
Matt


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (Darwin)

iD8DBQFGqCIFA6Vv5rghv0cRAoeCAJ96+2ZcXKSkhjkXlg1NvM79ArFKvACf
VjI3
TSLvzQBWapXI1OuPiojMh4Y=
=bfda
-----END PGP SIGNATURE-----

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 25.07.07 23:24:37, Matt Rogers wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> 
> On Jul 23, 2007, at 6:51 PM, Andreas Pakulat wrote:
> 
> > SVN commit 691596 by apaku:
> >
> > Allow to easily retrieve the exact binary used in
a project. This  
> > will be used by the QMake Manager.
> >
> > CC'ing kdevelop-devel to get some input on a
question wrt. to this  
> > change:
> > Would it be better to offer something like
> > QString queryQMake(const QString& var,
KDevelop::IProject*)
> > which would basically run qmake -query var and
return the result?
> >
> > I need a way in the qmake manager to run qmake
-query var but am  
> > not 100%
> > sure which of the two API's is "better"
and I'd like to not  
> > hardcode the qmake group
> > config-key in two places..
> >
> > CCMAIL:kdevelop-develkdevelop.org
> 
> how often are you going to be doing this qmake querying
do you think?  

Once for each project upon opening and the eventually when
the user
changes the qmake binary setting. So its rather seldom.

> The queryQMake function sounds like a nice solution to
me.

So you think it makes more sense to have this function in
the
qmake-builder than in the qmake-manager? (Just in case I
wasn't clear:
The function exists anyway, I'm just not sure where to put
it).

Andreas

-- 
Living your life is a task so difficult, it has never been
attempted before.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

> > how often are you going to be doing this qmake
querying do 
> > you think?  
> 
> Once for each project upon opening and the eventually
when the user
> changes the qmake binary setting. So its rather
seldom.
> 
> > The queryQMake function sounds like a nice
solution to me.
> 
> So you think it makes more sense to have this function
in the
> qmake-builder than in the qmake-manager? (Just in case
I wasn't clear:
> The function exists anyway, I'm just not sure where to
put it).
> 

I am inclined to think we should keep any interfacing with
the qmake
binary itself in one layer (QmakeBuilder it seems).  Is
there any other
reason you would want to access the QMake binary itself from
the
QMakeManager?

Kris Wong

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 26.07.07 11:48:44, Matt Rogers wrote:
> On Jul 26, 2007, at 4:42 AM, Andreas Pakulat wrote:
> > On 25.07.07 23:24:37, Matt Rogers wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >>
> >> On Jul 23, 2007, at 6:51 PM, Andreas Pakulat
wrote:
> >>
> >>> SVN commit 691596 by apaku:
> >>>
> >>> Allow to easily retrieve the exact binary
used in a project. This
> >>> will be used by the QMake Manager.
> >>>
> >>> CC'ing kdevelop-devel to get some input on
a question wrt. to this
> >>> change:
> >>> Would it be better to offer something
like
> >>> QString queryQMake(const QString& var,
KDevelop::IProject*)
> >>> which would basically run qmake -query var
and return the result?
> >>>
> >>> I need a way in the qmake manager to run
qmake -query var but am
> >>> not 100%
> >>> sure which of the two API's is
"better" and I'd like to not
> >>> hardcode the qmake group
> >>> config-key in two places..
> >>>
> >>> CCMAIL:kdevelop-develkdevelop.org
> >>
> >> how often are you going to be doing this qmake
querying do you think?
> >
> > Once for each project upon opening and the
eventually when the user
> > changes the qmake binary setting. So its rather
seldom.
> >
> >> The queryQMake function sounds like a nice
solution to me.
> >
> > So you think it makes more sense to have this
function in the
> > qmake-builder than in the qmake-manager? (Just in
case I wasn't clear:
> > The function exists anyway, I'm just not sure
where to put it).
> 
> Why would you need it in the qmake builder? I would
think that you  
> would only need to query for things in the qmake
manager.

I don't, thats why I didn't put it there in the first place
and just
provided a small convenience method to fetch the qmake
binary (else I'd
have to hardcode the config-options in two places). But you
indicated
that a queryQMake function sounds better (or I misunderstood
you)...

Andreas

-- 
Give him an evasive answer.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel