Re: KDE/kdevplatform/plugins/subversion

On 28.07.07 18:30:14, Dukju Ahn wrote:
> ---
trunk/KDE/kdevplatform/plugins/subversion/svn_revision.h
#693699:693700
>  -24,6 +24,7 
>  #define SVN_REVERT   (KDevelop::VcsJob::Revert)
>  #define SVN_COPY     (KDevelop::VcsJob::Copy)
>  #define SVN_MOVE     (KDevelop::VcsJob::Move)
> +#define SVN_CAT      (KDevelop::VcsJob::Cat)

Whats this? Apart from the fact that you didn't commit the
change in
vcsjob and thus broke the build, why these defines? Whats
the use case
for that?

Andreas

-- 
There is a 20% chance of tomorrow.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

2007/7/28, Andreas Pakulat <apakugmx.de>:
> On 28.07.07 18:30:14, Dukju Ahn wrote:
> > ---
trunk/KDE/kdevplatform/plugins/subversion/svn_revision.h
#693699:693700
> >  -24,6 +24,7 
> >  #define SVN_REVERT   (KDevelop::VcsJob::Revert)
> >  #define SVN_COPY     (KDevelop::VcsJob::Copy)
> >  #define SVN_MOVE     (KDevelop::VcsJob::Move)
> > +#define SVN_CAT      (KDevelop::VcsJob::Cat)
>
> Whats this? Apart from the fact that you didn't commit
the change in
> vcsjob and thus broke the build, why these defines?
Whats the use case
> for that?

Because svn has its unique operations that are not counted
by our common interface. In most cases its ok but, think
about
"svn switch", "svn info". The VcsJob
will not define enums for
these operations, but subversion plugin still needs this.

So I had no choice but to define job types again.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel