Forcing execution of make in C locale

Hi,

please have a look at the attached patch. It should force
any make-based
build in KDevelop to use the C locale for printing make and
also gcc
messages. This is needed for the outputviews
"click" functionality to
work properly, i.e. clicking on errors to be taken to the
file and
similar things.

OTOH it also forces all users to always see the build output
in english,
and not being able to see it in another language (i.e. their
own).

Objections? Comments?

Andreas

-- 
Never reveal your best argument.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Thursday 17 January 2008 11:48:29 Andreas Pakulat wrote:
> OTOH it also forces all users to always see the build
output in english,
> and not being able to see it in another language (i.e.
their own).
>
> Objections? Comments?
Can it be made configurable ? Can you attach the patch ?


-- 
Amilcar Lucas
Webmaster
The KDevelop project

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 17.01.08 14:16:05, Amilcar do Carmo Lucas wrote:
> On Thursday 17 January 2008 11:48:29 Andreas Pakulat
wrote:
> > OTOH it also forces all users to always see the
build output in english,
> > and not being able to see it in another language
(i.e. their own).
> >
> > Objections? Comments?
> Can it be made configurable ?

I could, I wanted to avoid the extra coding, especially as
having
non-english output completely kills the usefulness of the
outputviews

> Can you attach the patch ?

Sure.

Andreas

-- 
Hope that the day after you die is a nice day.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Thursday 17 January 2008 14:51:06 Andreas Pakulat wrote:
> On 17.01.08 14:16:05, Amilcar do Carmo Lucas wrote:
> > On Thursday 17 January 2008 11:48:29 Andreas
Pakulat wrote:
> > > OTOH it also forces all users to always see
the build output in
> > > english, and not being able to see it in
another language (i.e. their
> > > own).
> > >
> > > Objections? Comments?
> >
> > Can it be made configurable ?
>
> I could, I wanted to avoid the extra coding, especially
as having
> non-english output completely kills the usefulness of
the outputviews
>
> > Can you attach the patch ?
>
> Sure.
>
> Andreas

I think I fixed the regular expressions for german some
time. So maybe it 
would need to check the language, and switch to english if
the language is 
unsupported. Unsupported means: Not english, not german.


greetings, David

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 17.01.08 15:23:27, David Nolden wrote:
> On Thursday 17 January 2008 14:51:06 Andreas Pakulat
wrote:
> > On 17.01.08 14:16:05, Amilcar do Carmo Lucas
wrote:
> > > On Thursday 17 January 2008 11:48:29 Andreas
Pakulat wrote:
> > > > OTOH it also forces all users to always
see the build output in
> > > > english, and not being able to see it in
another language (i.e. their
> > > > own).
> > > >
> > > > Objections? Comments?
> > >
> > > Can it be made configurable ?
> >
> > I could, I wanted to avoid the extra coding,
especially as having
> > non-english output completely kills the usefulness
of the outputviews
> >
> > > Can you attach the patch ?
> >
> > Sure.
> 
> I think I fixed the regular expressions for german some
time. So maybe it 
> would need to check the language, and switch to english
if the language is 
> unsupported. Unsupported means: Not english, not
german. 

IMHO there shouldn't be any support for non-english in the
regexes for
the following reasons:

- we have to do translation ourselves, make has gettext
support, but I'm
  not sure gettext supports to find the "original"
message from a
  translated one. And that still leaves out gcc-messages
- its slowing down the parsing, unless one has to
specifically activate
  the regexes for his language, which introduces quite some
code
- maintenance nightmare
- translations of error messages are itself often useless in
public
  forums unless you happen to have somebody speaking the
same language
  there

So to conclude: A simple switch to activate the
"forcing to english" and
thus disabling the jump-to-source is all thats needed.

Andreas

-- 
Expect a letter from a friend who will ask a favor of you.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Thursday 17 January 2008 15:37:41 Andreas Pakulat wrote:
> So to conclude: A simple switch to activate the
"forcing to english" and
> thus disabling the jump-to-source is all thats needed.
I vote in a radio button:
- force error build-system and compiler messages in English
- use local language settings and disable
"jump-to-source" functionality

This way is clear, if you select "I like
Portuguese" you also select "I do not 
want to jump to error messages"
 


-- 
Amilcar Lucas
Webmaster
The KDevelop project

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 1/17/08, Amilcar do Carmo Lucas <webmasterkdevelop.org> wrote:
> On Thursday 17 January 2008 15:37:41 Andreas Pakulat
wrote:
> > So to conclude: A simple switch to activate the
"forcing to english" and
> > thus disabling the jump-to-source is all thats
needed.
> I vote in a radio button:
> - force error build-system and compiler messages in
English
> - use local language settings and disable
"jump-to-source" functionality
>
> This way is clear, if you select "I like
Portuguese" you also select "I do not
> want to jump to error messages"
>  
>
I dunno how realistic it is, but one sci-fi solution could
be to use
Kross and let the build output parsers be implemented in a
more
suitable language than C++. This way it would be much easier
for
people to add support for their language/compiler/build
system.

I would be worried about performance though. And unwanted
complexity
and dependencies.

// jens

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 17.01.08 16:39:50, Jens Dagerbo wrote:
> On 1/17/08, Amilcar do Carmo Lucas <webmasterkdevelop.org> wrote:
> > On Thursday 17 January 2008 15:37:41 Andreas
Pakulat wrote:
> > > So to conclude: A simple switch to activate
the "forcing to english" and
> > > thus disabling the jump-to-source is all
thats needed.
> > I vote in a radio button:
> > - force error build-system and compiler messages
in English
> > - use local language settings and disable
"jump-to-source" functionality
> >
> > This way is clear, if you select "I like
Portuguese" you also select "I do not
> > want to jump to error messages"
> >  
> >
> I dunno how realistic it is, but one sci-fi solution
could be to use
> Kross and let the build output parsers be implemented
in a more
> suitable language than C++. This way it would be much
easier for
> people to add support for their language/compiler/build
system.

For KDevelop4 maybe. I was talking about 3.5 though 

Andreas

-- 
Your temporary financial embarrassment will be relieved in a
surprising manner.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Thursday 17 January 2008, Jens Dagerbo wrote:
> I would be worried about performance though. 

Me too, as the current C++ code isn't too fast either. I
admit partly 
it's the widget's fault, but after a long compilation try to
switch 
between full and short outputs several times and you'll see.


Andras
-- 
Quanta Plus developer - http://quanta.kdewebdev.o
rg
K Desktop Environment - http://www.kde.org

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 17.01.08 16:08:30, Amilcar do Carmo Lucas wrote:
> On Thursday 17 January 2008 15:37:41 Andreas Pakulat
wrote:
> > So to conclude: A simple switch to activate the
"forcing to english" and
> > thus disabling the jump-to-source is all thats
needed.
> I vote in a radio button:
> - force error build-system and compiler messages in
English
> - use local language settings and disable
"jump-to-source" functionality

Done, I just checked this in. The setting is among the other
global
settings for the make output widget in Configure KDevelop.
Works just
fine.

Andreas

-- 
Don't go surfing in South Dakota for a while.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel