List Info

Thread: Fix for mixups in stdout/stderr output




Fix for mixups in stdout/stderr output
user name
2008-02-07 05:14:01
Hi,

I'm posting this here because I'm not sure of all
consequences of
changing a public interface like kdevappfrontend. Do I need
to increase
the plugin version for this to work properly? (I've got no
problems
locally though without changing the version)

Another thing is the dcop interface, is it safe to change
it, or should
I just leave it as it is?

Oh, btw, the patch is needed to fix 152482 and because the
timers
introduced to fix it had severe problems (see 153642)

Andreas

PS: If anybody tries it: I'm aware of the bug in the
grepview, but I
wanted to get these questions answered asap - am working on
a fix for
that bug right now.

-- 
So you're back... about time...

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

  
RE: Fix for mixups in stdout/stderr output
user name
2008-02-07 07:19:32
> I'm posting this here because I'm not sure of all
consequences of
> changing a public interface like kdevappfrontend. Do I
need
> to increase
> the plugin version for this to work properly? (I've got
no problems
> locally though without changing the version)

Well, changing the interface from accepting a const
QString& to a const QCString& is not 100% BC.  Since
the classes are related, and offer some matching
constructors (including const char*), the change is
partially BC.

As for the policy on the plugin version, I would imagine any
non-BC changes in lib/interfaces would require an increase
in the plugin version, correct?

Kris Wong

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

Re: Fix for mixups in stdout/stderr output
user name
2008-02-07 08:31:09
On 07.02.08 08:19:32, Kris Wong wrote:
> > I'm posting this here because I'm not sure of all
consequences of
> > changing a public interface like kdevappfrontend.
Do I need
> > to increase
> > the plugin version for this to work properly?
(I've got no problems
> > locally though without changing the version)
> 
> Well, changing the interface from accepting a const
QString& to a const QCString& is not 100% BC.  Since
the classes are related, and offer some matching
constructors (including const char*), the change is
partially BC.
> 
> As for the policy on the plugin version, I would
imagine any non-BC changes in lib/interfaces would require
an increase in the plugin version, correct?

Updated patch attached, this also fixes the problem with
grepview. 

So the only question that remains is about the change of the
dcop
interface...

Andreas

-- 
Today is National Existential Ennui Awareness Day.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

Re: Fix for mixups in stdout/stderr output
user name
2008-02-07 09:03:14
On 07.02.08 15:31:09, Andreas Pakulat wrote:
> On 07.02.08 08:19:32, Kris Wong wrote:
> > > I'm posting this here because I'm not sure of
all consequences of
> > > changing a public interface like
kdevappfrontend. Do I need
> > > to increase
> > > the plugin version for this to work properly?
(I've got no problems
> > > locally though without changing the version)
> > 
> > Well, changing the interface from accepting a
const QString& to a const QCString& is not 100% BC. 
Since the classes are related, and offer some matching
constructors (including const char*), the change is
partially BC.
> > 
> > As for the policy on the plugin version, I would
imagine any non-BC changes in lib/interfaces would require
an increase in the plugin version, correct?
> 
> Updated patch attached, this also fixes the problem
with grepview. 

Bah, I can't wait to try out kmail after 3.5.9 was released,
that
reminder for missing attachements is really great.

Anyway, this time the patch is attached.

Andreas

-- 
Tonight you will pay the wages of sin; Don't forget to leave
a tip.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

  
[1-4]

about | contact  Other archives ( Real Estate discussion Medical topics )