Broken Code in KDevelop/C++

Hi,

languages/cpp/cppduchain/templateparameterdeclaration.cpp:21


uses a private header from the duchain. That is not
possible, the _p.h
header are only usable inside the duchain library.

Also they are now installed, which is complete and utter
nonsense, the
whole point of the private classes is to be able to break BC
on them, so
nothing outside the language library can use them. That
change needs to
be reverted.

Andreas

-- 
Someone is speaking well of you.

How unusual!

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On Tuesday 26 February 2008 20:23:42 Andreas Pakulat wrote:
> Hi,
>
>
languages/cpp/cppduchain/templateparameterdeclaration.cpp:21

>
> uses a private header from the duchain. That is not
possible, the _p.h
> header are only usable inside the duchain library.
>
> Also they are now installed, which is complete and
utter nonsense, the
> whole point of the private classes is to be able to
break BC on them, so
> nothing outside the language library can use them. That
change needs to
> be reverted.
>
> Andreas

Have you looked at the code? That shared d-pointer thing was
your own idea, 
and why should it stop at the border between kdevplatform
and kdevelop? Do we 
need binary comptability between different versions of
kdevplatform and 
kdevelop? No we don't.

I prefer having a kdevelop that does not eat my whole
gigabyte of memory just 
for the code model some time.

Of course you can revert that change, but it would clearly
be a step back to 
me.

Greetings, David

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 26.02.08 20:40:57, David Nolden wrote:
> On Tuesday 26 February 2008 20:23:42 Andreas Pakulat
wrote:
> > Hi,
> >
> >
languages/cpp/cppduchain/templateparameterdeclaration.cpp:21

> >
> > uses a private header from the duchain. That is
not possible, the _p.h
> > header are only usable inside the duchain
library.
> >
> > Also they are now installed, which is complete and
utter nonsense, the
> > whole point of the private classes is to be able
to break BC on them, so
> > nothing outside the language library can use them.
That change needs to
> > be reverted.
> >
> > Andreas
> 
> Have you looked at the code? That shared d-pointer
thing was your own idea, 

Yes, but not using it across module boundaries.

> and why should it stop at the border between
kdevplatform and kdevelop? Do we 
> need binary comptability between different versions of
kdevplatform and 
> kdevelop? No we don't.

Its not about that. Exporting the class and especially
installing its
header makes it part of the public API and thus subject to
all those BC
rules (including having a Private dptr). Thats not going to
work.

We're writing a BC-keeping library here, so we need our
Private classes
to stay private. The fact that it works between editor and
language lib
is simply due to both being in the same module and thus
being able to
directly use the _p.h header of the other lib.

> I prefer having a kdevelop that does not eat my whole
gigabyte of memory just 
> for the code model some time.

Then start working on putting some of that model into a
persistant
store. 

> Of course you can revert that change, but it would
clearly be a step back to 
> me.

Thats unfortunate, though there's another option (which I
already
mentioned in the other mail): Simply move that single class
that
actually used the private class into kdevplatform.

Andreas

-- 
Be cheerful while you are alive.
		-- Phathotep, 24th Century B.C.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

On 26.02.08 20:23:42, Andreas Pakulat wrote:
> Hi,
> 
>
languages/cpp/cppduchain/templateparameterdeclaration.cpp:21

> 
> uses a private header from the duchain. That is not
possible, the _p.h
> header are only usable inside the duchain library.
> 
> Also they are now installed, which is complete and
utter nonsense, the
> whole point of the private classes is to be able to
break BC on them, so
> nothing outside the language library can use them. That
change needs to
> be reverted.

Bah, should've checked how much code is involved first.
Wasn't much to
do, so I just comitted the change.

Andreas

PS: David if memory consumption goes through the roof due to
this you
need to move the template-stuff into kdevplatform.

-- 
Beauty and harmony are as necessary to you as the very
breath of life.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel