Re: Making FindBoost prefer Boost_ROOT

On 26.03.08 17:25:58, Matthew Woehlke wrote:
> Matthew Woehlke wrote:
>> In order to get my Boost_ROOT honored rather than
the system boost in  
>> /usr/include (which is too old), I had to make the
following changes to 
>> FindBoost.cmake (this is from kdevplatform, but
I've had to copy the  
>> module to pimlibs and now kdesdk also, due to the
module from cmake  
>> 2.4.6 being similarly inadequate). Should I commit
this?
>>
>> CC'ing also the cmake list, as I'm not sure what to
do about this as 
>> far as upstream; maybe someone will have comments.
>
> In addition, I'm used to environment variables being
all-caps. Is  
> FindBoost intentionally deviating here, or was this a
search-and-replace  
> oops? If not, how would people feel about applying
this?

Thats intentional as per the cmake module documentation.
That suggest to
use the same capitalization as for the part between
"Find" and ".cmake".

Andreas

-- 
Tomorrow, you can be anywhere.

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel

Andreas Pakulat wrote:
> On 26.03.08 17:25:58, Matthew Woehlke wrote:
>> In addition, I'm used to environment variables
being all-caps. Is  
>> FindBoost intentionally deviating here, or was this
a search-and-replace  
>> oops? If not, how would people feel about applying
this?
> 
> Thats intentional as per the cmake module
documentation. That suggest to
> use the same capitalization as for the part between
"Find" and ".cmake".

...for CMake variables, this is true, and I already knew
that. I'm not 
sure how much sense applying it to *environment* variables
makes, 
however, as I believe those are traditionally all-caps.

-- 
Matthew
I'm anti-ascii. Probably because I once worked with a guy
who sent EVERY 
BLOODY DESIGN SCHEMA as an ascii art thing. A year into that
job and I 
just about wanted to punch him in the head with an ascii
fist. He 
totally ruined ascii porn for me even. -- Aaron Seigo


_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel