Re: Making FindBoost prefer Boost_ROOT

On 27.03.08 18:01:47, Matthew Woehlke wrote:
> Andreas Pakulat wrote:
>> However, looking at the fact that cmake itself uses
all-upper-case for
>> variables that can be specified on the commandline
I'm going to  change
>> these 3 too (there's also _INCLUDEDIR and
_LIBRARYDIR)
>
> Ok, makes sense. Actually if they are inputs, uppercase
probably makes  
> sense. Same-as-the-module case should of course be used
for variables  
> that are meant for consumption by the CMakeLists.txt
that called  
> findpackage(Boost), but I think _ROOT and friends are
not in this 
> category?

Exactly, those are all inputs to find_package.

>>  Hope it
won't be too many. If you want to further push for having
>> FindBoost.cmake in kdelibs I'd really appreciate it
if that would be the
>> one from kdevplatform as AFAIK thats the only one
supporting searching
>> for various boost libraries which KDevplatform
needs to have.
>
> AFAIK the one in kdevplatform is the only one in KDE's
svn. I have  
> others (which I now made symlinks to the kdevplatform
one), because the  
> one with my cmake, which those modules apparently use,
is insufficient  
> for me.

I thought kdepimlibs have their own...

> If that won't be a maintenance issue for kdevelop, I'll
probably plan to  
> do it next week if no one has objected.

Not sure what you mean with that, moving this to kdelibs is
not a
problem for us.

Andreas

-- 
Are you ever going to do the dishes?  Or will you change
your major to biology?

_______________________________________________
KDevelop-devel mailing list
KDevelop-develkdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinf
o/kdevelop-devel