On Tuesday 23 May 2006 12:06, Jens Dagerbo wrote:
> > I don't know why slotGUICreated is so confusingly
named, but calling
> > configureKeyTips there does not seem right. Maybe,
it's better to call it
> > from PartController::slotPartAdded?
>
> Problem is that that doesn't work.
You mean, never called?
> Which is probably why Alex did it
> like this. The original actions are recreated
(presumably from the xml
> file) over and over, sometimes at unexpected moments.
(See this BR for
> a silly example: http://bug
s.kde.org/show_bug.cgi?id=127166) The only
> way I've found that actually works is to redo the
alteration over and
> over as well. Ugly as sin, but what else is there..?
We talked with Alex about this, and the simplest approach
would be to change
tooltips in projectCreated slot. Unfortunately, this won't
handle editor
actions, because I believe that editor KParts are created
lazily, or at least
after projectCreated slot is called. We probably do
something more clever,
like checkign, in slotGUICreated, if this is editor part,
and if we've
already processed that part.
After changing shortcuts via dialog, or after changing the
set of project
plugins, we'll work over all KParts.
> > Also, note that both slotGUICreated and
slotPartAdded have KPart*
> > parameter. It does not seem right to process *all*
KParts then. I'd
> > suggest this:
> >
> > - Create new configureKeyTips(KPart*) method, that
configures key tips
> > for for KPart only.
> > - Reimplement configureKeyTips() in terms for
configureKeyTips(KPart*)
> > - Call configureKeyTips() when shortcuts are
configured by the user.
> > - Call configureKeyTips(KPart*) from
slotPartAdded.
> >
> >
> > Anybody objects if I commit this patch, as soon as
above issues are
> > addressed?
>
> If you do this, it won't really be this patch anymore.
;) I do like
> the functionality, I think it should be implemented in
kdelibs instead
> of at application leve,
That's only for KDE4, and this will only happen if some
kdelibs maintainer
will like the idea...
> but if you find a sane way of doing it in
> KDevelop, I'm all for it.
Let's see if remembering KPart for which tooltips are
already adjusted, and
never processing one KPart twice, will work. Alex, what do
you think?
- Volodya
_______________________________________________
KDevelop-devel mailing list
KDevelop-devel barney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/
kdevelop-devel
|