Fixed crashing bug, final check before submit

Hi all,
   I fixed the crashing bug with the 32bit float. (it was
because there's no default profile for
32bit float)

Unfortunately, I encountered a worst bug. In
kis_paint_device.cc (line 720) , the id's of the
colorspaces are compared but the profiles are not. So I
changed the comparsion to compare the
pointers like its done in KisImage::convertTo and that
seemed to do the trick.

If noone objects, I'll submit it.

Cheers
Ben
_______________________________________________
kimageshop mailing list
kimageshopkde.org
http
s://mail.kde.org/mailman/listinfo/kimageshop

On Thursday 01 March 2007, Schleimer, Ben wrote:
> Hi all,
>    I fixed the crashing bug with the 32bit float. (it
was because there's
> no default profile for 32bit float)
>
> Unfortunately, I encountered a worst bug. In
kis_paint_device.cc (line 720)
> , the id's of the colorspaces are compared but the
profiles are not. So I
> changed the comparsion to compare the pointers like its
done in
> KisImage::convertTo and that seemed to do the trick.
>
> If noone objects, I'll submit it.

It sounds good; I haven't tried applying to 1.6 yet -- I'll
give it a try 
tonight.


-- 
Boudewijn Rempt 
http://www.va
ldyas.org/fading/index.cgi

_______________________________________________
kimageshop mailing list
kimageshopkde.org
http
s://mail.kde.org/mailman/listinfo/kimageshop

> It sounds good; I haven't tried applying to 1.6 yet --
I'll give it a try
> tonight.
I don't like the idea to give the ability to convert the
colorspace of a layer 
for two reasons:
1) that would give two ways of converting layers
2) we have two very similar dialog, image properties and
layer properties, 
and, one of them will convert colorspaces, while the other
one won't, I think 
it will be even more confusing for users.


-- 
Cyrille Berger
_______________________________________________
kimageshop mailing list
kimageshopkde.org
http
s://mail.kde.org/mailman/listinfo/kimageshop

On Friday 02 March 2007 16:07, Cyrille Berger wrote:
> > It sounds good; I haven't tried applying to 1.6
yet -- I'll give it a try
> > tonight.
>
> I don't like the idea to give the ability to convert
the colorspace of a
> layer for two reasons:
> 1) that would give two ways of converting layers
> 2) we have two very similar dialog, image properties
and layer properties,
> and, one of them will convert colorspaces, while the
other one won't, I
> think it will be even more confusing for users.
I agree. The two dialogs should behave the same
-- 
best regards / venlig hilsen
Casper Boemann
_______________________________________________
kimageshop mailing list
kimageshopkde.org
http
s://mail.kde.org/mailman/listinfo/kimageshop