Re: branches/work/kwin_composite

On Sunday 11 of February 2007, Philip Falkner wrote:
> On Sunday 11 February 2007 13:52, Lubos Lunak wrote:
> > Dne neděle 11 únor 2007 18:41 Philip Edward John
Falkner napsal(a):
> > > SVN commit 632583 by pfalkner:
> > >
> > > Fade effect.  Unified version of FadeIn and
FadeOut; also fades on
> > > window opacity changes.
> >
> >  Does it obsolete the two old ones (i.e. shouldn't
they be removed)?
>
> Yes it does, but I didn't want to remove the old ones
without someone else
> having agreed the new one was ok.  I thought it would
be rude, otherwise.
> 

 Ah, ok. Yes, the old ones can go.

 Did you have any special reason for remembering the old
opacity in the effect 
rather than adding such support to the framework (like in
this patch)?

-- 
Lubos Lunak
KDE developer
------------------------------------------------------------
--
SUSE LINUX, s.r.o.   e-mail: l.lunaksuse.cz , l.lunakkde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz

_______________________________________________
Kwin mailing list
Kwinkde.org
https://ma
il.kde.org/mailman/listinfo/kwin

On Monday 12 February 2007 08:17, Lubos Lunak wrote:
>  Did you have any special reason for remembering the
old opacity in the
> effect rather than adding such support to the framework
(like in this
> patch)?

Because by the time windowEvent() is called, the opacity has
already changed 
(I think).  I'll admit to not understanding the events part
of the code too 
well, but I think it would require having old_opacity be in
Toplevel, and 
that just seems ugly.

To be sure, I tried your patch with a modified FadeEffect,
and old_opacity is 
always equal to the new opacity.

-- 
Philip Falkner
_______________________________________________
Kwin mailing list
Kwinkde.org
https://ma
il.kde.org/mailman/listinfo/kwin