Extensive use of QX11Info::appDepth() breaks compositing

Zack's recent patch to qt-copy 0182-argb-visuals-default
changes the value of 
QX11Info::appDepth().  We've been abusing appDepth() in all
three compositing 
scenes to determine the buffer's depth, which now breaks.

It's a simple piece of code to find the depth of the default
X visual's depth, 
but since all three scenes need it, I put it in
Scene::Scene().  Anyone have 
a better way of finding the root window's depth, or any
objections to this 
patch?

-- 
Philip Falkner

_______________________________________________
Kwin mailing list
Kwinkde.org
https://ma
il.kde.org/mailman/listinfo/kwin

On Wednesday 11 July 2007 01:17, Philip Falkner wrote:
> Zack's recent patch to qt-copy
0182-argb-visuals-default changes the value of 
> QX11Info::appDepth().  We've been abusing appDepth() in
all three compositing 
> scenes to determine the buffer's depth, which now
breaks.
> 
> It's a simple piece of code to find the depth of the
default X visual's depth, 
> but since all three scenes need it, I put it in
Scene::Scene().  Anyone have 
> a better way of finding the root window's depth, or any
objections to this 
> patch?

Yes, the Xlib macro DefaultDepth(Display *dpy, int screen)
returns
the depth of the root window.

Fredrik

_______________________________________________
Kwin mailing list
Kwinkde.org
https://ma
il.kde.org/mailman/listinfo/kwin

On Wednesday 11 July 2007 15:23:33 Fredrik Höglund wrote:
> On Wednesday 11 July 2007 01:17, Philip Falkner wrote:
> > Zack's recent patch to qt-copy
0182-argb-visuals-default changes the
> > value of QX11Info::appDepth().  We've been abusing
appDepth() in all
> > three compositing scenes to determine the buffer's
depth, which now
> > breaks.
> >
> > It's a simple piece of code to find the depth of
the default X visual's
> > depth, but since all three scenes need it, I put
it in Scene::Scene(). 
> > Anyone have a better way of finding the root
window's depth, or any
> > objections to this patch?
>
> Yes, the Xlib macro DefaultDepth(Display *dpy, int
screen) returns
> the depth of the root window.

Well...sure, if you want to do it the easy way.  Thanks.


> Fredrik
>
> _______________________________________________
> Kwin mailing list
> Kwinkde.org
> https://ma
il.kde.org/mailman/listinfo/kwin

-- 
Philip Falkner

_______________________________________________
Kwin mailing list
Kwinkde.org
https://ma
il.kde.org/mailman/listinfo/kwin

On Wednesday 11 of July 2007, Philip Falkner wrote:
> On Wednesday 11 July 2007 15:23:33 Fredrik Höglund
wrote:
> > On Wednesday 11 July 2007 01:17, Philip Falkner
wrote:
> > > Zack's recent patch to qt-copy
0182-argb-visuals-default changes the
> > > value of QX11Info::appDepth().  We've been
abusing appDepth() in all
> > > three compositing scenes to determine the
buffer's depth, which now
> > > breaks.
> > >
> > > It's a simple piece of code to find the depth
of the default X visual's
> > > depth, but since all three scenes need it, I
put it in Scene::Scene().
> > > Anyone have a better way of finding the root
window's depth, or any
> > > objections to this patch?
> >
> > Yes, the Xlib macro DefaultDepth(Display *dpy, int
screen) returns
> > the depth of the root window.
>
> Well...sure, if you want to do it the easy way. 
Thanks. 

 Patch looks ok.

-- 
Lubos Lunak
KDE developer
------------------------------------------------------------
--
SUSE LINUX, s.r.o.   e-mail: l.lunaksuse.cz , l.lunakkde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http//www.suse.cz
_______________________________________________
Kwin mailing list
Kwinkde.org
https://ma
il.kde.org/mailman/listinfo/kwin