Crash Dump Region

Hi,

I am currently looking over the code that places the
crashdump
region into /proc/iomem, and the code that determines its
base
address if it is not passed on the kernel comamnd. It seems
to me that 
the current code allows the crashkernel to be placed incide
a
/proc/iomem region of any type. Is this behaviour correct?
If not, should it be restricted to "System RAM"
regions?

-- 
Horms
  H: http://www.vergenet.n
et/~horms/
  W: http://www.valinux.co.jp
/en/

-
To unsubscribe from this list: send the line
"unsubscribe linux-ia64" in
the body of a message to majordomovger.kernel.org
More majordomo info at  http://vge
r.kernel.org/majordomo-info.html

> -----Original Message-----
> From: Horms [mailto:hormsverge.net.au]
> Sent: 2007Äê3ÔÂ6ÈÕ 9:57
> To: Zou, Nanhai
> Cc: Linux-IA64; fastboot
> Subject: Crash Dump Region
> 
> Hi,
> 
> I am currently looking over the code that places the
crashdump
> region into /proc/iomem, and the code that determines
its base
> address if it is not passed on the kernel comamnd. It
seems to me that
> the current code allows the crashkernel to be placed
incide a
> /proc/iomem region of any type. Is this behaviour
correct?
> If not, should it be restricted to "System
RAM" regions?
> 
 I not sure if I understand your question.
 Kernel will find a big enough region inside efi memmap with
WB attribute, excluding all the other reserved regions.

 Zou Nanhai.

> --
> Horms
>   H: http://www.vergenet.n
et/~horms/
>   W: http://www.valinux.co.jp
/en/
-
To unsubscribe from this list: send the line
"unsubscribe linux-ia64" in
the body of a message to majordomovger.kernel.org
More majordomo info at  http://vge
r.kernel.org/majordomo-info.html

On Tue, 2007-03-06 at 09:56, Horms wrote:
> Hi,
> 
> I am currently looking over the code that places the
crashdump
> region into /proc/iomem, and the code that determines
its base
> address if it is not passed on the kernel comamnd. It
seems to me that
> the current code allows the crashkernel to be placed
incide a
> /proc/iomem region of any type. Is this behaviour
correct?
> If not, should it be restricted to "System
RAM" regions?
> 
> -- 
> Horms
>   H: http://www.vergenet.n
et/~horms/
>   W: http://www.valinux.co.jp
/en/
> 

Please review the patch.

Thanks
Zou Nan hai

Signed-off-by: Zou Nan hai <nanhai.zouintel.com>

--- a/arch/ia64/kernel/efi.c	2007-02-27 00:42:06.000000000
-0500
+++ b/arch/ia64/kernel/efi.c	2007-03-05 22:09:40.000000000
-0500
 -1154,7
+1154,7  kdump_find_rsvd_region (unsigned long si
 
   for (p = efi_map_start; p < efi_map_end; p +=
efi_desc_size) {
 	  md = p;
-	  if (!efi_wb(md))
+	  if (!is_memory_available(md))
 		  continue;
 	  start = ALIGN(md->phys_addr, alignment);
 	  end = efi_md_end(md);



-
To unsubscribe from this list: send the line
"unsubscribe linux-ia64" in
the body of a message to majordomovger.kernel.org
More majordomo info at  http://vge
r.kernel.org/majordomo-info.html

On Tue, Mar 06, 2007 at 10:32:09AM +0800, Zou Nan hai
wrote:
> On Tue, 2007-03-06 at 09:56, Horms wrote:
> > Hi,
> > 
> > I am currently looking over the code that places
the crashdump
> > region into /proc/iomem, and the code that
determines its base
> > address if it is not passed on the kernel comamnd.
It seems to me that
> > the current code allows the crashkernel to be
placed incide a
> > /proc/iomem region of any type. Is this behaviour
correct?
> > If not, should it be restricted to "System
RAM" regions?
> 
> Please review the patch.

This looks good to me.

Acked-by: Simon Horman <hormsverge.net.au>

> Thanks
> Zou Nan hai
> 
> Signed-off-by: Zou Nan hai <nanhai.zouintel.com>
> 
> --- a/arch/ia64/kernel/efi.c	2007-02-27
00:42:06.000000000 -0500
> +++ b/arch/ia64/kernel/efi.c	2007-03-05
22:09:40.000000000 -0500
>  -1154,7 +1154,7  kdump_find_rsvd_region
(unsigned long si
>  
>    for (p = efi_map_start; p < efi_map_end; p +=
efi_desc_size) {
>  	  md = p;
> -	  if (!efi_wb(md))
> +	  if (!is_memory_available(md))
>  		  continue;
>  	  start = ALIGN(md->phys_addr, alignment);
>  	  end = efi_md_end(md);
> 
> 

-- 
Horms
  H: http://www.vergenet.n
et/~horms/
  W: http://www.valinux.co.jp
/en/

-
To unsubscribe from this list: send the line
"unsubscribe linux-ia64" in
the body of a message to majordomovger.kernel.org
More majordomo info at  http://vge
r.kernel.org/majordomo-info.html