List Info

Thread: ia64: fix build failure on fs/quota.c




ia64: fix build failure on fs/quota.c
country flaguser name
United States
2007-07-19 12:15:29
Fix ia64 build failure on fs/qutoa.c.  A recent patch used
the
type compat_u64 which on ia64 is only available if
CONFIG_COMPAT
is defined.


From: Tony Luck <tony.luckintel.com>
Signed-off-by: Doug Chapman <doug.chapmanhp.com>

--

--- a/fs/quota.c
+++ b/fs/quota.c
 -387,7
+387,7  asmlinkage long sys_quotactl(unsigned int cmd, const
char __user *special, qid_t
        return ret;
 }
 
-#if defined(CONFIG_X86_64) || defined(CONFIG_IA64)
+#if defined(CONFIG_X86_64) || (defined(CONFIG_IA64)
&& defined(CONFIG_COMPAT))
 /*
  * This code works only for 32 bit quota tools over 64 bit
OS (x86_64, ia64)
  * and is necessary due to alignment problems.



-
To unsubscribe from this list: send the line
"unsubscribe linux-ia64" in
the body of a message to majordomovger.kernel.org
More majordomo info at  http://vge
r.kernel.org/majordomo-info.html

Re: ia64: fix build failure on fs/quota.c
country flaguser name
United States
2007-07-26 12:48:56
On Thu, 2007-07-19 at 13:15 -0400, Doug Chapman wrote:
> Fix ia64 build failure on fs/qutoa.c.  A recent patch
used the
> type compat_u64 which on ia64 is only available if
CONFIG_COMPAT
> is defined.
> 
> 
> From: Tony Luck <tony.luckintel.com>
> Signed-off-by: Doug Chapman <doug.chapmanhp.com>
> 
> --
> 
> --- a/fs/quota.c
> +++ b/fs/quota.c
>  -387,7 +387,7  asmlinkage long sys_quotactl(unsigned int
cmd, const char __user *special, qid_t
>         return ret;
>  }
>  
> -#if defined(CONFIG_X86_64) || defined(CONFIG_IA64)
> +#if defined(CONFIG_X86_64) || (defined(CONFIG_IA64)
&& defined(CONFIG_COMPAT))
>  /*
>   * This code works only for 32 bit quota tools over 64
bit OS (x86_64, ia64)
>   * and is necessary due to alignment problems.
> 
> 

I see that this patch has not been pulled in yet.  I am
wondering if I
confused things by sending it to both linux-kernel and
linux-ia64 lists
and each expected the other to pull it in?  Sorry if that
breaks the
process, I am somewhat new to submitting patches.

Can we see about getting this in?  It will break the build
used by
fedora/RHEL for certain and I expect other distro's as
well.

thanks,

- Doug


-
To unsubscribe from this list: send the line
"unsubscribe linux-ia64" in
the body of a message to majordomovger.kernel.org
More majordomo info at  http://vge
r.kernel.org/majordomo-info.html

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )