On Jul 30, 2007, at 2:42 AM, Knut Urdalen wrote:
> Alvaro Carrasco wrote:
>> When running the unit tests, 7 tests get reported
as Incomplete. I
>> can see that the code inside is commented out, were
these flagged
>> as incomplete because they didn't work?
>>
> Correct 
>> I can create a jira issue and work on getting those
tests to work
>> if that's the case.
> That would be really nice
>
> All implementation files should have a corresponding
test file in
> the test/-directory. There are many files missing. I
suggest you
> create a placeholder ticket for completing the unit
tests. Use the
> code coverage report tool in PHPUnit 3 (phpunit
--report=coverage
> AllTests.php) to help you find missing classes that
need test
> coverage.
>
> Knut
The code coverage from the log4j tests suite isn't
particularly
high. Those tests are much closer to integration tests than
unit
tests, however I think there could be benefit to
transliterating them
to log4php. Transliterating the tests should be lot less
intellectually demanding than creating new ones from scratch
and it
promotes consistency between the frameworks.
When I've needed to write tests for log4cxx to isolate a bug
or to
support refactoring, I've also tried to add the test to the
log4j
suite too.
|
