List Info

Thread: Re: All welcome Artyom




Re: All welcome Artyom
user name
2007-09-10 06:10:15
> Sorry for flooding you with emails.

Np. Happens...

> Here comes the patch for user removal(with inclusion of
feed removal).
> Delete account link added into left menu.
> Check this and reply me with comments.

I checked your patch for OgOg account & feed-deletion,
and I found it
to be fine. The confirmation-box showing when one clicks
delete
account, is a neat addition. In app/views/feed/show.rhtml I
made some
small changes to make the code cleaner, but on the whole I
found it a
good patch (in as good as possible)...

One tip is that when making patches this can done best with
svn diff >
new_patchfile from the trunk-dir, instead of separately, as
otherwise
the whole path could be included...

Also with svn diff -r466:r467 one can see the changes
between 2
revisions (this example actually shows Artyom's patch apart
from some
small fixes to tasks and the 001 migration-file's license).

Anyway, welcome Artyom, you have commit-rights now (for all
our
projects), so you can directly commit your changes and
improvements...

We will be able to review and discuss them on our svn-list
after they
have been committed (but before I take them live on our
production-
server): https://lists.sourceforge.net/mailman/listinfo/logilo
gi-svn

If you like to, you can now proceed with the other things
mentioned
in the previous list-mail...

greetings,

Wybo

PS: Cool to have someone from Belarus with us... How is life
there ?

------------------------------------------------------------
-------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
LogiLogi-list mailing list
LogiLogi-listlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/logilogi-
list

Re: All welcome Artyom
country flaguser name
Belarus
2007-09-10 17:12:35
>> Sorry for flooding you with emails.
>>     
>
> Np. Happens...
>
>   
>> Here comes the patch for user removal(with
inclusion of feed removal).
>> Delete account link added into left menu.
>> Check this and reply me with comments.
>>     
>
> I checked your patch for OgOg account &
feed-deletion, and I found it
> to be fine. The confirmation-box showing when one
clicks delete
> account, is a neat addition. In
app/views/feed/show.rhtml I made some
> small changes to make the code cleaner, but on the
whole I found it a
> good patch (in as good as possible)...
>
> One tip is that when making patches this can done best
with svn diff >
> new_patchfile from the trunk-dir, instead of
separately, as otherwise
> the whole path could be included...
>
> Also with svn diff -r466:r467 one can see the changes
between 2
> revisions (this example actually shows Artyom's patch
apart from some
> small fixes to tasks and the 001 migration-file's
license).
>   
So I thought Subclipse patch creation tool is not very good

practice(also I tried to apply the patch and it applied
natively (maybe 
Subclipse-specific feature)).
> Anyway, welcome Artyom, you have commit-rights now (for
all our
> projects), so you can directly commit your changes and
improvements...
>   
That's really great.
> We will be able to review and discuss them on our
svn-list after they
> have been committed (but before I take them live on our
production-
> server): https://lists.sourceforge.net/mailman/listinfo/logilo
gi-svn
>
> If you like to, you can now proceed with the other
things mentioned
> in the previous list-mail...
>   
Here we go.
> greetings,
>
> Wybo
>
> PS: Cool to have someone from Belarus with us... How is
life there ?
>   
Mmmm.... How do you know I'm from Belarus(or I filled
country field in 
My Sourceforge Profile  )?
Not very peaceful in general, let's see how it goes in 2-3
years.
I live in the capital, but people who live in the country
live very poor 
and ugly. That's what I hate.
That's annoying politics. I think you also know a lot about
our country 
and especially about our president. 
>
------------------------------------------------------------
-------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> LogiLogi-list mailing list
> LogiLogi-listlists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/logilogi-
list
>
>   


------------------------------------------------------------
-------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
LogiLogi-list mailing list
LogiLogi-listlists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/logilogi-
list

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )