Created: (LUCENE-609) Lazy field loading breaks backward compat

Lazy field loading breaks backward compat
-----------------------------------------

         Key: LUCENE-609
         URL: http:
//issues.apache.org/jira/browse/LUCENE-609
     Project: Lucene - Java
        Type: Bug

  Components: Other  
    Versions: 2.0.1    
    Reporter: Yonik Seeley
     Fix For: 2.0.1


Document.getField() and Document.getFields() have changed in
a non backward compatible manner.
Simple code like the following no longer compiles:
 Field x = mydoc.getField("x");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

-
For more information on JIRA, see:
   http://www.atl
assian.com/software/jira


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

    [ http://issues.apache.org/jira/brows
e/LUCENE-609?page=comments#action_12417164 ] 

Yonik Seeley commented on LUCENE-609:
-------------------------------------

I just verified that Solr now compiles/works correctly again
with this patch.
Any objections to committing it?


> Lazy field loading breaks backward compat
> -----------------------------------------
>
>          Key: LUCENE-609
>          URL: http:
//issues.apache.org/jira/browse/LUCENE-609
>      Project: Lucene - Java
>         Type: Bug

>   Components: Other
>     Versions: 2.0.1
>     Reporter: Yonik Seeley
>      Fix For: 2.0.1
>  Attachments: fieldable_patch.diff
>
> Document.getField() and Document.getFields() have
changed in a non backward compatible manner.
> Simple code like the following no longer compiles:
>  Field x = mydoc.getField("x");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

-
For more information on JIRA, see:
   http://www.atl
assian.com/software/jira


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

     [ http://issues.apache.org/jira/browse/LUCENE-609?page=all
 ]

Yonik Seeley updated LUCENE-609:
--------------------------------

    Attachment: fieldable_patch.diff

OK, here's the quick'n'dirty version that passes lucene
unit tests.

-  The new getFieldable methods can be considered temporary
until we decide if that's really the best way to provide
access to the new functionallity.

- At least some of the Fieldable instances in all of the
unit tests should be reverted back to Field so we get some
test coverage (that is what everyone still uses).


> Lazy field loading breaks backward compat
> -----------------------------------------
>
>          Key: LUCENE-609
>          URL: http:
//issues.apache.org/jira/browse/LUCENE-609
>      Project: Lucene - Java
>         Type: Bug

>   Components: Other
>     Versions: 2.0.1
>     Reporter: Yonik Seeley
>      Fix For: 2.0.1
>  Attachments: fieldable_patch.diff
>
> Document.getField() and Document.getFields() have
changed in a non backward compatible manner.
> Simple code like the following no longer compiles:
>  Field x = mydoc.getField("x");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

-
For more information on JIRA, see:
   http://www.atl
assian.com/software/jira


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

Maybe I am missing something...

Would it not be easier to just create a LazyDocument that
extends Document,
and handles all of this transparently? It would also require
no changes to
existing code.

The code that currently returns a Document, can just return
a LazyDocument
(if lazy/selective loading is enabled).

-----Original Message-----
From: Yonik Seeley (JIRA) [mailto:jiraapache.org] 
Sent: Wednesday, June 21, 2006 2:29 PM
To: java-devlucene.apache.org
Subject: [jira] Commented: (LUCENE-609) Lazy field loading
breaks backward
compat

    [
http://issues.apache.org/jira/browse
/LUCENE-609?page=comments#action_1241716
4 ] 

Yonik Seeley commented on LUCENE-609:
-------------------------------------

I just verified that Solr now compiles/works correctly again
with this
patch.
Any objections to committing it?


> Lazy field loading breaks backward compat
> -----------------------------------------
>
>          Key: LUCENE-609
>          URL: http:
//issues.apache.org/jira/browse/LUCENE-609
>      Project: Lucene - Java
>         Type: Bug

>   Components: Other
>     Versions: 2.0.1
>     Reporter: Yonik Seeley
>      Fix For: 2.0.1
>  Attachments: fieldable_patch.diff
>
> Document.getField() and Document.getFields() have
changed in a non
backward compatible manner.
> Simple code like the following no longer compiles:
>  Field x = mydoc.getField("x");

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

-
For more information on JIRA, see:
   http://www.atl
assian.com/software/jira


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

    [ http://issues.apache.org/jira/brows
e/LUCENE-609?page=comments#action_12417166 ] 

Grant Ingersoll commented on LUCENE-609:
----------------------------------------

I think there is a typo of getFielables on Document.java,
other than that looks good.

> Lazy field loading breaks backward compat
> -----------------------------------------
>
>          Key: LUCENE-609
>          URL: http:
//issues.apache.org/jira/browse/LUCENE-609
>      Project: Lucene - Java
>         Type: Bug

>   Components: Other
>     Versions: 2.0.1
>     Reporter: Yonik Seeley
>      Fix For: 2.0.1
>  Attachments: fieldable_patch.diff
>
> Document.getField() and Document.getFields() have
changed in a non backward compatible manner.
> Simple code like the following no longer compiles:
>  Field x = mydoc.getField("x");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

-
For more information on JIRA, see:
   http://www.atl
assian.com/software/jira


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

I am not sure I see why it would require no changes?  You
would have to 
have some way to tell the FieldsReader you wanted a
LazyDocument instead 
of a regular Document.  Also, the desire was to have the
ability to have 
some fields load as they do now while others are loaded when
accessed.


Robert Engels wrote:
> Maybe I am missing something...
>
> Would it not be easier to just create a LazyDocument
that extends Document,
> and handles all of this transparently? It would also
require no changes to
> existing code.
>
> The code that currently returns a Document, can just
return a LazyDocument
> (if lazy/selective loading is enabled).
>
> -----Original Message-----
> From: Yonik Seeley (JIRA) [mailto:jiraapache.org] 
> Sent: Wednesday, June 21, 2006 2:29 PM
> To: java-devlucene.apache.org
> Subject: [jira] Commented: (LUCENE-609) Lazy field
loading breaks backward
> compat
>
>     [
> http://issues.apache.org/jira/browse
/LUCENE-609?page=comments#action_1241716
> 4 ] 
>
> Yonik Seeley commented on LUCENE-609:
> -------------------------------------
>
> I just verified that Solr now compiles/works correctly
again with this
> patch.
> Any objections to committing it?
>
>
>   
>> Lazy field loading breaks backward compat
>> -----------------------------------------
>>
>>          Key: LUCENE-609
>>          URL: http:
//issues.apache.org/jira/browse/LUCENE-609
>>      Project: Lucene - Java
>>         Type: Bug
>>     
>
>   
>>   Components: Other
>>     Versions: 2.0.1
>>     Reporter: Yonik Seeley
>>      Fix For: 2.0.1
>>  Attachments: fieldable_patch.diff
>>
>> Document.getField() and Document.getFields() have
changed in a non
>>     
> backward compatible manner.
>   
>> Simple code like the following no longer compiles:
>>  Field x = mydoc.getField("x");
>>     
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the
administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa

> -
> For more information on JIRA, see:
>    http://www.atl
assian.com/software/jira
>
>
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
> For additional commands, e-mail: java-dev-helplucene.apache.org
>
>
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
> For additional commands, e-mail: java-dev-helplucene.apache.org
>
>
>   

-- 

Grant Ingersoll 
Sr. Software Engineer 
Center for Natural Language Processing 
Syracuse University 
School of Information Studies 
335 Hinds Hall 
Syracuse, NY 13244 

http://www.cnlp.org 
Voice:  315-443-5484 
Fax: 315-443-6886 


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

     [ http://issues.apache.org/jira/browse/LUCENE-609?page=all
 ]
     
Yonik Seeley resolved LUCENE-609:
---------------------------------

    Resolution: Fixed
     Assign To: Yonik Seeley

Committed (with typo fixes 

The main point for me was to return backward compatibility
of getField(s)
Other committers should feel free to change/remove the
getFieldable methods... they are still new enough to be
considered temporary IMO.

> Lazy field loading breaks backward compat
> -----------------------------------------
>
>          Key: LUCENE-609
>          URL: http:
//issues.apache.org/jira/browse/LUCENE-609
>      Project: Lucene - Java
>         Type: Bug

>   Components: Other
>     Versions: 2.0.1
>     Reporter: Yonik Seeley
>     Assignee: Yonik Seeley
>      Fix For: 2.0.1
>  Attachments: fieldable_patch.diff
>
> Document.getField() and Document.getFields() have
changed in a non backward compatible manner.
> Simple code like the following no longer compiles:
>  Field x = mydoc.getField("x");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

-
For more information on JIRA, see:
   http://www.atl
assian.com/software/jira


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

: Would it not be easier to just create a LazyDocument that
extends Document,
: and handles all of this transparently? It would also
require no changes to
: existing code.
:
: The code that currently returns a Document, can just
return a LazyDocument
: (if lazy/selective loading is enabled).

assuming you mean revert the return type of
Document.getField back to
"Field" and then LazyDocument as a subclass of
Document;
LazyDocument.getField would still need to be declared to
return "Field"
and that's the reason why the Fieldable interface was
added: because
LazyField doesn't extend Field.


: -----Original Message-----
: From: Yonik Seeley (JIRA) [mailto:jiraapache.org]
: Sent: Wednesday, June 21, 2006 2:29 PM
: To: java-devlucene.apache.org
: Subject: [jira] Commented: (LUCENE-609) Lazy field loading
breaks backward
: compat
:
:     [
: http://issues.apache.org/jira/browse
/LUCENE-609?page=comments#action_1241716
: 4 ]
:
: Yonik Seeley commented on LUCENE-609:
: -------------------------------------
:
: I just verified that Solr now compiles/works correctly
again with this
: patch.
: Any objections to committing it?
:
:
: > Lazy field loading breaks backward compat
: > -----------------------------------------
: >
: >          Key: LUCENE-609
: >          URL: http:
//issues.apache.org/jira/browse/LUCENE-609
: >      Project: Lucene - Java
: >         Type: Bug
:
: >   Components: Other
: >     Versions: 2.0.1
: >     Reporter: Yonik Seeley
: >      Fix For: 2.0.1
: >  Attachments: fieldable_patch.diff
: >
: > Document.getField() and Document.getFields() have
changed in a non
: backward compatible manner.
: > Simple code like the following no longer compiles:
: >  Field x = mydoc.getField("x");
:
: --
: This message is automatically generated by JIRA.
: -
: If you think it was sent incorrectly contact one of the
administrators:
:    http://issues.apache.org/jira/secure/Administrators.jspa

: -
: For more information on JIRA, see:
:    http://www.atl
assian.com/software/jira
:
:
:
------------------------------------------------------------
---------
: To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
: For additional commands, e-mail: java-dev-helplucene.apache.org
:
:
:
------------------------------------------------------------
---------
: To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
: For additional commands, e-mail: java-dev-helplucene.apache.org
:



-Hoss


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

I was thinking of a default value, probably by Searcher,
that is 'use lazy
loading'.

For query specific "which fields to load", you
are correct, there is no REAL
choice but add new code, but I would think you would pass a
list of field
ids to the searcher that you wanted early loaded. But this
could be easily
done with a overloaded method that took the list of fields,
with the
original methods delegating and passing null (for all fields
loading use the
default Searcher method).

Would this not be a simpler interface and require no changes
to existing
code?

-----Original Message-----
From: Grant Ingersoll [mailto:gsingerssyr.edu] 
Sent: Wednesday, June 21, 2006 2:58 PM
To: java-devlucene.apache.org
Subject: Re: [jira] Commented: (LUCENE-609) Lazy field
loading breaks
backward compat

I am not sure I see why it would require no changes?  You
would have to have
some way to tell the FieldsReader you wanted a LazyDocument
instead of a
regular Document.  Also, the desire was to have the ability
to have some
fields load as they do now while others are loaded when
accessed.


Robert Engels wrote:
> Maybe I am missing something...
>
> Would it not be easier to just create a LazyDocument
that extends 
> Document, and handles all of this transparently? It
would also require 
> no changes to existing code.
>
> The code that currently returns a Document, can just
return a 
> LazyDocument (if lazy/selective loading is enabled).
>
> -----Original Message-----
> From: Yonik Seeley (JIRA) [mailto:jiraapache.org]
> Sent: Wednesday, June 21, 2006 2:29 PM
> To: java-devlucene.apache.org
> Subject: [jira] Commented: (LUCENE-609) Lazy field
loading breaks 
> backward compat
>
>     [
> http://issues.apache.org/jira/browse/LUCEN
E-609?page=comments#action_1
> 241716
> 4 ]
>
> Yonik Seeley commented on LUCENE-609:
> -------------------------------------
>
> I just verified that Solr now compiles/works correctly
again with this 
> patch.
> Any objections to committing it?
>
>
>   
>> Lazy field loading breaks backward compat
>> -----------------------------------------
>>
>>          Key: LUCENE-609
>>          URL: http:
//issues.apache.org/jira/browse/LUCENE-609
>>      Project: Lucene - Java
>>         Type: Bug
>>     
>
>   
>>   Components: Other
>>     Versions: 2.0.1
>>     Reporter: Yonik Seeley
>>      Fix For: 2.0.1
>>  Attachments: fieldable_patch.diff
>>
>> Document.getField() and Document.getFields() have
changed in a non
>>     
> backward compatible manner.
>   
>> Simple code like the following no longer compiles:
>>  Field x = mydoc.getField("x");
>>     
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the
administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa

> -
> For more information on JIRA, see:
>    http://www.atl
assian.com/software/jira
>
>
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
> For additional commands, e-mail: java-dev-helplucene.apache.org
>
>
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
> For additional commands, e-mail: java-dev-helplucene.apache.org
>
>
>   

-- 

Grant Ingersoll
Sr. Software Engineer
Center for Natural Language Processing
Syracuse University
School of Information Studies
335 Hinds Hall
Syracuse, NY 13244 

http://www.cnlp.org
Voice:  315-443-5484
Fax: 315-443-6886 


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

On 6/21/06, Chris Hostetter <hossman_lucenefucit.org> wrote:
> LazyField doesn't extend Field.

Yeah, that's the crux of the matter.

I assume this is the case because people need to instantiate
Field to
add it to a Document at index time, and I guess there is
some FIeld
baggage that LazyField didn't want to bring along.

Which also brings us back to the fact that the Field you
index should
have never been the Field you get back (but as I've said,
it's water
long under the bridge).

-Yonik
http://incubator.apa
che.org/solr Solr, the open-source Lucene search server

------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org