Created: (LUCENE-1027) contrib/benchmark config does not play nice with doubles with the flus

contrib/benchmark config does not play nice with doubles
with the flush.by.ram value
------------------------------------------------------------
------------------------

                 Key: LUCENE-1027
                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1027
             Project: Lucene - Java
          Issue Type: Bug
          Components: contrib/benchmark
            Reporter: Grant Ingersoll
            Assignee: Grant Ingersoll
            Priority: Minor


In the o.a.l.benchmark.byTask.utils.Config.java file, the
nextRound and various other methods do not handle doubles in
the "round" property configuration syntax.

To replicate this, copy the micro-standard.alg and replace 
merge.factor=mrg:10:100:10:100
max.buffered=buf:10:10:100:100

with

ram.flush.mb=ram:32:40:48:56

and you will get various ClassCastExceptions in Config (one
in newRound() and, when that is fixed, in
getColsValuesForValsByRound.

The fix seems to be to just to mirror the handling of
int[].

The fix seems relatively minor.  Patch shortly and will plan
to commit tomorrow evening.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-1027?page=co
m.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated LUCENE-1027:
------------------------------------

    Attachment: LUCENE-1027.patch

Patch with fix, and an alg file that mirrors micro-standard
but flushes by RAM.

> contrib/benchmark config does not play nice with
doubles with the flush.by.ram value
>
------------------------------------------------------------
------------------------
>
>                 Key: LUCENE-1027
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1027
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LUCENE-1027.patch
>
>
> In the o.a.l.benchmark.byTask.utils.Config.java file,
the nextRound and various other methods do not handle
doubles in the "round" property configuration
syntax.
> To replicate this, copy the micro-standard.alg and
replace 
> merge.factor=mrg:10:100:10:100
> max.buffered=buf:10:10:100:100
> with
> ram.flush.mb=ram:32:40:48:56
> and you will get various ClassCastExceptions in Config
(one in newRound() and, when that is fixed, in
getColsValuesForValsByRound.
> The fix seems to be to just to mirror the handling of
int[].
> The fix seems relatively minor.  Patch shortly and will
plan to commit tomorrow evening.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

    [ https://issues.apache.org/jira/browse
/LUCENE-1027?page=com.atlassian.jira.plugin.system.issuetabp
anels:comment-tabpanel#action_12533989 ] 

Michael McCandless commented on LUCENE-1027:
--------------------------------------------

Woops, I caused this when I added "double" as a
parameter type in Config.  Thanks Hoss.  The patch looks
good!

> contrib/benchmark config does not play nice with
doubles with the flush.by.ram value
>
------------------------------------------------------------
------------------------
>
>                 Key: LUCENE-1027
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1027
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LUCENE-1027.patch
>
>
> In the o.a.l.benchmark.byTask.utils.Config.java file,
the nextRound and various other methods do not handle
doubles in the "round" property configuration
syntax.
> To replicate this, copy the micro-standard.alg and
replace 
> merge.factor=mrg:10:100:10:100
> max.buffered=buf:10:10:100:100
> with
> ram.flush.mb=ram:32:40:48:56
> and you will get various ClassCastExceptions in Config
(one in newRound() and, when that is fixed, in
getColsValuesForValsByRound.
> The fix seems to be to just to mirror the handling of
int[].
> The fix seems relatively minor.  Patch shortly and will
plan to commit tomorrow evening.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

    [ https://issues.apache.org/jira/browse
/LUCENE-1027?page=com.atlassian.jira.plugin.system.issuetabp
anels:comment-tabpanel#action_12533990 ] 

Michael McCandless commented on LUCENE-1027:
--------------------------------------------

Woops, make that "Thanks Grant".  It's too early


> contrib/benchmark config does not play nice with
doubles with the flush.by.ram value
>
------------------------------------------------------------
------------------------
>
>                 Key: LUCENE-1027
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1027
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LUCENE-1027.patch
>
>
> In the o.a.l.benchmark.byTask.utils.Config.java file,
the nextRound and various other methods do not handle
doubles in the "round" property configuration
syntax.
> To replicate this, copy the micro-standard.alg and
replace 
> merge.factor=mrg:10:100:10:100
> max.buffered=buf:10:10:100:100
> with
> ram.flush.mb=ram:32:40:48:56
> and you will get various ClassCastExceptions in Config
(one in newRound() and, when that is fixed, in
getColsValuesForValsByRound.
> The fix seems to be to just to mirror the handling of
int[].
> The fix seems relatively minor.  Patch shortly and will
plan to commit tomorrow evening.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-1027?page=co
m.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll resolved LUCENE-1027.
-------------------------------------

    Resolution: Fixed

Committed.

> contrib/benchmark config does not play nice with
doubles with the flush.by.ram value
>
------------------------------------------------------------
------------------------
>
>                 Key: LUCENE-1027
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1027
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LUCENE-1027.patch
>
>
> In the o.a.l.benchmark.byTask.utils.Config.java file,
the nextRound and various other methods do not handle
doubles in the "round" property configuration
syntax.
> To replicate this, copy the micro-standard.alg and
replace 
> merge.factor=mrg:10:100:10:100
> max.buffered=buf:10:10:100:100
> with
> ram.flush.mb=ram:32:40:48:56
> and you will get various ClassCastExceptions in Config
(one in newRound() and, when that is fixed, in
getColsValuesForValsByRound.
> The fix seems to be to just to mirror the handling of
int[].
> The fix seems relatively minor.  Patch shortly and will
plan to commit tomorrow evening.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-1027?page=co
m.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll closed LUCENE-1027.
-----------------------------------

    Lucene Fields:   (was: [New])

> contrib/benchmark config does not play nice with
doubles with the flush.by.ram value
>
------------------------------------------------------------
------------------------
>
>                 Key: LUCENE-1027
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1027
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LUCENE-1027.patch
>
>
> In the o.a.l.benchmark.byTask.utils.Config.java file,
the nextRound and various other methods do not handle
doubles in the "round" property configuration
syntax.
> To replicate this, copy the micro-standard.alg and
replace 
> merge.factor=mrg:10:100:10:100
> max.buffered=buf:10:10:100:100
> with
> ram.flush.mb=ram:32:40:48:56
> and you will get various ClassCastExceptions in Config
(one in newRound() and, when that is fixed, in
getColsValuesForValsByRound.
> The fix seems to be to just to mirror the handling of
int[].
> The fix seems relatively minor.  Patch shortly and will
plan to commit tomorrow evening.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org