CustomScoreQuery, etc are not Serializable

[tiny patch] CustomScoreQuery, etc are not Serializable
-------------------------------------------------------

                 Key: LUCENE-1028
                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1028
             Project: Lucene - Java
          Issue Type: Bug
          Components: Search
    Affects Versions: 2.2
            Reporter: Kyle Maxwell
            Priority: Critical


In order to work with ParallelMultiSearcher, Query weights
need to be serializable.  The interface Weight extends
java.io.Serializable, but it appears that some of the newer
queries unnecessarily store global state in their weights,
thus causing serialization errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-1028?page=co
m.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kyle Maxwell updated LUCENE-1028:
---------------------------------

    Attachment: lucene-serialization.diff

> [tiny patch] CustomScoreQuery, etc are not
Serializable
>
-------------------------------------------------------
>
>                 Key: LUCENE-1028
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1028
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.2
>            Reporter: Kyle Maxwell
>            Priority: Critical
>         Attachments: lucene-serialization.diff
>
>
> In order to work with ParallelMultiSearcher, Query
weights need to be serializable.  The interface Weight
extends java.io.Serializable, but it appears that some of
the newer queries unnecessarily store global state in their
weights, thus causing serialization errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

    [ https://issues.apache.org/jira/browse
/LUCENE-1028?page=com.atlassian.jira.plugin.system.issuetabp
anels:comment-tabpanel#action_12534520 ] 

Doron Cohen commented on LUCENE-1028:
-------------------------------------

Thanks for catching this Kyle.
Patch looks good to me and working.
I enhanced checkQuery() in test/a.o.l.search.QueryUtils to
check all queries for serialization.
This catches this bug and verifies the fix.
It also shows that BoostingTermQuery fails fr this check,
but I am not sure why.


> [tiny patch] CustomScoreQuery, etc are not
Serializable
>
-------------------------------------------------------
>
>                 Key: LUCENE-1028
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1028
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.2
>            Reporter: Kyle Maxwell
>            Priority: Critical
>         Attachments: lucene-serialization.diff
>
>
> In order to work with ParallelMultiSearcher, Query
weights need to be serializable.  The interface Weight
extends java.io.Serializable, but it appears that some of
the newer queries unnecessarily store global state in their
weights, thus causing serialization errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-1028?page=co
m.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen reassigned LUCENE-1028:
-----------------------------------

    Assignee: Doron Cohen

> [tiny patch] CustomScoreQuery, etc are not
Serializable
>
-------------------------------------------------------
>
>                 Key: LUCENE-1028
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1028
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.2
>            Reporter: Kyle Maxwell
>            Assignee: Doron Cohen
>            Priority: Critical
>         Attachments: lucene-serialization.diff
>
>
> In order to work with ParallelMultiSearcher, Query
weights need to be serializable.  The interface Weight
extends java.io.Serializable, but it appears that some of
the newer queries unnecessarily store global state in their
weights, thus causing serialization errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

    [ https://issues.apache.org/jira/browse
/LUCENE-1028?page=com.atlassian.jira.plugin.system.issuetabp
anels:comment-tabpanel#action_12534555 ] 

Doron Cohen commented on LUCENE-1028:
-------------------------------------

Correction - BoostingTermQuery is ok, but TestBTQ had to be
modified for the serialization test to pass. 
DisjunctionMaxQuery had problems to CustomScoreQuery.


> [tiny patch] CustomScoreQuery, etc are not
Serializable
>
-------------------------------------------------------
>
>                 Key: LUCENE-1028
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1028
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.2
>            Reporter: Kyle Maxwell
>            Assignee: Doron Cohen
>            Priority: Critical
>         Attachments: lucene-serialization.diff
>
>
> In order to work with ParallelMultiSearcher, Query
weights need to be serializable.  The interface Weight
extends java.io.Serializable, but it appears that some of
the newer queries unnecessarily store global state in their
weights, thus causing serialization errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

    [ https://issues.apache.org/jira/browse
/LUCENE-1028?page=com.atlassian.jira.plugin.system.issuetabp
anels:comment-tabpanel#action_12534555 ] 

doronc edited comment on LUCENE-1028 at 10/13/07 10:11 AM:
------------------------------------------------------------
----

Correction - BoostingTermQuery is ok, but TestBTQ had to be
modified for the serialization test to pass. 
DisjunctionMaxQuery had problems similar to
CustomScoreQuery.


      was (Author: doronc):
    Correction - BoostingTermQuery is ok, but TestBTQ had to
be modified for the serialization test to pass. 
DisjunctionMaxQuery had problems to CustomScoreQuery.

  
> [tiny patch] CustomScoreQuery, etc are not
Serializable
>
-------------------------------------------------------
>
>                 Key: LUCENE-1028
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1028
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.2
>            Reporter: Kyle Maxwell
>            Assignee: Doron Cohen
>            Priority: Critical
>         Attachments: lucene-serialization.diff
>
>
> In order to work with ParallelMultiSearcher, Query
weights need to be serializable.  The interface Weight
extends java.io.Serializable, but it appears that some of
the newer queries unnecessarily store global state in their
weights, thus causing serialization errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-1028?page=co
m.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen updated LUCENE-1028:
--------------------------------

    Attachment: lucene-serialization.diff

Updated patch contains:
- Kyle's fixes for search.function weights.
- serialization test as part of standard queries tests,
- fix for DisjunctionMaxQuery and for few tests.


> [tiny patch] CustomScoreQuery, etc are not
Serializable
>
-------------------------------------------------------
>
>                 Key: LUCENE-1028
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1028
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.2
>            Reporter: Kyle Maxwell
>            Assignee: Doron Cohen
>            Priority: Critical
>         Attachments: lucene-serialization.diff,
lucene-serialization.diff
>
>
> In order to work with ParallelMultiSearcher, Query
weights need to be serializable.  The interface Weight
extends java.io.Serializable, but it appears that some of
the newer queries unnecessarily store global state in their
weights, thus causing serialization errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-1028?page=co
m.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen updated LUCENE-1028:
--------------------------------

         Priority: Major  (was: Critical)
    Lucene Fields: [Patch Available]  (was: [Patch
Available, New])
          Summary: Weight is not serializable for some of
the queries  (was: [tiny patch] CustomScoreQuery, etc are
not Serializable)

> Weight is not serializable for some of the queries
> --------------------------------------------------
>
>                 Key: LUCENE-1028
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1028
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.2
>            Reporter: Kyle Maxwell
>            Assignee: Doron Cohen
>         Attachments: lucene-serialization.diff,
lucene-serialization.diff
>
>
> In order to work with ParallelMultiSearcher, Query
weights need to be serializable.  The interface Weight
extends java.io.Serializable, but it appears that some of
the newer queries unnecessarily store global state in their
weights, thus causing serialization errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-1028?page=co
m.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen resolved LUCENE-1028.
---------------------------------

    Resolution: Fixed

Just committed this fix. 
Thanks Kyle!

> Weight is not serializable for some of the queries
> --------------------------------------------------
>
>                 Key: LUCENE-1028
>                 URL: htt
ps://issues.apache.org/jira/browse/LUCENE-1028
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.2
>            Reporter: Kyle Maxwell
>            Assignee: Doron Cohen
>         Attachments: lucene-serialization.diff,
lucene-serialization.diff
>
>
> In order to work with ParallelMultiSearcher, Query
weights need to be serializable.  The interface Weight
extends java.io.Serializable, but it appears that some of
the newer queries unnecessarily store global state in their
weights, thus causing serialization errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


------------------------------------------------------------
---------
To unsubscribe, e-mail: java-dev-unsubscribelucene.apache.org
For additional commands, e-mail: java-dev-helplucene.apache.org