Patch for a pause property

I'm working on a stateless frontend for mplayer.  And to
give a good 
feel for the app(a play/pause button that shows play or
pause, not 
both, and not two buttons), I wanted to know if mplayer was
paused or 
not since it could be controlled outside of my
infrastructure.  Setting 
if it's paused or not doesn't work, it just pauses it.  It
only patches 
command.c and not slave.txt.  I've never dealt with
mplayer's internals 
so this was mainly just to get what I needed than anything
else.  
Hopefully someone knows how to clean it up and get it
working right.


_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-engmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-d
ev-eng

On Mon, Jun 09, 2008 at 03:51:01AM -0500, Joshua Isom
wrote:
> I'm working on a stateless frontend for mplayer.  And
to give a good  
> feel for the app(a play/pause button that shows play or
pause, not both, 
> and not two buttons), I wanted to know if mplayer was
paused or not since 
> it could be controlled outside of my infrastructure. 
Setting if it's 
> paused or not doesn't work, it just pauses it.  It only
patches  
> command.c and not slave.txt.  I've never dealt with
mplayer's internals  
> so this was mainly just to get what I needed than
anything else.   
> Hopefully someone knows how to clean it up and get it
working right.

some quick comments:
- don't mix spaces and tabs for indentation
- add documentation to DOCS/tech/slave.txt

Diego
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-engmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-d
ev-eng

On Jun 11, 2008, at 3:12 AM, Diego Biurrun wrote:

> On Wed, Jun 11, 2008 at 02:44:22AM -0500, Joshua Isom
wrote:
>>>>
>>>> <patch-command.c>
>>>
>>> some quick comments:
>>> - don't mix spaces and tabs for indentation
>>> - add documentation to DOCS/tech/slave.txt
>>
>> The spaces and tabs are like that in command.c so I
was just matching
>> it.
>
> Umm, no, not really.  If you scroll down a bit, you
will notice a lot 
> of
> functions written without tabs.
>
> Diego
>

 From what I can see, the majority of functions in command.c
use tabs 
and spaces for an indentation of 12 spaces, and cannot find
any coding 
standard file.  There's also an explicit refusal to patch
based solely 
on whitespace.  It looks to me like mplayer.c even uses tabs
to delimit 
some macro variables, and asxparser.c is based off of two
spaces 
instead of four.

Personally I prefer a tabstop of four and actual tabs, but
that's just 
me.

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-engmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-d
ev-eng

On Thu, Jun 12, 2008 at 01:08:01PM -0500, Joshua Isom
wrote:
> On Jun 11, 2008, at 3:12 AM, Diego Biurrun wrote:
> 
> > On Wed, Jun 11, 2008 at 02:44:22AM -0500, Joshua
Isom wrote:
> >>>>
> >>>> <patch-command.c>
> >>>
> >>> some quick comments:
> >>> - don't mix spaces and tabs for
indentation
> >>> - add documentation to
DOCS/tech/slave.txt
> >>
> >> The spaces and tabs are like that in command.c
so I was just matching
> >> it.
> >
> > Umm, no, not really.  If you scroll down a bit,
you will notice a lot 
> > of functions written without tabs.
> 
>  From what I can see, the majority of functions in
command.c use tabs 
> and spaces for an indentation of 12 spaces

I haven't counted them, but things looked different to me at
a glance.
There is nothing stopping you from using only spaces in any
case.

> There's also an explicit refusal to patch based solely
on whitespace.

You are misunderstanding.  Whitespace-only patches are not a
problem and
nothing is said about how new lines should be indented.

Diego
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-engmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-d
ev-eng

On Jun 13, 2008, at 3:33 AM, Diego Biurrun wrote:

> On Thu, Jun 12, 2008 at 01:08:01PM -0500, Joshua Isom
wrote:
>> On Jun 11, 2008, at 3:12 AM, Diego Biurrun wrote:
>>
>>  From what I can see, the majority of functions in
command.c use tabs
>> and spaces for an indentation of 12 spaces
>
> I haven't counted them, but things looked different to
me at a glance.
> There is nothing stopping you from using only spaces in
any case.
>
>> There's also an explicit refusal to patch based
solely on whitespace.
>
> You are misunderstanding.  Whitespace-only patches are
not a problem 
> and
> nothing is said about how new lines should be
indented.
>
> Diego
>

Here's a patch with only spaces.  Do you know where would be
the best 
spot to document that 'set_property pause 1' requires
"pausing" or 
"pausing_keep" to work?  It's due to input
commands unpausing 
mplayer(including the get_property commands), so appears to
not work at 
first.


_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-engmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-d
ev-eng

On Fri, 13 Jun 2008 13:20:27 -0500, Joshua Isom
<jrisomgmail.com> wrote:
>Here's a patch with only spaces.  Do you know where
would be the best 
>spot to document that 'set_property pause 1' requires
"pausing" or 
>"pausing_keep" to work?  It's due to input
commands unpausing 
>mplayer(including the get_property commands), so appears
to not work at 
>first.

in DOCS/tech/slave.txt
but there is already a pause function.
does yours interfere with it at all? if not just add a note
when getting pause status that it requires pausing ...

pause
    Pause/unpause the playback.

-compn
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-engmplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-d
ev-eng