9389: trunk/xapian-core/ trunk/xapian-core/net/

On Mon, Oct 01, 2007 at 01:13:07PM +0100, richard wrote:
> Log message (3 lines):
> net/remoteconnection.cc: After calling read(), check
for received
> == 0 after checking for errors, so that if an EINTR
occurs in
> read, we don't report EOF instead of retrying.
> [...]
> http://xapian.org/C?9389?trunk/xapian-core/net
/remoteconnection.cc

I don't think this change is correct - if read() sets errno
then it
returns -1, so if read() returns 0 then it didn't set errno
and any
errno value we see comes from some earlier system or library
call.

Does this change fix a bug?  If so, there's probably a
missing errno
check elsewhere (and also, there should really be a
regression test!)

Cheers,
    Olly

_______________________________________________
Xapian-devel mailing list
Xapian-devellists.xapian.org
http://lists.xapian.org/mailman/listinfo/xapian-devel

On Sun, Oct 07, 2007 at 09:30:05AM +0100, Olly Betts wrote:
> On Mon, Oct 01, 2007 at 01:13:07PM +0100, richard
wrote:
> > http://xapian.org/C?9389?trunk/xapian-core/net
/remoteconnection.cc
> 
> I don't think this change is correct [...]

I've now noticed this change has since been backed out -
sorry for the
noise.

Cheers,
    Olly

_______________________________________________
Xapian-devel mailing list
Xapian-devellists.xapian.org
http://lists.xapian.org/mailman/listinfo/xapian-devel