Build Error in trunk (omega)

Hello,

There is a build error by what looks to be a typo in 
xapian-applications/omega/omega.cc

My checkout is about 15 minutes old, so it's possible it has
been caught 
since then.


omega.cc: In function ‘int main(int, char**)’:
omega.cc:204: error: ‘pretty_tery’ was not declared in this
scope
make[3]: *** [omega.o] Error 1
make[3]: Leaving directory 
`/home/rolson/projects/xapian/xapian/xapian-applications/ome
ga'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory 
`/home/rolson/projects/xapian/xapian/xapian-applications/ome
ga'
make[1]: *** [all] Error 2
make[1]: Leaving directory 
`/home/rolson/projects/xapian/xapian/xapian-applications/ome
ga'
make: *** [all] Error 2



The following patch should fix the typo (unless it's been
fixed already, 
or there really is a pretty_tery function somewhere).

--- /tmp/omega.cc.orig  2007-12-28 14:04:40.000000000 -0800
+++ xapian-applications/omega/omega.cc  2007-12-28
14:04:52.000000000 -0800
 -201,7
+201,7 
             for (Xapian::ESetIterator i = eset.begin(); i
!= 
eset.end(); i++) {
                 if ((*i).empty()) continue;
                 if (!query_string.empty()) query_string +=
' ';
-               query_string += pretty_tery(*i);
+               query_string += pretty_term(*i);
             }
         }
      }



Cheers,

Rick

_______________________________________________
Xapian-devel mailing list
Xapian-devellists.xapian.org
http://lists.xapian.org/mailman/listinfo/xapian-devel

Rick Olson wrote:
> Hello,
> 
> There is a build error by what looks to be a typo in 
> xapian-applications/omega/omega.cc
> 
> My checkout is about 15 minutes old, so it's possible
it has been caught 
> since then.
> 
> 
> omega.cc: In function ‘int main(int, char**)’:
> omega.cc:204: error: ‘pretty_tery’ was not declared in
this scope
> make[3]: *** [omega.o] Error 1
> make[3]: Leaving directory 
>
`/home/rolson/projects/xapian/xapian/xapian-applications/ome
ga'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory 
>
`/home/rolson/projects/xapian/xapian/xapian-applications/ome
ga'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory 
>
`/home/rolson/projects/xapian/xapian/xapian-applications/ome
ga'
> make: *** [all] Error 2

That's very odd; my checkout has "query_string +=
pretty_term(*i);" as 
line 204, and according to svn blame, that line hasn't
changed since SVN 
revision 4948 (on October 16th 2003).  Are you sure it's not
a local 
modification, or perhaps you are working on a branch?

-- 
Richard

_______________________________________________
Xapian-devel mailing list
Xapian-devellists.xapian.org
http://lists.xapian.org/mailman/listinfo/xapian-devel

Richard Boulton wrote:
> Rick Olson wrote:
>> Hello,
>>
>> There is a build error by what looks to be a typo
in 
>> xapian-applications/omega/omega.cc
>>
>> My checkout is about 15 minutes old, so it's
possible it has been 
>> caught since then.
>>
>>
>> omega.cc: In function ‘int main(int, char**)’:
>> omega.cc:204: error: ‘pretty_tery’ was not declared
in this scope
>> make[3]: *** [omega.o] Error 1
>> make[3]: Leaving directory 
>>
`/home/rolson/projects/xapian/xapian/xapian-applications/ome
ga'
>> make[2]: *** [all-recursive] Error 1
>> make[2]: Leaving directory 
>>
`/home/rolson/projects/xapian/xapian/xapian-applications/ome
ga'
>> make[1]: *** [all] Error 2
>> make[1]: Leaving directory 
>>
`/home/rolson/projects/xapian/xapian/xapian-applications/ome
ga'
>> make: *** [all] Error 2
>
> That's very odd; my checkout has "query_string +=
pretty_term(*i);" as 
> line 204, and according to svn blame, that line hasn't
changed since 
> SVN revision 4948 (on October 16th 2003).  Are you sure
it's not a 
> local modification, or perhaps you are working on a
branch?
>

Hmm, it was a fresh checkout of trunk... but who knows.  I
probably 
should have double checked first :p  svn blame does have it
correct.

--
Rick

_______________________________________________
Xapian-devel mailing list
Xapian-devellists.xapian.org
http://lists.xapian.org/mailman/listinfo/xapian-devel

On Sat, Dec 29, 2007 at 02:38:07AM -0800, Rick Olson wrote:
> Richard Boulton wrote:
> >Rick Olson wrote:
> >>omega.cc:204: error: ?pretty_tery? was not
declared in this scope
> >
> >That's very odd; my checkout has "query_string
+= pretty_term(*i);" as 
> >line 204, and according to svn blame, that line
hasn't changed since 
> >SVN revision 4948 (on October 16th 2003).  Are you
sure it's not a 
> >local modification, or perhaps you are working on a
branch?

It looks fine to me too, and indeed that code hasn't been
touched for
quite a while.

> Hmm, it was a fresh checkout of trunk... but who
knows.

Unless you accidentally changed it in an editor, all I can
think is that 
it's a hardware glitch or a software bug in one of your
tools.

It could be an indication of dodgy RAM or disks, though 'm'
-> 'y' isn't
a single bit change, which is more common for such problems
(it's two
bits away).

Does "svn status" report query.cc as 'M' (for
modified)?

Cheers,
    Olly

_______________________________________________
Xapian-devel mailing list
Xapian-devellists.xapian.org
http://lists.xapian.org/mailman/listinfo/xapian-devel