Hi!
> remove __midcom_baseclasses_database_topic constructor
Isn't this problem with every DBA object then and not just
the topic one?
The problem here is that DBA objects need a constructor as
they can be instantiated in three ways:
// Get empty topic
$object = new midcom_baseclasses_database_topic();
// Get topic by ID
$object = new midcom_baseclasses_database_topic(1);
// Get topic by GUID
$object = new
midcom_baseclasses_database_topic('guid');
... so we need a constructor that is able to call the
appropriate `get_by_id` and `get_by_guid` methods.
> lib/midcom/helper/_dbfactory.php , line 133 , probably
typo replace object with object->id
Fixed and committed.
> Fixed rcs dir permission (RCS service should be
optional IMO)
I think revision control is a quite mandatory CMS feature so
I'd like to keep it enabled by default and just ensure
distro packages handle their RCS dependencies.
But of course it is also easy to disable by default if we
decide so... just change the `midcom_services_rcs_enable` in
MidCOM configuration array (`config/midcom_config.php`).
> Provide at least two style templates. The only one
(empty one) is far from being nice for begginers
We need "more CMSy" style templates than Kubrick
for this. Once we have a good template or two we can then
add those as dependencies in `task_MidgardCMS`.
If somebody wants to Midgardize some templates from other
systems or <http://www.oswd.org/>
, contact me or adrenalin for instructions.
> Missed port for host in last SW step (finish/8)
The problem is that the midgard.admin.sitegroup library
doesn't have support for creating hosts to other ports than
0, so the information doesn't carry back to sitewizard.
Sitewizard does try to set this, so it should be fairly easy
to add specific port support to sitegroup just by utilizing
this key here:
$config->host_port = $host_settings['port'];
Once this gets stored to `$host->port`, sitewizard will
generate the link on the finish page correctly.
Actually, once we're working with m.a.sitegroup, we should
add another minor thing: set the `midcom.style` and
`midcom.style_inherit` parameters to point to the template
being used (not the substyle we created but actual template
style) so we can start utilizing substyled dynamic_loads
directly in the templates.
/Bergie
-----------
This message has been sent to the Midgard Forums on http://www
.midgard-project.org/discussion/
DO NOT reply to this message by email. If you want to reply
to it, go to https://ww
w.midgard-project.org/discussion/developer-forum/reply/b7dec
24ffdbde72dc7770d5ec372d63a.html
Go to h
ttps://www.midgard-project.org/discussion/account/ to
update your contact details or click https://www.midgard-project.org/discussion/subscriptions/
campaign/unsubscribe/25eded291764e251a0b57d1cb42d6c4d.html to unsubscribe.
|