Small patch to allow separate control charater higlighting

Dear monodevelopers!

This is a small patch to allow the separate highlighting of
control
characters. It's based on Revision 80598 from 23.06.2007.

The rational behind this patch is, that when I edit source
code I want
to see the tabs with special highlighting but not spaces and
newlines.
This allows me to identify indentation errors where tabs and
spaces are
mixed. But if I enable "ShowControlCharacters" I
am flooded with too
many charaters being highlighted.

So please tell me if you like a patch like this.
Looking forward to get this integrated, 

thanks Fabian

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

Hi!

Any ideas what I did wrong with this patch? I didn't get any
response.
Not even one saying it is bad :-(

thanks, Fabian

Am Sonntag, den 24.06.2007, 13:00 +0200 schrieb Fabian
Sturm:
> Dear monodevelopers!
> 
> This is a small patch to allow the separate
highlighting of control
> characters. It's based on Revision 80598 from
23.06.2007.


_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

On 6/27/07, Fabian Sturm <frtfs.org> wrote:
> Hi!
>
> Any ideas what I did wrong with this patch? I didn't
get any response.
> Not even one saying it is bad :-(

Hi Fabian.

I am afraid silence is not unusual on this list. :-(

I think your patch looks good, but I am not the one to
decide whether
it goes in or not.

Regards,
Jacob


>
> thanks, Fabian
>
> Am Sonntag, den 24.06.2007, 13:00 +0200 schrieb Fabian
Sturm:
> > Dear monodevelopers!
> >
> > This is a small patch to allow the separate
highlighting of control
> > characters. It's based on Revision 80598 from
23.06.2007.
>
>
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-listlists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-li
st
>
_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

Patch looks ok to me, but I'll leave it up to Lluis to
decide if he
wants the patch.

FWIW, this week is Novell's "Hack Week" so most of
us are busy hacking
on personal projects and haven't really been paying much
attention to
the mailing lists (which is probably why it's been quiet,
sorry about
that).

Jeff

On Sun, 2007-06-24 at 13:00 +0200, Fabian Sturm wrote:
> Dear monodevelopers!
> 
> This is a small patch to allow the separate
highlighting of control
> characters. It's based on Revision 80598 from
23.06.2007.
> 
> The rational behind this patch is, that when I edit
source code I want
> to see the tabs with special highlighting but not
spaces and newlines.
> This allows me to identify indentation errors where
tabs and spaces are
> mixed. But if I enable
"ShowControlCharacters" I am flooded with too
> many charaters being highlighted.
> 
> So please tell me if you like a patch like this.
> Looking forward to get this integrated, 
> 
> thanks Fabian
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-listlists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

El dc 27 de 06 del 2007 a les 15:37 -0400, en/na Jeffrey
Stedfast va
escriure:
> Patch looks ok to me, but I'll leave it up to Lluis to
decide if he
> wants the patch.

Well, it's ok to Lluis.

> 
> FWIW, this week is Novell's "Hack Week" so
most of us are busy hacking
> on personal projects and haven't really been paying
much attention to
> the mailing lists (which is probably why it's been
quiet, sorry about
> that).
> 
> Jeff
> 
> On Sun, 2007-06-24 at 13:00 +0200, Fabian Sturm wrote:
> > Dear monodevelopers!
> > 
> > This is a small patch to allow the separate
highlighting of control
> > characters. It's based on Revision 80598 from
23.06.2007.
> > 
> > The rational behind this patch is, that when I
edit source code I want
> > to see the tabs with special highlighting but not
spaces and newlines.
> > This allows me to identify indentation errors
where tabs and spaces are
> > mixed. But if I enable
"ShowControlCharacters" I am flooded with too
> > many charaters being highlighted.
> > 
> > So please tell me if you like a patch like this.
> > Looking forward to get this integrated, 
> > 
> > thanks Fabian
> > _______________________________________________
> > Monodevelop-list mailing list
> > Monodevelop-listlists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/monodevelop-li
st
> 
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-listlists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

Hi.

I was about to commit your patch and wanted to try it out
first. I
found two issues:

* After applying your patch MonoDevelop suddenly shows
control
characters even though I have disabled it in the
preferences
* I tried to change it in Edit/Preferences/Text
Editor/Markers and
Rulers but got an exception:

Exception occurred: Object reference not set to an instance
of an object

System.NullReferenceException: Object reference not set to
an instance
of an object
  at
MonoDevelop.SourceEditor.Gui.OptionPanels.MarkersTextEditorP
anel+MarkersTextEditorPanelWidget..ctor
() [0x00070] in
/home/jacobilsoe/Mono/monodevelop/Extras/MonoDevelop.SourceE
ditor/MonoDevelop.SourceEditor.Gui.OptionPanels/MarkersTextE
ditorPanel.cs:68
  at
MonoDevelop.SourceEditor.Gui.OptionPanels.MarkersTextEditorP
anel.LoadPanelContents
() [0x00000] in
/home/jacobilsoe/Mono/monodevelop/Extras/MonoDevelop.SourceE
ditor/MonoDevelop.SourceEditor.Gui.OptionPanels/MarkersTextE
ditorPanel.cs:34
  at
MonoDevelop.Core.Gui.Dialogs.AbstractOptionPanel.ReceiveDial
ogMessage
(DialogMessage message) [0x00020] in
/home/jacobilsoe/Mono/monodevelop/Core/src/MonoDevelop.Core.
Gui/MonoDevelop.Core.Gui.Dialogs/AbstractOptionPanel.cs:72

Could you look at that please?

Regards,
Jacob

On 6/24/07, Fabian Sturm <frtfs.org> wrote:
> Dear monodevelopers!
>
> This is a small patch to allow the separate
highlighting of control
> characters. It's based on Revision 80598 from
23.06.2007.
>
> The rational behind this patch is, that when I edit
source code I want
> to see the tabs with special highlighting but not
spaces and newlines.
> This allows me to identify indentation errors where
tabs and spaces are
> mixed. But if I enable
"ShowControlCharacters" I am flooded with too
> many charaters being highlighted.
>
> So please tell me if you like a patch like this.
> Looking forward to get this integrated,
>
> thanks Fabian
>
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-listlists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-li
st
>
>
>
_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

Hi!

> * After applying your patch MonoDevelop suddenly shows
control
> characters even though I have disabled it in the
preferences

I changed the default of an unset option to be false. Which
is closer
to the original behaviour. 

> * I tried to change it in Edit/Preferences/Text
Editor/Markers and
> Rulers but got an exception:

I found that one too. The patch I sent somehow had a typo in
the glade
file. It had Chech instead of Check. Sorry for that.

Could you please try this new patch?

Thanks, Fabian



_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

On 7/2/07, Fabian Sturm <frtfs.org> wrote:
> Hi!
>
> > * After applying your patch MonoDevelop suddenly
shows control
> > characters even though I have disabled it in the
preferences
>
> I changed the default of an unset option to be false.
Which is closer
> to the original behaviour.

Is the original behaviour not to have control character
highlighting
off by default?

>
> > * I tried to change it in Edit/Preferences/Text
Editor/Markers and
> > Rulers but got an exception:
>
> I found that one too. The patch I sent somehow had a
typo in the glade
> file. It had Chech instead of Check. Sorry for that.
>
> Could you please try this new patch?

Yes, works now.

>
> Thanks, Fabian
>
>
>
>
_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

Am Montag, den 02.07.2007, 22:05 +0200 schrieb Jacob Ilsø
Christensen:

> Is the original behaviour not to have control character
highlighting
> off by default?

Yes it definitively is. That 


_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

Opps, I didn't know that Ctrl-Enter sends the email
immediately in 
Evolution, kinda cute 

So the miss sentence is: 

"That was my fault."

Thanks, Fabian

P.s. I hope I can send more advanced patches for MD in the
future. Since
I really love it! Great work guys!

Am Montag, den 02.07.2007, 22:57 +0200 schrieb Fabian Sturm:
> Am Montag, den 02.07.2007, 22:05 +0200 schrieb Jacob
Ilsø Christensen:
> 
> > Is the original behaviour not to have control
character highlighting
> > off by default?
> 
> Yes it definitively is. That 


_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st