Fix improper member node command handling

Hello guys, 

This patch fixes improper node command handling incase of
partial
classes.

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

Hi!

I think that MemberNodeCommandHandler should use
IdeApp.ProjectOperations.JumpToDeclaration () to open the
file. I don't
know if JumpToDeclaration() will work for the case that your
patch fixes
though. You can try it, and if it doesn't maybe you can
apply the patch
there.

Lluis.

El dt 26 de 06 del 2007 a les 16:07 +0530, en/na Balaji Rao
va
escriure: 
> Hello guys, 
> 
> This patch fixes improper node command handling incase
of partial
> classes.
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-listlists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

On Thu, Jun 28, 2007 at 12:29:29AM +0200, Lluis Sanchez
wrote:
> Hi!
> 
> I think that MemberNodeCommandHandler should use
> IdeApp.ProjectOperations.JumpToDeclaration () to open
the file. I don't
> know if JumpToDeclaration() will work for the case that
your patch fixes
> though. You can try it, and if it doesn't maybe you can
apply the patch
> there.
> 
Fixed it. Is it ok now ?
> Lluis.
Regards,
Balaji Rao
> 
> El dt 26 de 06 del 2007 a les 16:07 +0530, en/na Balaji
Rao va
> escriure: 
> > Hello guys, 
> > 
> > This patch fixes improper node command handling
incase of partial
> > classes.
> > _______________________________________________
> > Monodevelop-list mailing list
> > Monodevelop-listlists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/monodevelop-li
st
> 

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

El dj 28 de 06 del 2007 a les 19:33 +0530, en/na Balaji Rao
va escriure:
> On Thu, Jun 28, 2007 at 12:29:29AM +0200, Lluis Sanchez
wrote:
> > Hi!
> > 
> > I think that MemberNodeCommandHandler should use
> > IdeApp.ProjectOperations.JumpToDeclaration () to
open the file. I don't
> > know if JumpToDeclaration() will work for the case
that your patch fixes
> > though. You can try it, and if it doesn't maybe
you can apply the patch
> > there.
> > 
> Fixed it. Is it ok now ?

Not yet:
      * Insted of
"typeof(IField).IsInstanceOfType(mem)" please use
"mem
        is IField".
      * To be consistent with the surrounding code, the
"file=
        c.Region.FileName" call should be "file =
GetClassFileName (c)".
      * The method CanJumpToDeclaration should be in sync
with
        JumpToDeclaration.
      * The patch is missing the corresponding ChangeLog
entries.

Thanks,
Lluis.

> > Lluis.
> Regards,
> Balaji Rao
> > 
> > El dt 26 de 06 del 2007 a les 16:07 +0530, en/na
Balaji Rao va
> > escriure: 
> > > Hello guys, 
> > > 
> > > This patch fixes improper node command
handling incase of partial
> > > classes.
> > >
_______________________________________________
> > > Monodevelop-list mailing list
> > > Monodevelop-listlists.ximian.com
> > > http://lists.ximian.com/mailman/listinfo/monodevelop-li
st
> > 
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-listlists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

On Sun, Jul 01, 2007 at 05:05:51PM +0200, Lluis Sanchez
wrote:
> El dj 28 de 06 del 2007 a les 19:33 +0530, en/na Balaji
Rao va escriure:
> > On Thu, Jun 28, 2007 at 12:29:29AM +0200, Lluis
Sanchez wrote:
> > > Hi!
Hi
> > > 
> > > I think that MemberNodeCommandHandler should
use
> > > IdeApp.ProjectOperations.JumpToDeclaration ()
to open the file. I don't
> > > know if JumpToDeclaration() will work for the
case that your patch fixes
> > > though. You can try it, and if it doesn't
maybe you can apply the patch
> > > there.
> > > 
> > Fixed it. Is it ok now ?
> 
> Not yet:
>       * Insted of
"typeof(IField).IsInstanceOfType(mem)" please use
"mem
>         is IField".
>       * To be consistent with the surrounding code, the
"file=
>         c.Region.FileName" call should be
"file = GetClassFileName (c)".
>       * The method CanJumpToDeclaration should be in
sync with
>         JumpToDeclaration.
>       * The patch is missing the corresponding
ChangeLog entries.
Along with the above changes, I have also improved the
CanJumpToDeclaration() and JumpToDeclaration in which I felt
that the
code was redundant.

I think it should be OK now. Is it?

Thank you
Balaji rao
> 
> Thanks,
> Lluis.
> 
> > > Lluis.
> > Regards,
> > Balaji Rao
> > > 
> > > El dt 26 de 06 del 2007 a les 16:07 +0530,
en/na Balaji Rao va
> > > escriure: 
> > > > Hello guys, 
> > > > 
> > > > This patch fixes improper node command
handling incase of partial
> > > > classes.
> > > >
_______________________________________________
> > > > Monodevelop-list mailing list
> > > > Monodevelop-listlists.ximian.com
> > > > http://lists.ximian.com/mailman/listinfo/monodevelop-li
st
> > > 
> > _______________________________________________
> > Monodevelop-list mailing list
> > Monodevelop-listlists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/monodevelop-li
st
> 

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

Patch committed. Thanks!

Lluis.

El dt 03 de 07 del 2007 a les 00:52 +0530, en/na Balaji Rao
va escriure:
> On Sun, Jul 01, 2007 at 05:05:51PM +0200, Lluis Sanchez
wrote:
> > El dj 28 de 06 del 2007 a les 19:33 +0530, en/na
Balaji Rao va escriure:
> > > On Thu, Jun 28, 2007 at 12:29:29AM +0200,
Lluis Sanchez wrote:
> > > > Hi!
> Hi
> > > > 
> > > > I think that MemberNodeCommandHandler
should use
> > > >
IdeApp.ProjectOperations.JumpToDeclaration () to open the
file. I don't
> > > > know if JumpToDeclaration() will work
for the case that your patch fixes
> > > > though. You can try it, and if it
doesn't maybe you can apply the patch
> > > > there.
> > > > 
> > > Fixed it. Is it ok now ?
> > 
> > Not yet:
> >       * Insted of
"typeof(IField).IsInstanceOfType(mem)" please use
"mem
> >         is IField".
> >       * To be consistent with the surrounding
code, the "file=
> >         c.Region.FileName" call should be
"file = GetClassFileName (c)".
> >       * The method CanJumpToDeclaration should be
in sync with
> >         JumpToDeclaration.
> >       * The patch is missing the corresponding
ChangeLog entries.
> Along with the above changes, I have also improved the
> CanJumpToDeclaration() and JumpToDeclaration in which I
felt that the
> code was redundant.
> 
> I think it should be OK now. Is it?
> 
> Thank you
> Balaji rao
> > 
> > Thanks,
> > Lluis.
> > 
> > > > Lluis.
> > > Regards,
> > > Balaji Rao
> > > > 
> > > > El dt 26 de 06 del 2007 a les 16:07
+0530, en/na Balaji Rao va
> > > > escriure: 
> > > > > Hello guys, 
> > > > > 
> > > > > This patch fixes improper node
command handling incase of partial
> > > > > classes.
> > > > >
_______________________________________________
> > > > > Monodevelop-list mailing list
> > > > > Monodevelop-listlists.ximian.com
> > > > > http://lists.ximian.com/mailman/listinfo/monodevelop-li
st
> > > > 
> > >
_______________________________________________
> > > Monodevelop-list mailing list
> > > Monodevelop-listlists.ximian.com
> > > http://lists.ximian.com/mailman/listinfo/monodevelop-li
st
> > 
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-listlists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st