On-the-fly parsing support for MonoDevelop

Hey Jérémie,

The code looks great, thanks! A few comments:

      * Commented code like this should be removed:

+                       /*string errorType = (type ==
ErrorType.Syntaxic) ? "synError" :
"semError";*/

      * You should unsubscribe ParseInformationChanged event
when the
        SourceEditorView is disposed, or you'll be holding
the editor
        object in memory forever.
      * I can't see the tooltip, it's never shown.
      * To commit the code we need the corresponding
ChangeLog entries.

Thanks,
Lluis.

El dj 13 de 09 del 2007 a les 13:16 +0200, en/na Jérémie /
Garuma / Kiri
va escriure:
> Hello everybody,
> 
> This patch implements the necessary bits to retrieve
parsing errors
> from NRefactory and the associated methods to show them
to the user by
> both underlining the errors in the text editor and
displaying error's
> description in the normal editor tooltips. 
> 
> Thanks.
> 
> LAVAL Jérémie
> jeremie.lavalgmail.com
> http://garuma.wordpress.c
om
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-listlists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

Attached is an updated version which comply to Mono coding
Guidelines
(no code change).

Le Thu, 20 Sep 2007 14:57:20 +0200,
"Jérémie Laval" <jeremie.lavalgmail.com> a écrit :

> Some up-to-date things  .
> 
> Attached is the patch that add the "visual"
part of autocorrection to
> Monodevelop (as the core changes are already in
Monodevelop SVN). To
> apply it go to
"$basedir/monodevelop/Extras/MonoDevelop.SourceEditor&q
uot;
> and patch with "cat SourceEditor.patch | patch
-p0".
> 
> If you have any suggestion either on the code or the
visual aspect
> ping me ;) .
> 
> 2007/9/13, Lluis Sanchez <lluisximian.com>:
> >
> > Hey Jérémie,
> >
> > The code looks great, thanks! A few comments:
> >
> >       * Commented code like this should be
removed:
> >
> > +                       /*string errorType = (type
==
> > ErrorType.Syntaxic) ? "synError" :
"semError";*/
> >
> >       * You should unsubscribe
ParseInformationChanged event when
> > the SourceEditorView is disposed, or you'll be
holding the editor
> >         object in memory forever.
> >       * I can't see the tooltip, it's never
shown.
> >       * To commit the code we need the
corresponding ChangeLog
> > entries.
> >
> > Thanks,
> > Lluis.
> >
> > El dj 13 de 09 del 2007 a les 13:16 +0200, en/na
Jérémie / Garuma /
> > Kiri va escriure:
> > > Hello everybody,
> > >
> > > This patch implements the necessary bits to
retrieve parsing
> > > errors from NRefactory and the associated
methods to show them to
> > > the user by both underlining the errors in
the text editor and
> > > displaying error's description in the normal
editor tooltips.
> > >
> > > Thanks.
> > >
> > > LAVAL Jérémie
> > > jeremie.lavalgmail.com
> > > http://garuma.wordpress.c
om
> > >
_______________________________________________
> > > Monodevelop-list mailing list
> > > Monodevelop-listlists.ximian.com
> > > http://lists.ximian.com/mailman/listinfo/monodevelop-li
st
> >
> >
-- 
LAVAL Jérémie
jeremie.lavalgmail.com
http://garuma.wordpress.c
om

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

Can you provide the ChangeLog for those changes? I'm going
to commit.

Thanks!
Lluis.

El dj 20 de 09 del 2007 a les 16:19 +0200, en/na Jérémie
LAVAL va
escriure:
> Attached is an updated version which comply to Mono
coding Guidelines
> (no code change).
> 
> Le Thu, 20 Sep 2007 14:57:20 +0200,
> "Jérémie Laval" <jeremie.lavalgmail.com> a écrit :
> 
> > Some up-to-date things  .
> > 
> > Attached is the patch that add the
"visual" part of autocorrection to
> > Monodevelop (as the core changes are already in
Monodevelop SVN). To
> > apply it go to
"$basedir/monodevelop/Extras/MonoDevelop.SourceEditor&q
uot;
> > and patch with "cat SourceEditor.patch |
patch -p0".
> > 
> > If you have any suggestion either on the code or
the visual aspect
> > ping me ;) .
> > 
> > 2007/9/13, Lluis Sanchez <lluisximian.com>:
> > >
> > > Hey Jérémie,
> > >
> > > The code looks great, thanks! A few
comments:
> > >
> > >       * Commented code like this should be
removed:
> > >
> > > +                       /*string errorType =
(type ==
> > > ErrorType.Syntaxic) ? "synError" :
"semError";*/
> > >
> > >       * You should unsubscribe
ParseInformationChanged event when
> > > the SourceEditorView is disposed, or you'll
be holding the editor
> > >         object in memory forever.
> > >       * I can't see the tooltip, it's never
shown.
> > >       * To commit the code we need the
corresponding ChangeLog
> > > entries.
> > >
> > > Thanks,
> > > Lluis.
> > >
> > > El dj 13 de 09 del 2007 a les 13:16 +0200,
en/na Jérémie / Garuma /
> > > Kiri va escriure:
> > > > Hello everybody,
> > > >
> > > > This patch implements the necessary bits
to retrieve parsing
> > > > errors from NRefactory and the
associated methods to show them to
> > > > the user by both underlining the errors
in the text editor and
> > > > displaying error's description in the
normal editor tooltips.
> > > >
> > > > Thanks.
> > > >
> > > > LAVAL Jérémie
> > > > jeremie.lavalgmail.com
> > > > http://garuma.wordpress.c
om
> > > >
_______________________________________________
> > > > Monodevelop-list mailing list
> > > > Monodevelop-listlists.ximian.com
> > > > http://lists.ximian.com/mailman/listinfo/monodevelop-li
st
> > >
> > >
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-listlists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st