List Info

Thread: ColorScheme support for GtkSourceview2




ColorScheme support for GtkSourceview2
user name
2007-12-29 06:31:14
Hi,

this patch:
 * adds a "color scheme" selector in the general text editor preferences
 * auto detects the color scheme used by gedit when using the GnomePlatform service

Let me know if the patch is ok to commit (I'll add ChangeLog entries if the patch is accepted)

-- Ben
  
Re: ColorScheme support for GtkSourceview2
user name
2007-12-29 14:43:37
On Dec 29, 2007 7:31 AM, Ben Motmans <ben.motmansgmail.com> wrote:
> Hi,
>
> this patch:
>  * adds a "color scheme" selector in the
general text editor preferences
>  * auto detects the color scheme used by gedit when
using the GnomePlatform
> service
>
> Let me know if the patch is ok to commit (I'll add
ChangeLog entries if the
> patch is accepted)


Look mostly good, except for the s/top_builddir/top_srcdir/
changes in
the makefile, and the duplication of a property with
"ColourScheme" --
we already use "GtkSourceViewStyleScheme". I
probably won't be in a
position to test it till Monday, but when you've fixed
these, please
commit to trunk (but not the 1.0 branch).

-- 
Michael Hutchinson
http://mjhutchinson.com
_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

Re: ColorScheme support for GtkSourceview2
user name
2007-12-29 16:07:56
Hey,

I didn't change the "top_srcdir"; stuff manually, monodevelop automatically changed it when I opened the solution.
Anyway, I'll fix those issues during the next couple of days.

-- Ben

On Dec 29, 2007 9:43 PM, Michael Hutchinson < m.j.hutchinsongmail.com">m.j.hutchinsongmail.com> wrote:
On Dec 29, 2007 7:31 AM, Ben Motmans < ben.motmansgmail.com">ben.motmansgmail.com> wrote:
>; Hi,
>
&gt; this patch:
>;  * adds a "color scheme&quot; selector in the general text editor preferences
>  * auto detects the color scheme used by gedit when using the GnomePlatform
> service
&gt;
> Let me know if the patch is ok to commit (I'll add ChangeLog entries if the
> patch is accepted)


Look mostly good, except for the s/top_builddir/top_srcdir/ changes in
the makefile, and the duplication of a property with "ColourScheme&quot; --
we already use "GtkSourceViewStyleScheme&quot;. I probably won't be in a
position to test it till Monday, but when you've fixed these, please
commit to trunk (but not the 1.0 branch).

--
Michael Hutchinson
http://mjhutchinson.com

Re: ColorScheme support for GtkSourceview2
user name
2007-12-29 16:43:31
On Dec 29, 2007 5:07 PM, Ben Motmans <ben.motmansgmail.com> wrote:
> Hey,
>
> I didn't change the "top_srcdir" stuff
manually, monodevelop automatically
> changed it when I opened the solution.

Oh, I realise that, as it happens to me sometimes. I was
just warning
you to be careful not to commit it.

-- 
Michael Hutchinson
http://mjhutchinson.com
_______________________________________________
Monodevelop-list mailing list
Monodevelop-listlists.ximian.com
http://lists.ximian.com/mailman/listinfo/monodevelop-li
st

[1-4]

about | contact  Other archives ( Real Estate discussion Medical topics )