List Info

Thread: pool/spl cleanup in netinet, netinet6, net




pool/spl cleanup in netinet, netinet6, net
user name
2006-07-20 14:44:00
On Thu, Jul 20, 2006 at 10:23:34AM -0400, Thor Lancelot
Simon wrote:
> On Thu, Jul 20, 2006 at 10:14:32AM -0400, Sean Boudreau
wrote:
> > On Thu, Jul 20, 2006 at 10:00:37AM -0400, Thor
Lancelot Simon wrote:
> > > On Thu, Jul 20, 2006 at 09:46:51AM -0400,
Sean Boudreau wrote:
> > > 
> > > > Are you sure in[6]_pcbpurgeif0(),
in[6]_purgeif()
> > > > and in[6]_pcbpurgeif() need
splsoftnet()?  This
> > > > seems to be outside the pool issue.
> > > 
> > > Yes, I'm sure: they can call the ICMP purge
routine, which
> > > does pool_put.
> > 
> > I don't see it.  What routine exactly does the
pool_put?
> 
> Sorry, IGMP.  igmp_purgeif() calls rti_delete, which
does pool_put.

So why not just put the splsoftnet around that particular
pool_put?

-seanb
pool/spl cleanup in netinet, netinet6, net
user name
2006-07-20 14:44:00
On Thu, Jul 20, 2006 at 10:23:34AM -0400, Thor Lancelot
Simon wrote:
> On Thu, Jul 20, 2006 at 10:14:32AM -0400, Sean Boudreau
wrote:
> > On Thu, Jul 20, 2006 at 10:00:37AM -0400, Thor
Lancelot Simon wrote:
> > > On Thu, Jul 20, 2006 at 09:46:51AM -0400,
Sean Boudreau wrote:
> > > 
> > > > Are you sure in[6]_pcbpurgeif0(),
in[6]_purgeif()
> > > > and in[6]_pcbpurgeif() need
splsoftnet()?  This
> > > > seems to be outside the pool issue.
> > > 
> > > Yes, I'm sure: they can call the ICMP purge
routine, which
> > > does pool_put.
> > 
> > I don't see it.  What routine exactly does the
pool_put?
> 
> Sorry, IGMP.  igmp_purgeif() calls rti_delete, which
does pool_put.

So why not just put the splsoftnet around that particular
pool_put?

-seanb
[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )