In article <20070530161321.GB2095 hairylemon.org>,
Andrew Doran <adnetbsd.org> wrote:
>On Tue, May 29, 2007 at 05:34:39PM -0500, David Young
wrote:
>
>> I believe such a change should have been sent to
tech-net for review
>> before it was committed.
>>
>> It looks like you have made unrelated changes to
if_ethersubr.c
>> and if_tap.c, which you have not described in the
commit message.
>>
>> You repeat this code all over:
>>
>> +#if defined(COMPAT_09) || defined(COMPAT_10) ||
defined(COMPAT_11) ||
>> + defined(COMPAT_12) || defined(COMPAT_13) ||
defined(COMPAT_14) ||
>> + defined(COMPAT_15) || defined(COMPAT_16) ||
defined(COMPAT_20) ||
>> + defined(COMPAT_30) || defined(COMPAT_40)
>> +#include <compat/sys/sockio.h>
>> +#endif
>
>Please let's not do stuff like this. Aside from being a
pain to manage, we
>need to fall back less on macros & compile time
options if having a modular
>kernel is to be a goal that we can achieve.
I will fix this.
christos
|
