IPSEC_NAT_T for FAST_IPSEC

Hi

I have finished to add support of IPSEC_NAT_T for
FAST_IPSEC. Tke key
management part is more or less directly taken from manu work so
most of
congrats is for him  

Can you review the following patch and if possible test it
on a real
configuration (I have done some tests but only on virtual
networks).  

If nobody object, I will commit it next week.

-- 
Arnaud Degroote
degrootenetbsd.org

degrooteNetBSD.org wrote:

> Can you review the following patch

Just only cosmetic part:
- ANSI style function declarations are better
- no need __P() at least for new functions
- memset() rather than bzero()
- IPSEC_NAT_T option should be defflag'ed in
files.netipsec?
- I wonder if some pointer casts might cause problems
  on gcc -fstrict-aliasing

---
Izumi Tsutsui

On Wed, Jun 20, 2007 at 06:51:23PM +0900, Izumi Tsutsui
wrote:
> 
> > Can you review the following patch
> 
> Just only cosmetic part:
> - ANSI style function declarations are better
> - no need __P() at least for new functions
> - memset() rather than bzero()

I tried to stay coherent with the current code. In a secund
time, I plan to
ansify all the  key management code.
> - IPSEC_NAT_T option should be defflag'ed in
files.netipsec?

It is already defflag'ed in files.ipsec so I can't defined
another time in
files.netipsec.

> - I wonder if some pointer casts might cause problems
>   on gcc -fstrict-aliasing

I have ran my test with kernel compiled with -O2. From the
documentation,
-O2 enables -fstrict-aliasing and I didn't notice any
strange things.

-- 
Arnaud Degroote
degrootenetbsd.org