pkgsrc Guide build failure

Trying to do "bmake OUTPUTS=html" in
pkgsrc/doc/guide is failing with:

===> Building for pkgsrc-guide-20070503
[Checking tools for typesetting...OK]
env SGML_CATALOG_FILES= 
XML_CATALOG_FILES="file:///build/reed/tmp/pkgsrc/doc/gu
ide/work.reed/pkgsrc-guide-20070503/../htdocs/en/share/xml/c
atalog.xml  
file:///build/reed/tmp/pkgsrc/doc/guide/work.reed/pkgsrc-gui
de-20070503/../htdocs/share/xml/catalog.xml  
file:///build/reed/tmp/pkgsrc/doc/guide/work.reed/pkgsrc-gui
de-20070503/../htdocs/share/xml/catalog-common.xml 
file:///home/reed/pkg/etc/xml/catalog"
/home/reed/pkg/bin/xsltproc 
--xinclude --nonet --catalogs   --param manifest
"'HTML.manifest'" --param 
toc.section.depth "'2'" --param toc.max.depth
"'8'" --param 
generate.section.toc.level "'0'" --param
section.autolabel "'1'" --param 
section.label.includes.component.label "'1'"
--param 
netbsd.url.image.bsddaemon 
"'../../../../../../../../images/BSD-daemon.jpg'"
--param 
netbsd.url.disclaimer "''" --param html.stylesheet
"'/NetBSD.css'" --param use.id.as.filename 
"'1'" --param citerefentry.link "'1'"
--param callout.graphics.path 
"'./imagelib/callouts/'" -o pkgsrc.html  
/build/reed/tmp/pkgsrc/doc/guide/work.reed/pkgsrc-guide-2007
0503/share/default-html.xsl 
default.xml
I/O error : Attempt to load network entity 
http://www.oasis-open.org/docbook/xml/4.2/dbcentx.mod
file:///build/reed/tmp/pkgsrc/doc/guide/work.reed/htdocs/sha
re/xml/xslt10-netbsd.dtd:16: 
warning: failed to load external entity 
"http://www.oasis-open.org/docbook/xml/4.2/dbcentx.mod
"
%dbcentx.mod;
             ^
Entity: line 1: 
 %dbcentx.mod; 
              ^
I/O error : Attempt to load network entity 
http://docbook.sourceforge.net/release/xsl/cu
rrent/html/docbook.xsl
warning: failed to load external entity 
"http://docbook.sourceforge.net/release/
xsl/current/html/docbook.xsl"
compilation error: file 
file:///build/reed/tmp/pkgsrc/doc/guide/work.reed/htdocs/sha
re/xsl/netbsd-docbook-html.xsl 
line 16 element import
xsl:import : unable to load 
http://docbook.sourceforge.net/release/xsl/cu
rrent/html/docbook.xsl
*** Error code 5


I have installed:

docbook-xml-4.4nb4  XML DTD designed for computer
documentation
docbook-xsl-1.72.0  Docbook XSL modular stylesheet
dsssl-docbook-modular-1.79nb2 DSSSL stylesheets for the
DocBook DTD
opensp-1.5.2        SGML parser, successor to
"sp"
tidy-20051026       Fixes and tidies up HTML files
libxslt-1.1.20      XSLT parser library from the GNOME
project
docbook-4.4nb2      SGML DTD designed for computer
documentation



  Jeremy C. Reed

I found the problem. At bottom of this email are some ideas
to fix it. 
Please suggest which one is best ...

On Thu, 3 May 2007, Jeremy C. Reed wrote:

> Trying to do "bmake OUTPUTS=html" in
pkgsrc/doc/guide is failing with:
...

> Entity: line 1: 
>  %dbcentx.mod; 
>               ^
> I/O error : Attempt to load network entity 
> http://docbook.sourceforge.net/release/xsl/cu
rrent/html/docbook.xsl
> warning: failed to load external entity 
> "http://docbook.sourceforge.net/release/
xsl/current/html/docbook.xsl"
> compilation error: file 
>
file:///build/reed/tmp/pkgsrc/doc/guide/work.reed/htdocs/sha
re/xsl/netbsd-docbook-html.xsl 
> line 16 element import
> xsl:import : unable to load 
> http://docbook.sourceforge.net/release/xsl/cu
rrent/html/docbook.xsl
> *** Error code 5

So I looked in my old email from April 2006 and see I had
same problem 
last year.

My workaround was:

mkdir /home/reed/pkg/etc/xml
ln -s /home/reed/etc/xml/catalog
/home/reed/pkg/etc/xml/catalog

And now it builds fine.

My problem is I use PKG_SYSCONFBASE=/home/reed/etc, but
something is using 
hard-coded $/etc/xml/catalog.

Looking farther in my mail, I see another workaround is to
set 
PKG_SYSCONFBASE=/home/reed/etc on my bmake line.

The htdocs/share/mk/web.site.mk checks for PKG_SYSCONFBASE
not 
PKG_SYSCONFDIR.

MAKE_ENV doesn't have that. It has:
PKG_SYSCONFDIR=/home/reed/etc

According to documentation: Packages must not use
PKG_SYSCONFBASE 
directly. (Although I see some do.)

Anyways I remove the symlink above and here is my other
work-around:

 do-build:
 .for _output_ in $
-       cd $ && $ $
$ $ $
+       cd $ && $ $
PKG_SYSCONFBASE=$ $
$ $
 .endfor


Should htdocs/share/mk/web.site.mk be fixed to check for
PKG_SYSCONFDIR?

Should MAKE_ENV just include PKG_SYSCONFBASE?

Should we include as a "build" dependency the
xmlcatmgr buildlink3.mk and 
modify htdocs/share/mk/web.site.mk to also use the
XML_DEFAULT_CATALOG 
defined there?

Or should I just commit this patch for doc/guide/Makefile
above?

  Jeremy C. Reed

On Thu, 3 May 2007, Jeremy C. Reed wrote:
> Should htdocs/share/mk/web.site.mk be fixed to check
for PKG_SYSCONFDIR?

I guess if this already checks for some magic pkgsrc
variable, and it's 
the wrong one, then that is the place to fix.

In general I'd prefer to induce as little pkgsrc magic into
other parts of 
the system (htdocs/share, htdocs/guide) as possible. 


  - Hubert