Bug in dev/hpc/hpcapm.c

Hi.

http://cvsweb.netbsd.org/bsdweb.cgi/src/
sys/dev/hpc/hpcapm.c?rev=1.2.4.1

It contains:

        sc->sc_battery_hook =
config_hook(CONFIG_HOOK_PMEVENT,
                                         
CONFIG_HOOK_PMEVENT_BATTERY,
                                          CONFIG_HOOK_SHARE,
                                          hpcapm_hook, sc);

        sc->sc_battery_hook =
config_hook(CONFIG_HOOK_PMEVENT,
                                         
CONFIG_HOOK_PMEVENT_AC,
                                          CONFIG_HOOK_SHARE,
                                          hpcapm_hook, sc);

Shouldn't the latter be replaced with sc->sc_ac_hook?

Regards,

-- 
[ Adam Wysocki, www.chmurka.net, GSM: +48 514 710 213 ]
[ Software Development Department, ArcaBit Sp. z o.o. ]
[ Ul. Fortuny 9 :: 01-339 Warszawa :: www.arcabit.com ]

On Tue, Aug 22, 2006 at 03:11:55 +0200, Adam Wysocki via
ArcaBit wrote:

> http://cvsweb.netbsd.org/bsdweb.cgi/src/
sys/dev/hpc/hpcapm.c?rev=1.2.4.1

Why not HEAD? (just curious)


> It contains:
> 
>         sc->sc_battery_hook =
config_hook(CONFIG_HOOK_PMEVENT,
>                                          
CONFIG_HOOK_PMEVENT_BATTERY,
>                                          
CONFIG_HOOK_SHARE,
>                                           hpcapm_hook,
sc);
> 
>         sc->sc_battery_hook =
config_hook(CONFIG_HOOK_PMEVENT,
>                                          
CONFIG_HOOK_PMEVENT_AC,
>                                          
CONFIG_HOOK_SHARE,
>                                           hpcapm_hook,
sc);
> 
> Shouldn't the latter be replaced with
sc->sc_ac_hook?

It should.  Fixed.  Thanks.

SY, Uwe
-- 
uweptc.spbu.ru                         |       Zu Grunde
kommen
http://snark.ptc.spbu.
ru/~uwe/          |       Ist zu Grunde gehen