Old World interrupts again

macallanNetBSD.org wrote:

> >> So what I did is to frob the tlp's IRQ line to
60 in pci_machdep.c 
> >> when
> >> finding a 2nd ohare interrupt controller and
rewrite half of extintr.c
> >> to support the following configurations:
> >
> > Looks good to me!
> 
> So if nobody objects I'll just commit and deal with the
fallout should 
> there be any.

Just humble cosmetics:

- it's better to have some macro for a magic 0x80006800?
- please don't use // commtents
- functions which don't take any args should be
"func(void)"
  (all functions should be ANSIfied after pullups?)
---
Izumi Tsutsui

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Sep 25, 2006, at 19:15, Izumi Tsutsui wrote:

> macallanNetBSD.org wrote:
>
>>>> So what I did is to frob the tlp's IRQ line
to 60 in pci_machdep.c
>>>> when
>>>> finding a 2nd ohare interrupt controller
and rewrite half of 
>>>> extintr.c
>>>> to support the following configurations:
>>>
>>> Looks good to me!
>>
>> So if nobody objects I'll just commit and deal with
the fallout should
>> there be any.
>
> Just humble cosmetics:
>
> - it's better to have some macro for a magic
0x80006800?

Yeah, maybe #define it as maketag(whatever) so it's more
obvious what 
it is.

> - please don't use // commtents

debugging leftover, won't get committed. I wanted to know if
there's 
something wrong with it in principle.

> - functions which don't take any args should be
"func(void)"
>   (all functions should be ANSIfied after pullups?)

Guess I'll finish the half-assed ansification.

have fun
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)

iQEVAwUBRRiFh8pnzkX8Yg2nAQJPFQgAsCut86F1Ra+RHh71QI8aoTnQpG0K
srH3
qNl3njacdnNhWoaFPiQCwSxYO9zwJRPl2iCYK8YERFG5FKP5HtTVUWE/KuHH
BIbm
fvv9CT2/UmHbqnhe8D8WwK14s5iAr2R/C+FTE2A2gIIK9/lnNrGpVuwJVrQ6
UEGq
m37DcUL3wfpIhAXRsF/10Cw8lvgjNM5UzSEHBt+uqTqKhkxTfVzN6DSbjm5p
HGle
8j19hHni5+r8kX21N37XeAyvLAT1C8MFjqgsd7Pr3nNRY/OozEKyN3WJZFS/
UF1M
USFc62nn9DmFc9dHJAFOhlwn/mUdx1SGwnaSwdrS9VrsHilvk7g28g==
=sTwL
-----END PGP SIGNATURE-----